{"id":20377,"url":"https://patchwork.libcamera.org/api/patches/20377/?format=json","web_url":"https://patchwork.libcamera.org/patch/20377/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240624192941.22943-11-laurent.pinchart@ideasonboard.com>","date":"2024-06-24T19:29:41","name":"[10/10] meson: Enable warnings to flag missing declarations","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e85c3600e411d29aceb8e79032a89f271752e328","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20377/mbox/","series":[{"id":4413,"url":"https://patchwork.libcamera.org/api/series/4413/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4413","date":"2024-06-24T19:29:31","name":"libcamera: Enable -Wmissing-declarations","version":1,"mbox":"https://patchwork.libcamera.org/series/4413/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20377/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20377/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A212ABD87C\n\tfor ;\n\tMon, 24 Jun 2024 19:30:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F417654B5;\n\tMon, 24 Jun 2024 21:30:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 67D7E654B9\n\tfor ;\n\tMon, 24 Jun 2024 21:30:17 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6035218ED;\n\tMon, 24 Jun 2024 21:29:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"N/FBfViG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719257395;\n\tbh=Z3r9SES2UEEA3C8Cg/pEsSQX92UQ+zuwr5bUSK9kb0k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=N/FBfViGCIlLMRvPjpJC1petsxDNr4Jm04CzQNi6k/aJ7mGloq3z+rE/2GSkBA3LF\n\toc20YY4xkEbsnfnov4Oq/m0tD0XyM0p2AfpUcz26/9Qk1Km/AMYpAGAQfiPwBScdoj\n\tpVA3eAhwS5evXdXcusISg6iUf15Q1JkiS4q5ojsk=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[PATCH 10/10] meson: Enable warnings to flag missing declarations","Date":"Mon, 24 Jun 2024 22:29:41 +0300","Message-ID":"<20240624192941.22943-11-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240624192941.22943-1-laurent.pinchart@ideasonboard.com>","References":"<20240624192941.22943-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A recently introduced typo resulted in a function definition not\nmatching its declaration. As the problem occurred in libipa, and IPA\nmodules are loaded dynamically and are linked with lazy symbol\nresolution, the problem wasn't caught at build time.\n\nTo try and catch future similar issues, enable the\n-Wmissing-declarations warning.\n\nSuggested-by: Barnabás Pőcze \nSigned-off-by: Laurent Pinchart \n---\n meson.build | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/meson.build b/meson.build\nindex 0ef4cdaafd76..2acd8c3e8cfe 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -95,6 +95,7 @@ if cc.has_header_symbol('stdlib.h', 'secure_getenv', prefix : '#define _GNU_SOUR\n endif\n \n common_arguments = [\n+ '-Wmissing-declarations',\n '-Wshadow',\n '-include', meson.current_build_dir() / 'config.h',\n ]\n","prefixes":["10/10"]}