{"id":20375,"url":"https://patchwork.libcamera.org/api/patches/20375/?format=json","web_url":"https://patchwork.libcamera.org/patch/20375/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240624192941.22943-9-laurent.pinchart@ideasonboard.com>","date":"2024-06-24T19:29:39","name":"[08/10] test: ipc: unixsocket: Define local function in anonymous namespace","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7c5168be1ba78c860d9c56cf6beb7af736e114c7","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20375/mbox/","series":[{"id":4413,"url":"https://patchwork.libcamera.org/api/series/4413/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4413","date":"2024-06-24T19:29:31","name":"libcamera: Enable -Wmissing-declarations","version":1,"mbox":"https://patchwork.libcamera.org/series/4413/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20375/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20375/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 336E7BD87C\n\tfor ;\n\tMon, 24 Jun 2024 19:30:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 716A5654BF;\n\tMon, 24 Jun 2024 21:30:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4802654B5\n\tfor ;\n\tMon, 24 Jun 2024 21:30:14 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C06BB1650;\n\tMon, 24 Jun 2024 21:29:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SKdglmMT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719257393;\n\tbh=WaH4L3NJ0vi0DBXLJq31p62+/GCmxmIVmgCqAjzse+A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SKdglmMTb0UGFHnhhTFBc5/9aaKIj63rDj/QB2HYu0Y5gbGIPmwOBsOlS7n+lahB2\n\tomIAnuhVuImpd7HqNbDCkB94rNBTBZQ1I4VWE3qCHOj/3U5pGYukqBcA9Gq2Nhn7E5\n\t399cWKwTwTbXJXL1sj3bTYKD/SNlmxEGcQeuO3wU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[PATCH 08/10] test: ipc: unixsocket: Define local function in\n\tanonymous namespace","Date":"Mon, 24 Jun 2024 22:29:39 +0300","Message-ID":"<20240624192941.22943-9-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240624192941.22943-1-laurent.pinchart@ideasonboard.com>","References":"<20240624192941.22943-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A local function in the unixsocket test is defined in the global\nnamespace without the static keyword. This compiles fine for now, but\nwill cause a missing declaration warning when we enable them. To prepare\nfor that, enclose the function declaration in an anonymous namespace.\n\nSigned-off-by: Laurent Pinchart \n---\n test/ipc/unixsocket.cpp | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/test/ipc/unixsocket.cpp b/test/ipc/unixsocket.cpp\nindex f44ab9c90e25..2546882da085 100644\n--- a/test/ipc/unixsocket.cpp\n+++ b/test/ipc/unixsocket.cpp\n@@ -34,6 +34,8 @@ using namespace libcamera;\n using namespace std;\n using namespace std::chrono_literals;\n \n+namespace {\n+\n int calculateLength(int fd)\n {\n \tlseek(fd, 0, 0);\n@@ -43,6 +45,8 @@ int calculateLength(int fd)\n \treturn size;\n }\n \n+} /* namespace */\n+\n class UnixSocketTestSlave\n {\n public:\n","prefixes":["08/10"]}