[{"id":30059,"web_url":"https://patchwork.libcamera.org/comment/30059/","msgid":"<171926496214.625657.10703824509082803455@ping.linuxembedded.co.uk>","date":"2024-06-24T21:36:02","subject":"Re: [PATCH 05/10] v4l2: v4l2_compat: Include missing headers","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-06-24 20:29:36)\n> The close() and ioctl() functions are declared in the unistd.h and\n> sys/ioctl.h headers. Include them to provide the declarations.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/v4l2/v4l2_compat.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/v4l2/v4l2_compat.cpp b/src/v4l2/v4l2_compat.cpp\n> index 8e2b7e924dfb..9dd1577dfbde 100644\n> --- a/src/v4l2/v4l2_compat.cpp\n> +++ b/src/v4l2/v4l2_compat.cpp\n> @@ -10,9 +10,11 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> +#include \n> \n> #include \n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AAE1BBDB1D\n\tfor ;\n\tMon, 24 Jun 2024 21:36:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 79B5E654A9;\n\tMon, 24 Jun 2024 23:36:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54C27654A1\n\tfor ;\n\tMon, 24 Jun 2024 23:36:05 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 516051650;\n\tMon, 24 Jun 2024 23:35:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sBSLJj7R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719264943;\n\tbh=lFoZXry61ukF/1MYOI8fVwcXhJPJyqk5iOZhQ0l/aiw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=sBSLJj7RE134ZBXBHxPV7E8QO+NfAY751Wp5vjOcZrBRnL9kaBvTweg9p4KBc0NbS\n\tynQyImYfpVfGQcFvXpeGqH31TBYrH2hzQavwHxScHP+Xz4O9YX4CTeXKHEbM72p0sr\n\tcd2BVwqmLd0spHAHYfC8kBY8UHESA0C5blLqAGPk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240624192941.22943-6-laurent.pinchart@ideasonboard.com>","References":"<20240624192941.22943-1-laurent.pinchart@ideasonboard.com>\n\t<20240624192941.22943-6-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 05/10] v4l2: v4l2_compat: Include missing headers","From":"Kieran Bingham ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 24 Jun 2024 22:36:02 +0100","Message-ID":"<171926496214.625657.10703824509082803455@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]