{"id":20372,"url":"https://patchwork.libcamera.org/api/patches/20372/?format=json","web_url":"https://patchwork.libcamera.org/patch/20372/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240624192941.22943-6-laurent.pinchart@ideasonboard.com>","date":"2024-06-24T19:29:36","name":"[05/10] v4l2: v4l2_compat: Include missing headers","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"2911ff60f3c4dc365b56ce044923afe28aceebdf","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20372/mbox/","series":[{"id":4413,"url":"https://patchwork.libcamera.org/api/series/4413/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4413","date":"2024-06-24T19:29:31","name":"libcamera: Enable -Wmissing-declarations","version":1,"mbox":"https://patchwork.libcamera.org/series/4413/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20372/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20372/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D52BBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 24 Jun 2024 19:30:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE5EE654BE;\n\tMon, 24 Jun 2024 21:30:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7490654B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Jun 2024 21:30:10 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D98EB1934;\n\tMon, 24 Jun 2024 21:29:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AvaWKqEi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719257389;\n\tbh=3sX8uGR0wTvKNMPbxF8Rntb9Hn5Vy6k0psjTkRrib08=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AvaWKqEiFoZ3HFtMMVQyfJ5qK6u9cMG6+fJgymr3X1rIBw/7tlnAhHAFnS5lUcbpg\n\tfEM4SDC5LgHNylAmzVC+kA1f0Z+rEZIOD4uTXXmKXbI54MxDJWD3oBJ+bivE4dzpqv\n\tp6WOZfhxK34AG5X1CDd7IwmeYntAIdfagO7cIYps=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>","Subject":"[PATCH 05/10] v4l2: v4l2_compat: Include missing headers","Date":"Mon, 24 Jun 2024 22:29:36 +0300","Message-ID":"<20240624192941.22943-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240624192941.22943-1-laurent.pinchart@ideasonboard.com>","References":"<20240624192941.22943-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The close() and ioctl() functions are declared in the unistd.h and\nsys/ioctl.h headers. Include them to provide the declarations.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/v4l2/v4l2_compat.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/v4l2/v4l2_compat.cpp b/src/v4l2/v4l2_compat.cpp\nindex 8e2b7e924dfb..9dd1577dfbde 100644\n--- a/src/v4l2/v4l2_compat.cpp\n+++ b/src/v4l2/v4l2_compat.cpp\n@@ -10,9 +10,11 @@\n #include <errno.h>\n #include <fcntl.h>\n #include <stdarg.h>\n+#include <sys/ioctl.h>\n #include <sys/mman.h>\n #include <sys/stat.h>\n #include <sys/types.h>\n+#include <unistd.h>\n \n #include <libcamera/base/utils.h>\n \n","prefixes":["05/10"]}