[{"id":30207,"web_url":"https://patchwork.libcamera.org/comment/30207/","msgid":"","date":"2024-07-02T10:57:26","subject":"Re: [PATCH v4 2/4] libcamera: software_isp: Drop unnecessary sanity\n\tcheck","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Mon, Jun 24, 2024 at 07:18:57PM +0530, Umang Jain wrote:\n> Currently the soft-isp outputs a single output stream. Hence,\n> drop the unnecessary check for stream indexes.\n> \n> Another reason to drop is actually the stream indexes is meant to be\n> unique in outputs std::map<>, hence checking for unique stream indexes\n> is redundant.\n> \n> Signed-off-by: Umang Jain \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/software_isp/software_isp.cpp | 9 +--------\n> 1 file changed, 1 insertion(+), 8 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index 20fb6f48..3fb7ec8c 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -287,12 +287,9 @@ int SoftwareIsp::exportBuffers(unsigned int output, unsigned int count,\n> int SoftwareIsp::queueBuffers(FrameBuffer *input,\n> \t\t\t const std::map &outputs)\n> {\n> -\tunsigned int mask = 0;\n> -\n> \t/*\n> \t * Validate the outputs as a sanity check: at least one output is\n> -\t * required, all outputs must reference a valid stream and no two\n> -\t * outputs can reference the same stream.\n> +\t * required, all outputs must reference a valid stream.\n> \t */\n> \tif (outputs.empty())\n> \t\treturn -EINVAL;\n> @@ -302,10 +299,6 @@ int SoftwareIsp::queueBuffers(FrameBuffer *input,\n> \t\t\treturn -EINVAL;\n> \t\tif (index >= 1) /* only single stream atm */\n> \t\t\treturn -EINVAL;\n> -\t\tif (mask & (1 << index))\n> -\t\t\treturn -EINVAL;\n> -\n> -\t\tmask |= 1 << index;\n> \t}\n> \n> \tprocess(input, outputs.at(0));\n> -- \n> 2.44.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EBAB5BEFBE\n\tfor ;\n\tTue, 2 Jul 2024 10:57:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A33762E24;\n\tTue, 2 Jul 2024 12:57:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C115C62E23\n\tfor ;\n\tTue, 2 Jul 2024 12:57:37 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 400895A4;\n\tTue, 2 Jul 2024 12:57:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ONIf94aC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719917830;\n\tbh=T1FKpsdGcLRdMGmJu5MS5EcLoqxMXBZe+FCEgPe4fYA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ONIf94aC2nZ4UWNL8RQEtSi8yJjWKFsj2L6k09zHGI2Nxvnbd4XHx4SnJGu12YlvJ\n\t7gGOepatdJs5zOqXcA6O8IgMa9KGftc94p8Y16wrZozgOMHxuW/zfW5mVigl0tsAOg\n\ti6xiDJFhm9LNsc0Pbs4lg5VbkloVsJcWx9hb6ax0=","Date":"Tue, 2 Jul 2024 19:57:26 +0900","From":"Paul Elder ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Subject":"Re: [PATCH v4 2/4] libcamera: software_isp: Drop unnecessary sanity\n\tcheck","Message-ID":"","References":"<20240624134859.171969-1-umang.jain@ideasonboard.com>\n\t<20240624134859.171969-3-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240624134859.171969-3-umang.jain@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]