[{"id":30039,"web_url":"https://patchwork.libcamera.org/comment/30039/","msgid":"","date":"2024-06-21T16:06:16","subject":"Re: [PATCH] ipa: libipa: matrix: Fix incorrect symbol namespace","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Fri, Jun 21, 2024 at 06:23:34PM GMT, Laurent Pinchart wrote:\n> The matrixVlidateYaml() function is declared in the libcamera::ipa::\n> namespace, but defined in the libcamera:: namespace. This causes a\n> dynamic linking error at runtime. Fix it by moving the function\n> definition.\n>\n> Signed-off-by: Laurent Pinchart \n\nThanks, it fixes the symbol lookup issue on my setup\nTested-by: Jacopo Mondi \n\n> ---\n> src/ipa/libipa/matrix.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/libipa/matrix.cpp b/src/ipa/libipa/matrix.cpp\n> index 7f000382d33b..8346f0d34160 100644\n> --- a/src/ipa/libipa/matrix.cpp\n> +++ b/src/ipa/libipa/matrix.cpp\n> @@ -122,8 +122,6 @@ namespace ipa {\n> * \\return Matrix sum of matrices \\a m1 and \\a m2\n> */\n>\n> -} /* namespace ipa */\n> -\n> #ifndef __DOXYGEN__\n> /*\n> * The YAML data shall be a list of numerical values. Its size shall be equal\n> @@ -146,4 +144,6 @@ bool matrixValidateYaml(const YamlObject &obj, unsigned int size)\n> }\n> #endif /* __DOXYGEN__ */\n>\n> +} /* namespace ipa */\n> +\n> } /* namespace libcamera */\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23844BD87C\n\tfor ;\n\tFri, 21 Jun 2024 16:06:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EB067654A2;\n\tFri, 21 Jun 2024 18:06:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8FA6D654A2\n\tfor ;\n\tFri, 21 Jun 2024 18:06:19 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:5d2e:52c9:cc1e:e404:491f:e6ea])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A44436EF;\n\tFri, 21 Jun 2024 18:05:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vVKTVuPp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718985959;\n\tbh=A2bnUB2nvAk6Jm9ih6d+H8efFwFFof/NhGAVpVu54FA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vVKTVuPp/pfxUpBEUQ7g/TcSdSLvYsJFEMdFo9RVop4vl96U98Reku9exj2pGMqV/\n\tLmbT65HW9lIpFBtpWFzbhit8HTm/nh2xkp2+Gye4m/XtG0z/k0Cg4DFX9GeOxmLhmf\n\tggfn8VVFENFV8fQeFwT5zbOSlBPL0Tw6GOekee4E=","Date":"Fri, 21 Jun 2024 18:06:16 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, \n\tJacopo Mondi ,\n\tPaul Elder ","Subject":"Re: [PATCH] ipa: libipa: matrix: Fix incorrect symbol namespace","Message-ID":"","References":"<20240621152334.30139-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240621152334.30139-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30040,"web_url":"https://patchwork.libcamera.org/comment/30040/","msgid":"","date":"2024-06-21T16:24:41","subject":"Re: [PATCH] ipa: libipa: matrix: Fix incorrect symbol namespace","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"2024. június 21., péntek 17:23 keltezéssel, Laurent Pinchart írta:\n\n> The matrixVlidateYaml() function is declared in the libcamera::ipa::\n> namespace, but defined in the libcamera:: namespace. This causes a\n> dynamic linking error at runtime. Fix it by moving the function\n> definition.\n\n`-Werror=missing-declarations` can catch this. Although it needs the following change\nas well to build:\n\ndiff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\nindex b5775e49..7da62b51 100644\n--- a/include/libcamera/base/log.h\n+++ b/include/libcamera/base/log.h\n@@ -48,6 +49,7 @@ private:\n extern const LogCategory &_LOG_CATEGORY(name)();\n \n #define LOG_DEFINE_CATEGORY(name) \\\n+LOG_DECLARE_CATEGORY(name) \\\n const LogCategory &_LOG_CATEGORY(name)() \\\n { \\\n /* The instance will be deleted by the Logger destructor. */ \\\n\n\nRegards,\nBarnabás Pőcze\n\n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/libipa/matrix.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/libipa/matrix.cpp b/src/ipa/libipa/matrix.cpp\n> index 7f000382d33b..8346f0d34160 100644\n> --- a/src/ipa/libipa/matrix.cpp\n> +++ b/src/ipa/libipa/matrix.cpp\n> @@ -122,8 +122,6 @@ namespace ipa {\n> * \\return Matrix sum of matrices \\a m1 and \\a m2\n> */\n> \n> -} /* namespace ipa */\n> -\n> #ifndef __DOXYGEN__\n> /*\n> * The YAML data shall be a list of numerical values. Its size shall be equal\n> @@ -146,4 +144,6 @@ bool matrixValidateYaml(const YamlObject &obj, unsigned int size)\n> }\n> #endif /* __DOXYGEN__ */\n> \n> +} /* namespace ipa */\n> +\n> } /* namespace libcamera */\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6EC6DBE175\n\tfor ;\n\tFri, 21 Jun 2024 16:24:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 61788654A9;\n\tFri, 21 Jun 2024 18:24:49 +0200 (CEST)","from mail-40133.protonmail.ch (mail-40133.protonmail.ch\n\t[185.70.40.133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0A5B654A2\n\tfor ;\n\tFri, 21 Jun 2024 18:24:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"iTElVj2B\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1718987085; x=1719246285;\n\tbh=7fL2THzsCMsNFqfcLjDmbzgnxMaLYyy2YjNZgM6EKtg=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=iTElVj2B83havbdnw6bWCDZN7FKgsKvr3WKqDjvir+McXEV09i0DmhcZrEquAwWh7\n\t1upr9W0LRcFtGYwRtXcwDyj+0Ls5BsQq2cdAixU1MHjl73B75FmbVCFMgSLTlb2Qu7\n\tduC8fQ/0NiukMQFJw1sbtOVsnJL9DQlns5qHmekAviVo62tN189THzGESuqH0VAa94\n\tuMx7U/o0/sqBWqTXR2wDahuJ7VJZ5oMWYCHp8rpT3788zfHbhXNtZ9m78qr/GXPkKC\n\tZebz3Uwt2PsHjFyqT2TFB0kGJasJxJug2uKNl/48/kWyuprChaWhV20OOP1gM+h+iJ\n\trSX8sfEy9v0zA==","Date":"Fri, 21 Jun 2024 16:24:41 +0000","To":"Laurent Pinchart ","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tJacopo Mondi ,\n\tPaul Elder ","Subject":"Re: [PATCH] ipa: libipa: matrix: Fix incorrect symbol namespace","Message-ID":"","In-Reply-To":"<20240621152334.30139-1-laurent.pinchart@ideasonboard.com>","References":"<20240621152334.30139-1-laurent.pinchart@ideasonboard.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"48fc1717fdf9ec3b42ae6068d64496606134d2a1","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30042,"web_url":"https://patchwork.libcamera.org/comment/30042/","msgid":"","date":"2024-06-24T06:06:19","subject":"Re: [PATCH] ipa: libipa: matrix: Fix incorrect symbol namespace","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Fri, Jun 21, 2024 at 06:23:34PM +0300, Laurent Pinchart wrote:\n> The matrixVlidateYaml() function is declared in the libcamera::ipa::\n\ns/Vlidate/Validate/\n\n> namespace, but defined in the libcamera:: namespace. This causes a\n> dynamic linking error at runtime. Fix it by moving the function\n> definition.\n\nOops...\n\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/libipa/matrix.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/libipa/matrix.cpp b/src/ipa/libipa/matrix.cpp\n> index 7f000382d33b..8346f0d34160 100644\n> --- a/src/ipa/libipa/matrix.cpp\n> +++ b/src/ipa/libipa/matrix.cpp\n> @@ -122,8 +122,6 @@ namespace ipa {\n> * \\return Matrix sum of matrices \\a m1 and \\a m2\n> */\n> \n> -} /* namespace ipa */\n> -\n> #ifndef __DOXYGEN__\n> /*\n> * The YAML data shall be a list of numerical values. Its size shall be equal\n> @@ -146,4 +144,6 @@ bool matrixValidateYaml(const YamlObject &obj, unsigned int size)\n> }\n> #endif /* __DOXYGEN__ */\n> \n> +} /* namespace ipa */\n> +\n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1BABBDB1D\n\tfor ;\n\tMon, 24 Jun 2024 06:06:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DAE0F654A9;\n\tMon, 24 Jun 2024 08:06:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0329D619D7\n\tfor ;\n\tMon, 24 Jun 2024 08:06:26 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2F82063C;\n\tMon, 24 Jun 2024 08:06:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DJ5IkfUA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719209165;\n\tbh=eAs/hg2nzUn98rE9zC/M7gCz4HAFOssAkxAGppm/2Fk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DJ5IkfUA6G1j6QTvAgbL0bGAOoRGCfQr+A16N6sY8rjKLjHFq4VhHmJ+OqIROOea7\n\t8PzKamNl5A0f9Be2hL3VcdNmknEoSD5G3gyD8vdM2dQc8oqhrwoJeFO8lIkPX+v/E6\n\t0nD4pcSIcTd/yz0YC7imGP8UQnDopIH49uw+GE3Y=","Date":"Mon, 24 Jun 2024 15:06:19 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org,\n\tJacopo Mondi ","Subject":"Re: [PATCH] ipa: libipa: matrix: Fix incorrect symbol namespace","Message-ID":"","References":"<20240621152334.30139-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240621152334.30139-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30044,"web_url":"https://patchwork.libcamera.org/comment/30044/","msgid":"<20240624080325.GA20309@pendragon.ideasonboard.com>","date":"2024-06-24T08:03:25","subject":"Re: [PATCH] ipa: libipa: matrix: Fix incorrect symbol namespace","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nOn Fri, Jun 21, 2024 at 04:24:41PM +0000, Barnabás Pőcze wrote:\n> 2024. június 21., péntek 17:23 keltezéssel, Laurent Pinchart írta:\n> \n> > The matrixVlidateYaml() function is declared in the libcamera::ipa::\n> > namespace, but defined in the libcamera:: namespace. This causes a\n> > dynamic linking error at runtime. Fix it by moving the function\n> > definition.\n> \n> `-Werror=missing-declarations` can catch this. Although it needs the following change\n> as well to build:\n> \n> diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\n> index b5775e49..7da62b51 100644\n> --- a/include/libcamera/base/log.h\n> +++ b/include/libcamera/base/log.h\n> @@ -48,6 +49,7 @@ private:\n> extern const LogCategory &_LOG_CATEGORY(name)();\n> \n> #define LOG_DEFINE_CATEGORY(name) \\\n> +LOG_DECLARE_CATEGORY(name) \\\n> const LogCategory &_LOG_CATEGORY(name)() \\\n> { \\\n> /* The instance will be deleted by the Logger destructor. */ \\\n> \n\nThat's a great idea. We considered in the past changing linker options\nto try and get the link to fail at build time but there were some\ndrawbacks (I don't recall the exact details). Adding\n-Werror=missing-declarations may not catch all problems, but it should\nhelp quite a bit (it would have caught this issue) without any real\ndownside. I'll send a patch.\n\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/ipa/libipa/matrix.cpp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/ipa/libipa/matrix.cpp b/src/ipa/libipa/matrix.cpp\n> > index 7f000382d33b..8346f0d34160 100644\n> > --- a/src/ipa/libipa/matrix.cpp\n> > +++ b/src/ipa/libipa/matrix.cpp\n> > @@ -122,8 +122,6 @@ namespace ipa {\n> > * \\return Matrix sum of matrices \\a m1 and \\a m2\n> > */\n> > \n> > -} /* namespace ipa */\n> > -\n> > #ifndef __DOXYGEN__\n> > /*\n> > * The YAML data shall be a list of numerical values. Its size shall be equal\n> > @@ -146,4 +144,6 @@ bool matrixValidateYaml(const YamlObject &obj, unsigned int size)\n> > }\n> > #endif /* __DOXYGEN__ */\n> > \n> > +} /* namespace ipa */\n> > +\n> > } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18EB5BDB1D\n\tfor ;\n\tMon, 24 Jun 2024 08:03:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FDE3654A2;\n\tMon, 24 Jun 2024 10:03:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B6C4619EA\n\tfor ;\n\tMon, 24 Jun 2024 10:03:47 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 222857E0;\n\tMon, 24 Jun 2024 10:03:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gqZRHyT/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719216205;\n\tbh=yegu3EwzYM9YnKq7YLd972+wHUFfVa3defwRZKw6lts=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gqZRHyT/0TYgmXtKbgYRn16Zbs/4UR7EYA24f0V39qYbqn9e1HmF8upD+5DqO/8w2\n\txuTV/f9w1uU2ipva5415Tdn0BK5sOmLz434+YToGsG+nIATxL/9Jxw8LB7rYjeckAY\n\t3a7KME8KreMo2fY6YfY5olcsaLC2lrRIXciIu3IM=","Date":"Mon, 24 Jun 2024 11:03:25 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tJacopo Mondi ,\n\tPaul Elder ","Subject":"Re: [PATCH] ipa: libipa: matrix: Fix incorrect symbol namespace","Message-ID":"<20240624080325.GA20309@pendragon.ideasonboard.com>","References":"<20240621152334.30139-1-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]