{"id":20352,"url":"https://patchwork.libcamera.org/api/patches/20352/?format=json","web_url":"https://patchwork.libcamera.org/patch/20352/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240617232525.878530-4-kieran.bingham@ideasonboard.com>","date":"2024-06-17T23:25:25","name":"[3/3] ipa: simple: Report black levels in metadata","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d6e101384d321e3e29dc0542e6a6a58e27528b66","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20352/mbox/","series":[{"id":4405,"url":"https://patchwork.libcamera.org/api/series/4405/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4405","date":"2024-06-17T23:25:22","name":"ipa: simple: Introduce metadata reporting","version":1,"mbox":"https://patchwork.libcamera.org/series/4405/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20352/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20352/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 671D1C3293\n\tfor ;\n\tMon, 17 Jun 2024 23:25:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8DFBD65492;\n\tTue, 18 Jun 2024 01:25:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF6476548D\n\tfor ;\n\tTue, 18 Jun 2024 01:25:29 +0200 (CEST)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 87918289;\n\tTue, 18 Jun 2024 01:25:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YwnUz4hZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718666712;\n\tbh=k3z1LjbhTNsU24ot7ttzPLAmYANO1cMflxdo1Clym20=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YwnUz4hZ8Ga+HBywIWKicBCGjCkvD/ZFftrSA/Tlhr66qzQO5BOcTaFhxv9zmhSqL\n\tDjCbnSjOAA7ULMpjWvRsTPUp1i3MK2IhT72mchtPjLl/NksqF4MOVomvyGUstWeKpX\n\tdRq4AigAB7csfreIezQjUyGTZN8zcyhEGT067ngs=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ","Subject":"[PATCH 3/3] ipa: simple: Report black levels in metadata","Date":"Tue, 18 Jun 2024 00:25:25 +0100","Message-Id":"<20240617232525.878530-4-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20240617232525.878530-1-kieran.bingham@ideasonboard.com>","References":"<20240617232525.878530-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide the determined black level values in the metadata\nto add to the completed requests.\n\nSigned-off-by: Kieran Bingham \n---\n src/ipa/simple/soft_simple.cpp | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex d35d28c26a3b..460fb216d49a 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -309,6 +309,10 @@ void IPASoftSimple::processStats(const ControlList &sensorControls)\n \tconst float gains[] = { gainR / maxGain, gainB / maxGain };\n \tmetadata.set(controls::ColourGains, gains);\n \n+\t/* Assign each of the R G G B channels as the same black level. */\n+\tconst auto blackLevels = { blackLevel, blackLevel, blackLevel, blackLevel };\n+\tmetadata.set(controls::SensorBlackLevels, blackLevels);\n+\n \tsetIspParams.emit(metadata);\n \n \t/* \\todo Switch to the libipa/algorithm.h API someday. */\n","prefixes":["3/3"]}