[{"id":30006,"web_url":"https://patchwork.libcamera.org/comment/30006/","msgid":"<171863739799.2248009.7886298990210003413@ping.linuxembedded.co.uk>","date":"2024-06-17T15:16:37","subject":"Re: [PATCH] ipa: rkisp1: agc: Rename frame context update variable\n\tto updateMetering","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-06-17 14:47:28)\n> The frame context agc.update variable is used to indicate if the ISP\n> histogram metering parameters need to be updated. Rename it to\n> updateMetering to make usage more explicit.\n> \n> Suggested-by: Paul Elder \n> Signed-off-by: Laurent Pinchart \n\nSounds clearer to me!\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 4 ++--\n> src/ipa/rkisp1/ipa_context.cpp | 4 ++--\n> src/ipa/rkisp1/ipa_context.h | 2 +-\n> 3 files changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 965030b62de5..f12f8b60de15 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -250,7 +250,7 @@ void Agc::queueRequest(IPAContext &context,\n> \n> const auto &meteringMode = controls.get(controls::AeMeteringMode);\n> if (meteringMode) {\n> - frameContext.agc.update = agc.meteringMode != *meteringMode;\n> + frameContext.agc.updateMetering = agc.meteringMode != *meteringMode;\n> agc.meteringMode =\n> static_cast(*meteringMode);\n> }\n> @@ -288,7 +288,7 @@ void Agc::prepare(IPAContext &context, const uint32_t frame,\n> frameContext.agc.gain = context.activeState.agc.automatic.gain;\n> }\n> \n> - if (frame > 0 && !frameContext.agc.update)\n> + if (frame > 0 && !frameContext.agc.updateMetering)\n> return;\n> \n> /* Configure the measurement window. */\n> diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\n> index ab6cfae17feb..9f3f576afcf7 100644\n> --- a/src/ipa/rkisp1/ipa_context.cpp\n> +++ b/src/ipa/rkisp1/ipa_context.cpp\n> @@ -317,8 +317,8 @@ namespace libcamera::ipa::rkisp1 {\n> * \\var IPAFrameContext::agc.maxFrameDuration\n> * \\brief Maximum frame duration as set by the FrameDurationLimits control\n> *\n> - * \\var IPAFrameContext::agc.update\n> - * \\brief Indicate if new ISP parameters need to be applied\n> + * \\var IPAFrameContext::agc.updateMetering\n> + * \\brief Indicate if new ISP AGC metering parameters need to be applied\n> */\n> \n> /**\n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index 7977590544fd..8602b408870e 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -123,7 +123,7 @@ struct IPAFrameContext : public FrameContext {\n> controls::AeExposureModeEnum exposureMode;\n> controls::AeMeteringModeEnum meteringMode;\n> utils::Duration maxFrameDuration;\n> - bool update;\n> + bool updateMetering;\n> } agc;\n> \n> struct {\n> \n> base-commit: 13a8fbeb5c8d10524f357b4f2eb566b7243d0b94\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A535C3237\n\tfor ;\n\tMon, 17 Jun 2024 15:16:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 955276548F;\n\tMon, 17 Jun 2024 17:16:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E39365489\n\tfor ;\n\tMon, 17 Jun 2024 17:16:41 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 155A339F;\n\tMon, 17 Jun 2024 17:16:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Zy+VkIgT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718637384;\n\tbh=vXVZoRNz1QE0hE/r4Nylp67XSU8ynhdIZhY3//Kllgk=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Zy+VkIgTw9xP+34ZSyRkgbF9OWQk0JAYLq4ugxpZpAaf0sxOvxrhCHf369SiDlpdf\n\tLb7CQVy4EQjhHEblDahjgCnE01B0WFgymyRmlIQo4J2dxkOO/CfY2aepXp+tfJrBGR\n\t77NVVVeswRDJquzPS8xt/CSEgn2/YaiNS+TaJMCA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240617134728.17477-1-laurent.pinchart@ideasonboard.com>","References":"<20240617134728.17477-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] ipa: rkisp1: agc: Rename frame context update variable\n\tto updateMetering","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 17 Jun 2024 16:16:37 +0100","Message-ID":"<171863739799.2248009.7886298990210003413@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]