{"id":20346,"url":"https://patchwork.libcamera.org/api/patches/20346/?format=json","web_url":"https://patchwork.libcamera.org/patch/20346/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240617134728.17477-1-laurent.pinchart@ideasonboard.com>","date":"2024-06-17T13:47:28","name":"ipa: rkisp1: agc: Rename frame context update variable to updateMetering","commit_ref":"a8de1f398ddc26a655756e8954fd4d90dff3b3fa","pull_url":null,"state":"accepted","archived":false,"hash":"7c2ff4ad67a67a937e19ee795e149997ee6f96cc","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20346/mbox/","series":[{"id":4402,"url":"https://patchwork.libcamera.org/api/series/4402/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4402","date":"2024-06-17T13:47:28","name":"ipa: rkisp1: agc: Rename frame context update variable to updateMetering","version":1,"mbox":"https://patchwork.libcamera.org/series/4402/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20346/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20346/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AA92BC3237\n\tfor ;\n\tMon, 17 Jun 2024 13:47:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D58C865491;\n\tMon, 17 Jun 2024 15:47:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81A1961A20\n\tfor ;\n\tMon, 17 Jun 2024 15:47:49 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E8F639F\n\tfor ;\n\tMon, 17 Jun 2024 15:47:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qriJUNIA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718632052;\n\tbh=F9EdTSDigZj81vaQv/Gf0lNGjqDPlTJVvRKy6dr0o1c=;\n\th=From:To:Subject:Date:From;\n\tb=qriJUNIA5lJ+Hy7ddoUOmCUFVs46vAaSlNDPxSrEpOFw585nOGDSB0laKrsoZu2BQ\n\tt7TGR/Dal7tHJnXPiVkze+ObayH/HmkAu5nmlUeq4RvFAZaBZTJC8gKaglpUNxZQKk\n\tM8zIyOOZpWp3a5hHiHnuBrjGP6m3Otxkgt4kqguE=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH] ipa: rkisp1: agc: Rename frame context update variable to\n\tupdateMetering","Date":"Mon, 17 Jun 2024 16:47:28 +0300","Message-ID":"<20240617134728.17477-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The frame context agc.update variable is used to indicate if the ISP\nhistogram metering parameters need to be updated. Rename it to\nupdateMetering to make usage more explicit.\n\nSuggested-by: Paul Elder \nSigned-off-by: Laurent Pinchart \n---\n src/ipa/rkisp1/algorithms/agc.cpp | 4 ++--\n src/ipa/rkisp1/ipa_context.cpp | 4 ++--\n src/ipa/rkisp1/ipa_context.h | 2 +-\n 3 files changed, 5 insertions(+), 5 deletions(-)\n\n\nbase-commit: 13a8fbeb5c8d10524f357b4f2eb566b7243d0b94","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 965030b62de5..f12f8b60de15 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -250,7 +250,7 @@ void Agc::queueRequest(IPAContext &context,\n \n \tconst auto &meteringMode = controls.get(controls::AeMeteringMode);\n \tif (meteringMode) {\n-\t\tframeContext.agc.update = agc.meteringMode != *meteringMode;\n+\t\tframeContext.agc.updateMetering = agc.meteringMode != *meteringMode;\n \t\tagc.meteringMode =\n \t\t\tstatic_cast(*meteringMode);\n \t}\n@@ -288,7 +288,7 @@ void Agc::prepare(IPAContext &context, const uint32_t frame,\n \t\tframeContext.agc.gain = context.activeState.agc.automatic.gain;\n \t}\n \n-\tif (frame > 0 && !frameContext.agc.update)\n+\tif (frame > 0 && !frameContext.agc.updateMetering)\n \t\treturn;\n \n \t/* Configure the measurement window. */\ndiff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\nindex ab6cfae17feb..9f3f576afcf7 100644\n--- a/src/ipa/rkisp1/ipa_context.cpp\n+++ b/src/ipa/rkisp1/ipa_context.cpp\n@@ -317,8 +317,8 @@ namespace libcamera::ipa::rkisp1 {\n * \\var IPAFrameContext::agc.maxFrameDuration\n * \\brief Maximum frame duration as set by the FrameDurationLimits control\n *\n- * \\var IPAFrameContext::agc.update\n- * \\brief Indicate if new ISP parameters need to be applied\n+ * \\var IPAFrameContext::agc.updateMetering\n+ * \\brief Indicate if new ISP AGC metering parameters need to be applied\n */\n \n /**\ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 7977590544fd..8602b408870e 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -123,7 +123,7 @@ struct IPAFrameContext : public FrameContext {\n \t\tcontrols::AeExposureModeEnum exposureMode;\n \t\tcontrols::AeMeteringModeEnum meteringMode;\n \t\tutils::Duration maxFrameDuration;\n-\t\tbool update;\n+\t\tbool updateMetering;\n \t} agc;\n \n \tstruct {\n","prefixes":[]}