[{"id":29983,"web_url":"https://patchwork.libcamera.org/comment/29983/","msgid":"<171861783661.2248009.15361137105359798363@ping.linuxembedded.co.uk>","date":"2024-06-17T09:50:36","subject":"Re: [PATCH 12/12] ipa: rkisp1: agc: Move AeEnable control to the AGC\n\talgorithm","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-06-16 17:39:10)\n> The AGC algorithm implements the AeEnable control at runtime. Move the\n> declaration of the control from the IPA module to the algorithm.\n> \n\n\\o/\n\nProgress on removing(reducing) those top level rkisp1Controls\n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 1 +\n> src/ipa/rkisp1/rkisp1.cpp | 1 -\n> 2 files changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 0018c43f18cf..965030b62de5 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -148,6 +148,7 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData)\n> if (ret)\n> return ret;\n> \n> + context.ctrlMap[&controls::AeEnable] = ControlInfo(false, true);\n> context.ctrlMap.merge(controls());\n> \n> return 0;\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 62d56a3ae44a..d31cdbab020b 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -106,7 +106,6 @@ const IPAHwSettings ipaHwSettingsV12{\n> \n> /* List of controls handled by the RkISP1 IPA */\n> const ControlInfoMap::Map rkisp1Controls{\n> - { &controls::AeEnable, ControlInfo(false, true) },\n> { &controls::AwbEnable, ControlInfo(false, true) },\n> { &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },\n> { &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE0C4C3237\n\tfor ;\n\tMon, 17 Jun 2024 09:50:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1989B65494;\n\tMon, 17 Jun 2024 11:50:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 558816548D\n\tfor ;\n\tMon, 17 Jun 2024 11:50:39 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E3D039F;\n\tMon, 17 Jun 2024 11:50:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"auVBdYz0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718617822;\n\tbh=S+rTgcuUwtsU4eJGTzhEeN3veGdmV3sP0bfhplj3eIA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=auVBdYz0wPGBu0zfeyHvMZhhur3Tigp7PnxOaODoYxmmo/uZOEvRJy5tRoA9n+aQG\n\t96VFXDp3xXwk8uzSAgwB7bESKQQGTXm7DyavYlajVR4ayMapFcNHGvhpVrcel571zu\n\tQjxpI0unw9CIqeL+/wxR1ekMLt4n1N+pmzDEbVns=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240616163910.5506-13-laurent.pinchart@ideasonboard.com>","References":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>\n\t<20240616163910.5506-13-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 12/12] ipa: rkisp1: agc: Move AeEnable control to the AGC\n\talgorithm","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 17 Jun 2024 10:50:36 +0100","Message-ID":"<171861783661.2248009.15361137105359798363@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29991,"web_url":"https://patchwork.libcamera.org/comment/29991/","msgid":"","date":"2024-06-17T10:19:56","subject":"Re: [PATCH 12/12] ipa: rkisp1: agc: Move AeEnable control to the AGC\n\talgorithm","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Sun, Jun 16, 2024 at 07:39:10PM +0300, Laurent Pinchart wrote:\n> The AGC algorithm implements the AeEnable control at runtime. Move the\n> declaration of the control from the IPA module to the algorithm.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 1 +\n> src/ipa/rkisp1/rkisp1.cpp | 1 -\n> 2 files changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 0018c43f18cf..965030b62de5 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -148,6 +148,7 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData)\n> \tif (ret)\n> \t\treturn ret;\n> \n> +\tcontext.ctrlMap[&controls::AeEnable] = ControlInfo(false, true);\n> \tcontext.ctrlMap.merge(controls());\n> \n> \treturn 0;\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 62d56a3ae44a..d31cdbab020b 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -106,7 +106,6 @@ const IPAHwSettings ipaHwSettingsV12{\n> \n> /* List of controls handled by the RkISP1 IPA */\n> const ControlInfoMap::Map rkisp1Controls{\n> -\t{ &controls::AeEnable, ControlInfo(false, true) },\n> \t{ &controls::AwbEnable, ControlInfo(false, true) },\n> \t{ &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },\n> \t{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CB22BD87C\n\tfor ;\n\tMon, 17 Jun 2024 10:20:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 413B26549C;\n\tMon, 17 Jun 2024 12:20:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5BAEE65498\n\tfor ;\n\tMon, 17 Jun 2024 12:20:02 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A64E42D5;\n\tMon, 17 Jun 2024 12:19:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r+nDqTs+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718619585;\n\tbh=OjW9ag9cS1Cgv1r6fzV2hxM47iWF5DgMmzWseYR/+e4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=r+nDqTs+KzExs28i4UYey00EJe90R+EOr0j32A7RqXPnFG3FqJnu9kSbOUdNEqL1D\n\tmNmyirwvGFIYhQDGzVofzrxL5HKVItis/lj2R4/32isWmgbNxShAJEMdM3JIFJ4tID\n\te4Bi4eAOoGX0Tn0AkvTA2k2A4HRyPvs7z7cBY+Qs=","Date":"Mon, 17 Jun 2024 19:19:56 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 12/12] ipa: rkisp1: agc: Move AeEnable control to the AGC\n\talgorithm","Message-ID":"","References":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>\n\t<20240616163910.5506-13-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240616163910.5506-13-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]