{"id":20336,"url":"https://patchwork.libcamera.org/api/patches/20336/?format=json","web_url":"https://patchwork.libcamera.org/patch/20336/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240616163910.5506-9-laurent.pinchart@ideasonboard.com>","date":"2024-06-16T16:39:06","name":"[08/12] ipa: rkisp1: agc: Simplify predivider calculation","commit_ref":"ea43e056a83fcfcf627669b4e5ee922d97c95d4b","pull_url":null,"state":"accepted","archived":false,"hash":"3c3bd6590ac5356c5ca5cf5349e36c6b2c40cd80","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20336/mbox/","series":[{"id":4400,"url":"https://patchwork.libcamera.org/api/series/4400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4400","date":"2024-06-16T16:38:58","name":"ipa: rkisp1: Miscellaneous AGC fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20336/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20336/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 033C6C3293\n\tfor ;\n\tSun, 16 Jun 2024 16:39:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F4196549E;\n\tSun, 16 Jun 2024 18:39:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0089E6549D\n\tfor ;\n\tSun, 16 Jun 2024 18:39:43 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EAA4B581\n\tfor ;\n\tSun, 16 Jun 2024 18:39:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fNpKPXXP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718555966;\n\tbh=C53sEocjWN6QqGh5FTS7x1cao59+Pmh6LGpurAx+yd4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=fNpKPXXPOj+g3M6DRI+kRbctNGWAWywiVp7TxlytiFrO14iSlvrGsg32dgvpFvSkT\n\t3U7jE42/dOZQD36tbuILBrZNcKWPPzhJ4LKcAOVtnletlLFEDtKbYXU17E4ff9WqG4\n\tlwkoYTiGWtF9aEofKXRyTjb8oBGTMdmtAFODvtn4=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 08/12] ipa: rkisp1: agc: Simplify predivider calculation","Date":"Sun, 16 Jun 2024 19:39:06 +0300","Message-ID":"<20240616163910.5506-9-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>","References":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The condition\n\n\tif (std::pow(std::floor(root), 2) < factor)\n\t\tpredivider = static_cast(std::ceil(root));\n\telse\n\t\tpredivider = static_cast(std::floor(root));\n\ncan only be false when the factor's root is an integer. In that case,\nstd::ceil(root) and std::floor(root) will be equal. The computation can\nthus be simplified by always rounding up.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/rkisp1/algorithms/agc.cpp | 7 +------\n 1 file changed, 1 insertion(+), 6 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 9f3b59b45f95..a61201bb05c9 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -115,12 +115,7 @@ uint8_t Agc::computeHistogramPredivider(const Size &size,\n \tint count = mode == RKISP1_CIF_ISP_HISTOGRAM_MODE_RGB_COMBINED ? 3 : 1;\n \tdouble factor = size.width * size.height * count / 65536.0;\n \tdouble root = std::sqrt(factor);\n-\tuint8_t predivider;\n-\n-\tif (std::pow(std::floor(root), 2) < factor)\n-\t\tpredivider = static_cast(std::ceil(root));\n-\telse\n-\t\tpredivider = static_cast(std::floor(root));\n+\tuint8_t predivider = static_cast(std::ceil(root));\n \n \treturn std::clamp(predivider, 3, 127);\n }\n","prefixes":["08/12"]}