[{"id":29976,"web_url":"https://patchwork.libcamera.org/comment/29976/","msgid":"<171861585676.2248009.6789611872388844851@ping.linuxembedded.co.uk>","date":"2024-06-17T09:17:36","subject":"Re: [PATCH 06/12] ipa: rkisp1: agc: Make size argument to\n\tcomputeHistogramPredivider const","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-06-16 17:39:04)\n> The Agc::computeHistogramPredivider() function doesn't need to modify\n> its size parameter. Make it const.\n> \n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 3 ++-\n> src/ipa/rkisp1/algorithms/agc.h | 2 +-\n> 2 files changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 0f60d08fd41c..9dac60bdb24e 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -84,7 +84,8 @@ int Agc::parseMeteringModes(IPAContext &context, const YamlObject &tuningData)\n> return 0;\n> }\n> \n> -uint8_t Agc::computeHistogramPredivider(Size &size, enum rkisp1_cif_isp_histogram_mode mode)\n> +uint8_t Agc::computeHistogramPredivider(const Size &size,\n> + enum rkisp1_cif_isp_histogram_mode mode)\n> {\n> /*\n> * The maximum number of pixels that could potentially be in one bin is\n> diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\n> index 996fea71755c..9ceaa82b099e 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.h\n> +++ b/src/ipa/rkisp1/algorithms/agc.h\n> @@ -45,7 +45,7 @@ public:\n> \n> private:\n> int parseMeteringModes(IPAContext &context, const YamlObject &tuningData);\n> - uint8_t computeHistogramPredivider(Size &size,\n> + uint8_t computeHistogramPredivider(const Size &size,\n> enum rkisp1_cif_isp_histogram_mode mode);\n> \n> void fillMetadata(IPAContext &context, IPAFrameContext &frameContext,\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6841EBD87C\n\tfor ;\n\tMon, 17 Jun 2024 09:17:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C1896548E;\n\tMon, 17 Jun 2024 11:17:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0834765489\n\tfor ;\n\tMon, 17 Jun 2024 11:17:40 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 28EA89C1;\n\tMon, 17 Jun 2024 11:17:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fC2A7k2e\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718615843;\n\tbh=+VrV+jfRB1RL7SWSraNj9oFZ7SlHUtbGfyRImbc3Ul8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=fC2A7k2eAUZfDew8W4/43IUgH0eQyK6NDpVu2fUbvlSCGka/12/SWnznRO9bCXckU\n\tO9Ajq+XTvTdVKOQL7FqRdKBrxEZc2yRiNjgUgciAxMMqv8rTurDyrXfPU9aSBYHunB\n\t82uN5I8cJ3kk/E2wPfZZPAmUZWOlDIB/dqpLCGG0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240616163910.5506-7-laurent.pinchart@ideasonboard.com>","References":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>\n\t<20240616163910.5506-7-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 06/12] ipa: rkisp1: agc: Make size argument to\n\tcomputeHistogramPredivider const","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 17 Jun 2024 10:17:36 +0100","Message-ID":"<171861585676.2248009.6789611872388844851@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29989,"web_url":"https://patchwork.libcamera.org/comment/29989/","msgid":"","date":"2024-06-17T10:12:37","subject":"Re: [PATCH 06/12] ipa: rkisp1: agc: Make size argument to\n\tcomputeHistogramPredivider const","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Sun, Jun 16, 2024 at 07:39:04PM +0300, Laurent Pinchart wrote:\n> The Agc::computeHistogramPredivider() function doesn't need to modify\n> its size parameter. Make it const.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 3 ++-\n> src/ipa/rkisp1/algorithms/agc.h | 2 +-\n> 2 files changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 0f60d08fd41c..9dac60bdb24e 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -84,7 +84,8 @@ int Agc::parseMeteringModes(IPAContext &context, const YamlObject &tuningData)\n> \treturn 0;\n> }\n> \n> -uint8_t Agc::computeHistogramPredivider(Size &size, enum rkisp1_cif_isp_histogram_mode mode)\n> +uint8_t Agc::computeHistogramPredivider(const Size &size,\n> +\t\t\t\t\tenum rkisp1_cif_isp_histogram_mode mode)\n> {\n> \t/*\n> \t * The maximum number of pixels that could potentially be in one bin is\n> diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\n> index 996fea71755c..9ceaa82b099e 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.h\n> +++ b/src/ipa/rkisp1/algorithms/agc.h\n> @@ -45,7 +45,7 @@ public:\n> \n> private:\n> \tint parseMeteringModes(IPAContext &context, const YamlObject &tuningData);\n> -\tuint8_t computeHistogramPredivider(Size &size,\n> +\tuint8_t computeHistogramPredivider(const Size &size,\n> \t\t\t\t\t enum rkisp1_cif_isp_histogram_mode mode);\n> \n> \tvoid fillMetadata(IPAContext &context, IPAFrameContext &frameContext,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1CC89C3237\n\tfor ;\n\tMon, 17 Jun 2024 10:12:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3AFA6549D;\n\tMon, 17 Jun 2024 12:12:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 367F365498\n\tfor ;\n\tMon, 17 Jun 2024 12:12:44 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A20CB2D5;\n\tMon, 17 Jun 2024 12:12:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jnWzNsC4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718619147;\n\tbh=F6vF4IwYis53BxxxHQSs0Xh86nR/EAyLIgSaFwRBWTI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jnWzNsC4hE8ecSrhoCMza4VhYtXBFcb8NqLbZ2Lm+p1S9IetkVHfvz7myy2cXsRev\n\trQeAGNTS6WpAI6MqRIfrSUScpYaxlLWfQrbJRWz+ubWzKtvc8eRfzqZoLmTKB4RJ/0\n\tnmqOzf1hrB3E86OdPkVpjl5bsbHS6AYe5jhD4UfM=","Date":"Mon, 17 Jun 2024 19:12:37 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 06/12] ipa: rkisp1: agc: Make size argument to\n\tcomputeHistogramPredivider const","Message-ID":"","References":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>\n\t<20240616163910.5506-7-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240616163910.5506-7-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]