[{"id":29975,"web_url":"https://patchwork.libcamera.org/comment/29975/","msgid":"<171861573087.2248009.14827594614637162921@ping.linuxembedded.co.uk>","date":"2024-06-17T09:15:30","subject":"Re: [PATCH 05/12] ipa: rkisp1: Document all AGC parameters in\n\tIPAFrameContext","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-06-16 17:39:03)\n> The IPAFrameContext AGC documentation is lagging behind the\n> implementation and misses many variables. Document them.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rkisp1/ipa_context.cpp | 22 ++++++++++++++++++++--\n> 1 file changed, 20 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\n> index c4895479204c..9e445dcca933 100644\n> --- a/src/ipa/rkisp1/ipa_context.cpp\n> +++ b/src/ipa/rkisp1/ipa_context.cpp\n> @@ -295,12 +295,30 @@ namespace libcamera::ipa::rkisp1 {\n> * applied to the sensor in order to take effect for this frame.\n> *\n> * \\var IPAFrameContext::agc.exposure\n> - * \\brief Exposure time expressed as a number of lines\n> + * \\brief Exposure time expressed as a number of lines computed by the algorithm\n> *\n> * \\var IPAFrameContext::agc.gain\n> - * \\brief Analogue gain multiplier\n> + * \\brief Analogue gain multiplier computed by the algorithm\n> *\n> * The gain should be adapted to the sensor specific gain code before applying.\n> + *\n> + * \\var IPAFrameContext::agc.autoEnabled\n> + * \\brief Manual/automatic AGC state as set by the AeEnable control\n> + *\n> + * \\var IPAFrameContext::agc.constraintMode\n> + * \\brief Constraint mode as set by the AeConstraintMode control\n> + *\n> + * \\var IPAFrameContext::agc.exposureMode\n> + * \\brief Exposure mode as set by the AeExposureMode control\n> + *\n> + * \\var IPAFrameContext::agc.meteringMode\n> + * \\brief Metering mode as set by the AeMeteringMode control\n> + *\n> + * \\var IPAFrameContext::agc.maxShutterSpeed\n> + * \\brief Maximum frame duration as set by the FrameDurationLimits control\n> + *\n> + * \\var IPAFrameContext::agc.update\n> + * \\brief Indicate if new ISP parameters need to be applied\n\n\nReviewed-by: Kieran Bingham \n\n> */\n> \n> /**\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6DF0DBD87C\n\tfor ;\n\tMon, 17 Jun 2024 09:15:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CE656548F;\n\tMon, 17 Jun 2024 11:15:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E492361A1C\n\tfor ;\n\tMon, 17 Jun 2024 11:15:33 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 01B2F9C1;\n\tMon, 17 Jun 2024 11:15:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Evv4KJwK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718615717;\n\tbh=4hrXs0BKQVIRl8jDCZ0UJyQpmaJK72vfgLBNP0hTsD0=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Evv4KJwKaU9DnojCt7Og1bDPb9WCR59fXL588jO+r3rhdVuuOSmOo3G2LCfITBSNK\n\tsVAu5iSUP/+GfHCDK4eN31/d+TbOjphf6nbjZyRqdPqlmyejULJPIDQG7zzTLcrTUZ\n\taUWQLhY3YYo3ZeE9npeTsXVhOkg361ogRrmGzezQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240616163910.5506-6-laurent.pinchart@ideasonboard.com>","References":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>\n\t<20240616163910.5506-6-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 05/12] ipa: rkisp1: Document all AGC parameters in\n\tIPAFrameContext","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 17 Jun 2024 10:15:30 +0100","Message-ID":"<171861573087.2248009.14827594614637162921@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30002,"web_url":"https://patchwork.libcamera.org/comment/30002/","msgid":"","date":"2024-06-17T13:10:43","subject":"Re: [PATCH 05/12] ipa: rkisp1: Document all AGC parameters in\n\tIPAFrameContext","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Sun, Jun 16, 2024 at 07:39:03PM +0300, Laurent Pinchart wrote:\n> The IPAFrameContext AGC documentation is lagging behind the\n> implementation and misses many variables. Document them.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/ipa_context.cpp | 22 ++++++++++++++++++++--\n> 1 file changed, 20 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\n> index c4895479204c..9e445dcca933 100644\n> --- a/src/ipa/rkisp1/ipa_context.cpp\n> +++ b/src/ipa/rkisp1/ipa_context.cpp\n> @@ -295,12 +295,30 @@ namespace libcamera::ipa::rkisp1 {\n> * applied to the sensor in order to take effect for this frame.\n> *\n> * \\var IPAFrameContext::agc.exposure\n> - * \\brief Exposure time expressed as a number of lines\n> + * \\brief Exposure time expressed as a number of lines computed by the algorithm\n> *\n> * \\var IPAFrameContext::agc.gain\n> - * \\brief Analogue gain multiplier\n> + * \\brief Analogue gain multiplier computed by the algorithm\n> *\n> * The gain should be adapted to the sensor specific gain code before applying.\n> + *\n> + * \\var IPAFrameContext::agc.autoEnabled\n> + * \\brief Manual/automatic AGC state as set by the AeEnable control\n> + *\n> + * \\var IPAFrameContext::agc.constraintMode\n> + * \\brief Constraint mode as set by the AeConstraintMode control\n> + *\n> + * \\var IPAFrameContext::agc.exposureMode\n> + * \\brief Exposure mode as set by the AeExposureMode control\n> + *\n> + * \\var IPAFrameContext::agc.meteringMode\n> + * \\brief Metering mode as set by the AeMeteringMode control\n> + *\n> + * \\var IPAFrameContext::agc.maxShutterSpeed\n> + * \\brief Maximum frame duration as set by the FrameDurationLimits control\n> + *\n> + * \\var IPAFrameContext::agc.update\n> + * \\brief Indicate if new ISP parameters need to be applied\n> */\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2D32C3237\n\tfor ;\n\tMon, 17 Jun 2024 13:10:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5BA4465494;\n\tMon, 17 Jun 2024 15:10:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E16A86548B\n\tfor ;\n\tMon, 17 Jun 2024 15:10:51 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C6FAC39F;\n\tMon, 17 Jun 2024 15:10:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YMRvr/1b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718629833;\n\tbh=UQo3ht8KqcJpPLcaGN3n3FM5f1suw18Glx0U90GrefQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YMRvr/1bqXp68cL1mzGqx+4moHVKyZEiD2tDro8EmWjcrHPGbY+CmhWY2GUGiyzBI\n\tvlqpfLQZC5bFzY0BmquiIDxsbJ+WPEvgYSV8CNSEwabqS4Val6xoL11WGF5O8qFt+8\n\tob+fTf0pP6lIUfotiNrWmSWT0H1igV0ErztLi6JQ=","Date":"Mon, 17 Jun 2024 22:10:43 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 05/12] ipa: rkisp1: Document all AGC parameters in\n\tIPAFrameContext","Message-ID":"","References":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>\n\t<20240616163910.5506-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240616163910.5506-6-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]