{"id":20333,"url":"https://patchwork.libcamera.org/api/patches/20333/?format=json","web_url":"https://patchwork.libcamera.org/patch/20333/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240616163910.5506-6-laurent.pinchart@ideasonboard.com>","date":"2024-06-16T16:39:03","name":"[05/12] ipa: rkisp1: Document all AGC parameters in IPAFrameContext","commit_ref":"9f04e8e1ffeb407d4a8f52775788358ce9740e11","pull_url":null,"state":"accepted","archived":false,"hash":"e9ca1bd6b0da90a49e76344d08867d06d753ffe3","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20333/mbox/","series":[{"id":4400,"url":"https://patchwork.libcamera.org/api/series/4400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4400","date":"2024-06-16T16:38:58","name":"ipa: rkisp1: Miscellaneous AGC fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20333/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20333/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7985C3293\n\tfor ;\n\tSun, 16 Jun 2024 16:39:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 510B765490;\n\tSun, 16 Jun 2024 18:39:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 639C865498\n\tfor ;\n\tSun, 16 Jun 2024 18:39:38 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0C1F0669\n\tfor ;\n\tSun, 16 Jun 2024 18:39:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZGMsFvdm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718555962;\n\tbh=8iyKf+bPjPmGAYDOMbRnHb6gd0OCoDzdVrGUby671Fg=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ZGMsFvdmsP/D1M+HT++MFp3k2xMkQj0JkuMblADLkhjIM0CDCMPi+YYyQouhZaiJn\n\tkAVe5xk0zI4+ZSWiiTGZSpyNM7A3xy7cqHqHkS7pAWrfJkiT2f0zjMQRqL4i8VOpac\n\tX3zqJPC6b2AWmJ9WucYeURSN0ChoHGkfsTGUVnMU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 05/12] ipa: rkisp1: Document all AGC parameters in\n\tIPAFrameContext","Date":"Sun, 16 Jun 2024 19:39:03 +0300","Message-ID":"<20240616163910.5506-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>","References":"<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The IPAFrameContext AGC documentation is lagging behind the\nimplementation and misses many variables. Document them.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/rkisp1/ipa_context.cpp | 22 ++++++++++++++++++++--\n 1 file changed, 20 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\nindex c4895479204c..9e445dcca933 100644\n--- a/src/ipa/rkisp1/ipa_context.cpp\n+++ b/src/ipa/rkisp1/ipa_context.cpp\n@@ -295,12 +295,30 @@ namespace libcamera::ipa::rkisp1 {\n * applied to the sensor in order to take effect for this frame.\n *\n * \\var IPAFrameContext::agc.exposure\n- * \\brief Exposure time expressed as a number of lines\n+ * \\brief Exposure time expressed as a number of lines computed by the algorithm\n *\n * \\var IPAFrameContext::agc.gain\n- * \\brief Analogue gain multiplier\n+ * \\brief Analogue gain multiplier computed by the algorithm\n *\n * The gain should be adapted to the sensor specific gain code before applying.\n+ *\n+ * \\var IPAFrameContext::agc.autoEnabled\n+ * \\brief Manual/automatic AGC state as set by the AeEnable control\n+ *\n+ * \\var IPAFrameContext::agc.constraintMode\n+ * \\brief Constraint mode as set by the AeConstraintMode control\n+ *\n+ * \\var IPAFrameContext::agc.exposureMode\n+ * \\brief Exposure mode as set by the AeExposureMode control\n+ *\n+ * \\var IPAFrameContext::agc.meteringMode\n+ * \\brief Metering mode as set by the AeMeteringMode control\n+ *\n+ * \\var IPAFrameContext::agc.maxShutterSpeed\n+ * \\brief Maximum frame duration as set by the FrameDurationLimits control\n+ *\n+ * \\var IPAFrameContext::agc.update\n+ * \\brief Indicate if new ISP parameters need to be applied\n */\n \n /**\n","prefixes":["05/12"]}