{"id":20321,"url":"https://patchwork.libcamera.org/api/patches/20321/?format=json","web_url":"https://patchwork.libcamera.org/patch/20321/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240614114016.116620-2-paul.elder@ideasonboard.com>","date":"2024-06-14T11:40:15","name":"[v4,1/2] utils: libtuning: modules: Add skeletal AGC module","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9e7f2af9e7ed1ebd7fe541724271fff169fc3e85","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20321/mbox/","series":[{"id":4395,"url":"https://patchwork.libcamera.org/api/series/4395/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4395","date":"2024-06-14T11:40:14","name":"utils: tuning: Add AGC and CCM","version":4,"mbox":"https://patchwork.libcamera.org/series/4395/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20321/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20321/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C597BD87C\n\tfor ;\n\tFri, 14 Jun 2024 11:40:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E944765491;\n\tFri, 14 Jun 2024 13:40:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5511465461\n\tfor ;\n\tFri, 14 Jun 2024 13:40:27 +0200 (CEST)","from neptunite.hamster-moth.ts.net\n\t(h175-177-049-156.catv02.itscom.jp [175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A306397;\n\tFri, 14 Jun 2024 13:40:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MDpkOGPh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718365212;\n\tbh=qTalvP1c38DjhyBGH9AGwHx+vIoJu7MvpD06BBa/+VQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MDpkOGPhmPC4YELHEc343yQsL58U5vMcc/lNfpQgdMZtr80E2zX/AgzXEMTgEM1NP\n\tv8w0qpqq4zmYQJLCopOs6xvw6YOhBYj6KXm+K8NcvBO34RLuiq41Q+KufIplbjdcWK\n\tZhr9/l/EqtRrLG+FJp0wFtk6vzEO/0kAtpMy206Y=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder ,\n\tStefan Klug ","Subject":"[PATCH v4 1/2] utils: libtuning: modules: Add skeletal AGC module","Date":"Fri, 14 Jun 2024 20:40:15 +0900","Message-Id":"<20240614114016.116620-2-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","In-Reply-To":"<20240614114016.116620-1-paul.elder@ideasonboard.com>","References":"<20240614114016.116620-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a skeletal AGC module just so that we can have some AGC tuning\nvalues that we can use to test during development of AGC in the IPAs. As\nrkisp1 is the main target, we only add support for rkisp1 for now.\n\nThe parameters are mostly copied from the hardcoded values in ctt,\nexcept for the metering modes.\n\nSigned-off-by: Paul Elder \nReviewed-by: Stefan Klug \n\n---\nChanges in v4:\n- remove support for both v10 and v12, and only support v10\n- remove piecewise linear function luminance targets\n\nChanges in v3:\n- remove unused compatible string\n- make gain start from 2 in the exposure modes\n\nChanges in v2:\n- remove unneccessary imports\n- add support for both v10 and v12\n---\n .../tuning/libtuning/modules/agc/__init__.py | 6 ++\n utils/tuning/libtuning/modules/agc/agc.py | 21 +++++\n utils/tuning/libtuning/modules/agc/rkisp1.py | 79 +++++++++++++++++++\n 3 files changed, 106 insertions(+)\n create mode 100644 utils/tuning/libtuning/modules/agc/__init__.py\n create mode 100644 utils/tuning/libtuning/modules/agc/agc.py\n create mode 100644 utils/tuning/libtuning/modules/agc/rkisp1.py","diff":"diff --git a/utils/tuning/libtuning/modules/agc/__init__.py b/utils/tuning/libtuning/modules/agc/__init__.py\nnew file mode 100644\nindex 000000000000..4db9ca371c68\n--- /dev/null\n+++ b/utils/tuning/libtuning/modules/agc/__init__.py\n@@ -0,0 +1,6 @@\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+#\n+# Copyright (C) 2024, Paul Elder \n+\n+from libtuning.modules.agc.agc import AGC\n+from libtuning.modules.agc.rkisp1 import AGCRkISP1\ndiff --git a/utils/tuning/libtuning/modules/agc/agc.py b/utils/tuning/libtuning/modules/agc/agc.py\nnew file mode 100644\nindex 000000000000..9c8899badc79\n--- /dev/null\n+++ b/utils/tuning/libtuning/modules/agc/agc.py\n@@ -0,0 +1,21 @@\n+# SPDX-License-Identifier: BSD-2-Clause\n+#\n+# Copyright (C) 2019, Raspberry Pi Ltd\n+# Copyright (C) 2024, Paul Elder \n+\n+from ..module import Module\n+\n+import libtuning as lt\n+\n+\n+class AGC(Module):\n+ type = 'agc'\n+ hr_name = 'AGC (Base)'\n+ out_name = 'GenericAGC'\n+\n+ # \\todo Add sector shapes and stuff just like lsc\n+ def __init__(self, *,\n+ debug: list):\n+ super().__init__()\n+\n+ self.debug = debug\ndiff --git a/utils/tuning/libtuning/modules/agc/rkisp1.py b/utils/tuning/libtuning/modules/agc/rkisp1.py\nnew file mode 100644\nindex 000000000000..babb441a8300\n--- /dev/null\n+++ b/utils/tuning/libtuning/modules/agc/rkisp1.py\n@@ -0,0 +1,79 @@\n+# SPDX-License-Identifier: BSD-2-Clause\n+#\n+# Copyright (C) 2019, Raspberry Pi Ltd\n+# Copyright (C) 2024, Paul Elder \n+#\n+# rkisp1.py - AGC module for tuning rkisp1\n+\n+from .agc import AGC\n+\n+import libtuning as lt\n+\n+\n+class AGCRkISP1(AGC):\n+ hr_name = 'AGC (RkISP1)'\n+ out_name = 'Agc'\n+\n+ def __init__(self, **kwargs):\n+ super().__init__(**kwargs)\n+\n+ # We don't actually need anything from the config file\n+ def validate_config(self, config: dict) -> bool:\n+ return True\n+\n+ def _generate_metering_modes(self) -> dict:\n+ centre_weighted = [\n+ 0, 0, 0, 0, 0,\n+ 0, 6, 8, 6, 0,\n+ 0, 8, 16, 8, 0,\n+ 0, 6, 8, 6, 0,\n+ 0, 0, 0, 0, 0\n+ ]\n+\n+ spot = [\n+ 0, 0, 0, 0, 0,\n+ 0, 2, 4, 2, 0,\n+ 0, 4, 16, 4, 0,\n+ 0, 2, 4, 2, 0,\n+ 0, 0, 0, 0, 0\n+ ]\n+\n+ matrix = [1 for i in range(0, 25)]\n+\n+ return {\n+ 'MeteringCentreWeighted': centre_weighted,\n+ 'MeteringSpot': spot,\n+ 'MeteringMatrix': matrix\n+ }\n+\n+ def _generate_exposure_modes(self) -> dict:\n+ normal = { 'shutter': [100, 10000, 30000, 60000, 120000],\n+ 'gain': [2.0, 4.0, 6.0, 6.0, 6.0]}\n+ short = { 'shutter': [100, 5000, 10000, 20000, 120000],\n+ 'gain': [2.0, 4.0, 6.0, 6.0, 6.0]}\n+\n+ return { 'ExposureNormal': normal, 'ExposureShort': short }\n+\n+ def _generate_constraint_modes(self) -> dict:\n+ normal = { 'lower': { 'qLo': 0.98, 'qHi': 1.0, 'yTarget': 0.5 } }\n+ highlight = {\n+ 'lower': { 'qLo': 0.98, 'qHi': 1.0, 'yTarget': 0.5 },\n+ 'upper': { 'qLo': 0.98, 'qHi': 1.0, 'yTarget': 0.8 }\n+ }\n+\n+ return { 'ConstraintNormal': normal, 'ConstraintHighlight': highlight }\n+\n+ def _generate_y_target(self) -> list:\n+ return 0.16\n+\n+ def process(self, config: dict, images: list, outputs: dict) -> dict:\n+ output = {}\n+\n+ output['AeMeteringMode'] = self._generate_metering_modes()\n+ output['AeExposureMode'] = self._generate_exposure_modes()\n+ output['AeConstraintMode'] = self._generate_constraint_modes()\n+ output['relativeLuminanceTarget'] = self._generate_y_target()\n+\n+ # \\todo Debug functionality\n+\n+ return output\n","prefixes":["v4","1/2"]}