[{"id":29938,"web_url":"https://patchwork.libcamera.org/comment/29938/","msgid":"<171830749595.2248009.8795190906149542801@ping.linuxembedded.co.uk>","date":"2024-06-13T19:38:15","subject":"Re: [PATCH 7/7] libcamera: mali-c55: Record stride in rawConfig","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally (2024-06-13 16:59:49)\n> The DNGWriter class needs to know the stride of a RAW image for some\n> of its uses. Add stride to rawConfig in the mali-c55 pipeline handler\n> so that it's available to DNGWriter.\n> \n> Signed-off-by: Daniel Scally \n> ---\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index 9cd243a3..a9ea2e04 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -382,6 +382,9 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n> \n> maxSize = rawSize;\n> \n> + const PixelFormatInfo &info = PixelFormatInfo::info(rawConfig->pixelFormat);\n> + rawConfig->stride = info.stride(rawConfig->size.width, 0, 64);\n> +\n\nDoes the frameSize also get set? I would anticipate the two being\ntogether.\n\nWe should add such tests to lc-compliance to make sure the\nconfigurations are fully populated after validation.\n\nBut I think this one stands...\n\n\nReviewed-by: Kieran Bingham \n\n> rawConfig->setStream(const_cast(&data_->frStream_));\n> frPipeAvailable = false;\n> }\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9823ABD87C\n\tfor ;\n\tThu, 13 Jun 2024 19:38:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 492246548F;\n\tThu, 13 Jun 2024 21:38:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F1DA6548B\n\tfor ;\n\tThu, 13 Jun 2024 21:38:18 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E6274CF;\n\tThu, 13 Jun 2024 21:38:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VomVDV/o\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718307484;\n\tbh=WvuILEm+D1StAWfOOk831XSttJ97Jc1qBEwnm89lolM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=VomVDV/o7sZvudUY+I4hmhhhV99r1lRnRcpTG23LI/XOOTLIJkDCoXL0yUmVf68W9\n\txBfvp8fNHsh+6oc9KVH1wJhPRTmC8wjYYS/W3I65jV2UjDmIquy07RuSmUm2WOfNp5\n\tVCqj+k5qVawml2BiyKvnmdjtM850lLUY0IvXmSFE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240613155949.1041061-8-dan.scally@ideasonboard.com>","References":"<20240613155949.1041061-1-dan.scally@ideasonboard.com>\n\t<20240613155949.1041061-8-dan.scally@ideasonboard.com>","Subject":"Re: [PATCH 7/7] libcamera: mali-c55: Record stride in rawConfig","From":"Kieran Bingham ","Cc":"Daniel Scally ","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 13 Jun 2024 20:38:15 +0100","Message-ID":"<171830749595.2248009.8795190906149542801@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29968,"web_url":"https://patchwork.libcamera.org/comment/29968/","msgid":"<20240617051550.GI28126@pendragon.ideasonboard.com>","date":"2024-06-17T05:15:50","subject":"Re: [PATCH 7/7] libcamera: mali-c55: Record stride in rawConfig","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jun 13, 2024 at 08:38:15PM +0100, Kieran Bingham wrote:\n> Quoting Daniel Scally (2024-06-13 16:59:49)\n> > The DNGWriter class needs to know the stride of a RAW image for some\n> > of its uses. Add stride to rawConfig in the mali-c55 pipeline handler\n> > so that it's available to DNGWriter.\n\nAs mentioned by Kieran in the review of a previous patch, this may be\ntrue, but it's hardly the reason.\n\n> > Signed-off-by: Daniel Scally \n> > ---\n> > src/libcamera/pipeline/mali-c55/mali-c55.cpp | 3 +++\n> > 1 file changed, 3 insertions(+)\n> > \n> > diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> > index 9cd243a3..a9ea2e04 100644\n> > --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> > +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> > @@ -382,6 +382,9 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n> > \n> > maxSize = rawSize;\n> > \n> > + const PixelFormatInfo &info = PixelFormatInfo::info(rawConfig->pixelFormat);\n> > + rawConfig->stride = info.stride(rawConfig->size.width, 0, 64);\n> > +\n> \n> Does the frameSize also get set? I would anticipate the two being\n> together.\n\nThis patch should set both.\n\n> We should add such tests to lc-compliance to make sure the\n> configurations are fully populated after validation.\n> \n> But I think this one stands...\n> \n> Reviewed-by: Kieran Bingham \n> \n> > rawConfig->setStream(const_cast(&data_->frStream_));\n> > frPipeAvailable = false;\n> > }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 49C29C3237\n\tfor ;\n\tMon, 17 Jun 2024 05:16:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4169965490;\n\tMon, 17 Jun 2024 07:16:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FFE765489\n\tfor ;\n\tMon, 17 Jun 2024 07:16:11 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5306A9C1;\n\tMon, 17 Jun 2024 07:15:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rBs2BTEY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718601354;\n\tbh=OfYIpxG+Gm0QB43u7zSlpPLialI5iJtGAaPkbC1uUh0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rBs2BTEYeRSjS+Tsk08dwh5QVGlbBHgeO39nhn2jt8R1Kj/kxH47GQj7VUlqr5qcs\n\tngIrEU7JcOsrGssMT/qeZh0tz5pXFf/lOe0lz5V1j6RvIQNBpyyYWAoq2hqoS9IvQo\n\trdPVNk9CfxuQA/l4PMaYeqG26VuJPrhfsyymyGbA=","Date":"Mon, 17 Jun 2024 08:15:50 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 7/7] libcamera: mali-c55: Record stride in rawConfig","Message-ID":"<20240617051550.GI28126@pendragon.ideasonboard.com>","References":"<20240613155949.1041061-1-dan.scally@ideasonboard.com>\n\t<20240613155949.1041061-8-dan.scally@ideasonboard.com>\n\t<171830749595.2248009.8795190906149542801@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<171830749595.2248009.8795190906149542801@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]