[{"id":29937,"web_url":"https://patchwork.libcamera.org/comment/29937/","msgid":"<171830742327.2248009.3756815672411838672@ping.linuxembedded.co.uk>","date":"2024-06-13T19:37:03","subject":"Re: [PATCH 6/7] libcamera: mali-c55: Remove\n\tMaliC55CameraData::mbusCodes()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally (2024-06-13 16:59:48)\n> The MaliC55CameraData::mbusCodes() function is unused. Remove it.\n> \n> Signed-off-by: Daniel Scally \n\nWell, that's easy.\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 9 ---------\n> 1 file changed, 9 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index 910eac5e..9cd243a3 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -94,7 +94,6 @@ public:\n> int init();\n> \n> /* Deflect these functionalities to either TPG or CameraSensor. */\n> - const std::vector mbusCodes() const;\n> const std::vector sizes(unsigned int mbusCode) const;\n> const Size resolution() const;\n> \n> @@ -179,14 +178,6 @@ void MaliC55CameraData::initTPGData()\n> tpgResolution_ = tpgSizes_.back();\n> }\n> \n> -const std::vector MaliC55CameraData::mbusCodes() const\n> -{\n> - if (sensor_)\n> - return sensor_->mbusCodes();\n> -\n> - return tpgCodes_;\n> -}\n> -\n> const std::vector MaliC55CameraData::sizes(unsigned int mbusCode) const\n> {\n> if (sensor_)\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35C92BD87C\n\tfor ;\n\tThu, 13 Jun 2024 19:37:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DABA065494;\n\tThu, 13 Jun 2024 21:37:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C6EB6548D\n\tfor ;\n\tThu, 13 Jun 2024 21:37:05 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 41F0E4CF;\n\tThu, 13 Jun 2024 21:36:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p7M1yxf3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718307411;\n\tbh=UmXraPlGdNFxVjq/Rfjb1AbEwCcV1XSBJblNsvEGhgY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=p7M1yxf3+MS/WD07Z5aQbsIwlC/EwhrZFe9X90Dktv/S7sIMPT1ByFxlljh23ma8E\n\tNPctGaXjUuYkxkT9j1+KlekXVlPTOMZbF3XbgUQ1/60tqsBU/6utl9IWCYMJWz6SUz\n\tD70nbllUnV4Nz9uSjSW9Qg02WvOzA+boil16Nq/4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240613155949.1041061-7-dan.scally@ideasonboard.com>","References":"<20240613155949.1041061-1-dan.scally@ideasonboard.com>\n\t<20240613155949.1041061-7-dan.scally@ideasonboard.com>","Subject":"Re: [PATCH 6/7] libcamera: mali-c55: Remove\n\tMaliC55CameraData::mbusCodes()","From":"Kieran Bingham ","Cc":"Daniel Scally ","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 13 Jun 2024 20:37:03 +0100","Message-ID":"<171830742327.2248009.3756815672411838672@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29967,"web_url":"https://patchwork.libcamera.org/comment/29967/","msgid":"<20240617051339.GH28126@pendragon.ideasonboard.com>","date":"2024-06-17T05:13:39","subject":"Re: [PATCH 6/7] libcamera: mali-c55: Remove\n\tMaliC55CameraData::mbusCodes()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jun 13, 2024 at 08:37:03PM +0100, Kieran Bingham wrote:\n> Quoting Daniel Scally (2024-06-13 16:59:48)\n> > The MaliC55CameraData::mbusCodes() function is unused. Remove it.\n> > \n> > Signed-off-by: Daniel Scally \n> \n> Well, that's easy.\n> \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> > ---\n> > src/libcamera/pipeline/mali-c55/mali-c55.cpp | 9 ---------\n> > 1 file changed, 9 deletions(-)\n> > \n> > diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> > index 910eac5e..9cd243a3 100644\n> > --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> > +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> > @@ -94,7 +94,6 @@ public:\n> > int init();\n> > \n> > /* Deflect these functionalities to either TPG or CameraSensor. */\n> > - const std::vector mbusCodes() const;\n> > const std::vector sizes(unsigned int mbusCode) const;\n> > const Size resolution() const;\n> > \n> > @@ -179,14 +178,6 @@ void MaliC55CameraData::initTPGData()\n> > tpgResolution_ = tpgSizes_.back();\n> > }\n> > \n> > -const std::vector MaliC55CameraData::mbusCodes() const\n> > -{\n> > - if (sensor_)\n> > - return sensor_->mbusCodes();\n> > -\n> > - return tpgCodes_;\n> > -}\n> > -\n> > const std::vector MaliC55CameraData::sizes(unsigned int mbusCode) const\n> > {\n> > if (sensor_)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99303BD87C\n\tfor ;\n\tMon, 17 Jun 2024 05:14:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3AEF665491;\n\tMon, 17 Jun 2024 07:14:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 397E86548A\n\tfor ;\n\tMon, 17 Jun 2024 07:14:02 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1AD399C1;\n\tMon, 17 Jun 2024 07:13:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Qpw8nRY6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718601225;\n\tbh=D8pbr8Lw/vcH+RRCUWxCOulsFjhjJ+pc9pGzpu9mSh8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Qpw8nRY65e9ESCEDmE4OAjyhOyfNBRnNFa+zb55z6mtHrkYklB0dIcZY/2MHrPRS5\n\t0/vPCSLZyvKY0zJpppOxzRVkkji7hePGawC+X60SXyzxxUaUZ63a3aN3ONAJH1E3SK\n\tG4sYWQMRvtudUOOCD/qGTeWXo3vJHk/u/BXgP6vA=","Date":"Mon, 17 Jun 2024 08:13:39 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 6/7] libcamera: mali-c55: Remove\n\tMaliC55CameraData::mbusCodes()","Message-ID":"<20240617051339.GH28126@pendragon.ideasonboard.com>","References":"<20240613155949.1041061-1-dan.scally@ideasonboard.com>\n\t<20240613155949.1041061-7-dan.scally@ideasonboard.com>\n\t<171830742327.2248009.3756815672411838672@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<171830742327.2248009.3756815672411838672@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]