[{"id":29935,"web_url":"https://patchwork.libcamera.org/comment/29935/","msgid":"<171830726085.2248009.5849162437470170364@ping.linuxembedded.co.uk>","date":"2024-06-13T19:34:20","subject":"Re: [PATCH 4/7] libcamera: mali-c55: Init camera properties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally (2024-06-13 16:59:46)\n> Initialise camera properties so that DNG files written by cam contain\n\nWell, I wouldn't call that the reason. I'd say it's to correctly\ninitiliase the camera properties from the camera sensor class!\n\nBut for the change, and with a clear commit message:\n\n\nReviewed-by: Kieran Bingham \n\n> model information for the LSC tuning scripts.\n> \n> Signed-off-by: Daniel Scally \n> ---\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index 2c34f3e9..2b1d766a 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -1099,8 +1099,7 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink)\n> if (data->init())\n> return false;\n> \n> - /* \\todo: Init properties. */\n> -\n> + data->properties_ = data->sensor_->properties();\n> data->updateControls();\n> \n> registerMaliCamera(std::move(data), sensor->name());\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5218ABD87C\n\tfor ;\n\tThu, 13 Jun 2024 19:34:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F200865490;\n\tThu, 13 Jun 2024 21:34:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC5EB6548D\n\tfor ;\n\tThu, 13 Jun 2024 21:34:23 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C6834CF;\n\tThu, 13 Jun 2024 21:34:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CN1dHSau\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718307249;\n\tbh=Jq7TC7Bog1rYlCGPnjsJzB3LiHKgnEQ1AVWNqmcgn+s=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=CN1dHSau9ZtZdpC7gRnyFwZEaIWaJ5Ou5qgN4Ho/Ew/M4a9S2lP5T94r4Y6MbYq1m\n\tlepDZR4WzIiWpEEUjbSotr3vkH3nIIHx1/FBq2RWx4CBYlLkisoBE6AIvqsL5EM46X\n\tdkBToVqPr6dWpJAYKZuut3Zjowy1hkcExCp5xILM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240613155949.1041061-5-dan.scally@ideasonboard.com>","References":"<20240613155949.1041061-1-dan.scally@ideasonboard.com>\n\t<20240613155949.1041061-5-dan.scally@ideasonboard.com>","Subject":"Re: [PATCH 4/7] libcamera: mali-c55: Init camera properties","From":"Kieran Bingham ","Cc":"Daniel Scally ","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 13 Jun 2024 20:34:20 +0100","Message-ID":"<171830726085.2248009.5849162437470170364@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]