{"id":20302,"url":"https://patchwork.libcamera.org/api/patches/20302/?format=json","web_url":"https://patchwork.libcamera.org/patch/20302/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240613155949.1041061-2-dan.scally@ideasonboard.com>","date":"2024-06-13T15:59:43","name":"[1/7] libcamera: mali-c55: Limit max size to sensor resolution","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"08c73ef573aa16ed70a8ce96a6a6fa16fc843486","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20302/mbox/","series":[{"id":4391,"url":"https://patchwork.libcamera.org/api/series/4391/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4391","date":"2024-06-13T15:59:42","name":"Miscellaneous Mali-C55 Pipeline Fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4391/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20302/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20302/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A57BC3237\n\tfor ;\n\tThu, 13 Jun 2024 16:00:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6EFE565499;\n\tThu, 13 Jun 2024 18:00:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 860AE6548B\n\tfor ;\n\tThu, 13 Jun 2024 17:59:58 +0200 (CEST)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 403894CF;\n\tThu, 13 Jun 2024 17:59:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"obGoIy7p\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718294384;\n\tbh=nx7OKJStOAyDOpeJKGvfrAHTiQjDqEJlfsZlkrwf2pc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=obGoIy7phXpHKa+x2emSGdZ4sBij75GJlu+QIzkzxrtr3HgoVBaqH5tgtRrixNs0F\n\tV9bqLAPullcYt5ZX9m386CtkHiINaDOiwnryNBS4jYqWe+/P/G7UUR55X2IUhdHB+J\n\tdhraO9PVVrV4t6NhDoXG6EfUlYylFBjVOQJMHVOw=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ","Subject":"[PATCH 1/7] libcamera: mali-c55: Limit max size to sensor resolution","Date":"Thu, 13 Jun 2024 16:59:43 +0100","Message-Id":"<20240613155949.1041061-2-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20240613155949.1041061-1-dan.scally@ideasonboard.com>","References":"<20240613155949.1041061-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Jacopo Mondi \n\nThe Mali C55 ISP cannot upscale. The maximum allowed output size\nis the sensor's resolution.\n\nFor RAW streams this is already handled in adjustRawSizes(), while\nfor processed streams the maximum allowed resolution was wrongly\nset to the ISP maximum output size (8192x8192).\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 45c71c1d..9442d17c 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -342,7 +342,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \t\trawConfig = &config;\n \t}\n \n-\tSize maxSize = kMaliC55MaxSize;\n+\tSize maxSize = std::min(kMaliC55MaxSize, data_->resolution());\n \tif (rawConfig) {\n \t\t/*\n \t\t * \\todo Take into account the Bayer components ordering once\n","prefixes":["1/7"]}