[{"id":29928,"web_url":"https://patchwork.libcamera.org/comment/29928/","msgid":"<20240613161057.GB6806@pendragon.ideasonboard.com>","date":"2024-06-13T16:10:57","subject":"Re: [PATCH] utils: libtuning: Correct GBRG Image parsing","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Thu, Jun 13, 2024 at 04:09:50PM +0100, Daniel Scally wrote:\n> The Image class incorrectly parses data in GBRG bayer formats as the\n> indices to the channels are set incorrectly - fix it.\n> \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> utils/tuning/libtuning/image.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/tuning/libtuning/image.py b/utils/tuning/libtuning/image.py\n> index e2181b11..6ff60ec1 100644\n> --- a/utils/tuning/libtuning/image.py\n> +++ b/utils/tuning/libtuning/image.py\n> @@ -79,7 +79,7 @@ class Image:\n> # is R, then G, then G, then B.\n> bayer_case = {\n> '0 1 1 2': (lt.Color.R, lt.Color.GR, lt.Color.GB, lt.Color.B),\n> - '1 2 0 1': (lt.Color.GB, lt.Color.R, lt.Color.B, lt.Color.GR),\n> + '1 2 0 1': (lt.Color.GB, lt.Color.B, lt.Color.R, lt.Color.GR),\n> '2 1 1 0': (lt.Color.B, lt.Color.GB, lt.Color.GR, lt.Color.R),\n> '1 0 2 1': (lt.Color.GR, lt.Color.R, lt.Color.B, lt.Color.GB)\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E451DC3237\n\tfor ;\n\tThu, 13 Jun 2024 16:11:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 326EF65494;\n\tThu, 13 Jun 2024 18:11:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CA2C6548D\n\tfor ;\n\tThu, 13 Jun 2024 18:11:18 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC8A1743;\n\tThu, 13 Jun 2024 18:11:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GAX2Uant\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718295064;\n\tbh=Tx3EdKcxH4GJufjs6rYnWcfd1pc9boGl4isXNNS9020=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GAX2UantGjGg/pAB7i3dLgfWVdqoCrEpGgkoaXF9ZwEBad+UkaSHZIk7+Sm6T/dY5\n\tpSVTcBa30VJE+Xt6jFDFDi/b0wN4yvVxS0guFDa0ESj/mY485GavWVjq6nH3S4A51d\n\t+Zwekjfw3HYuPDPWHmz2pDTqZlid5IjSZdT4phQU=","Date":"Thu, 13 Jun 2024 19:10:57 +0300","From":"Laurent Pinchart ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] utils: libtuning: Correct GBRG Image parsing","Message-ID":"<20240613161057.GB6806@pendragon.ideasonboard.com>","References":"<20240613150950.1035299-1-dan.scally@ideasonboard.com>\n\t<20240613150950.1035299-2-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240613150950.1035299-2-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29930,"web_url":"https://patchwork.libcamera.org/comment/29930/","msgid":"","date":"2024-06-13T16:15:59","subject":"Re: [PATCH] utils: libtuning: Correct GBRG Image parsing","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Daniel,\n\nThank you for the patch.\n\nOn Thu, Jun 13, 2024 at 04:09:50PM +0100, Daniel Scally wrote:\n> The Image class incorrectly parses data in GBRG bayer formats as the\n> indices to the channels are set incorrectly - fix it.\n> \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> ---\n> utils/tuning/libtuning/image.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/tuning/libtuning/image.py b/utils/tuning/libtuning/image.py\n> index e2181b11..6ff60ec1 100644\n> --- a/utils/tuning/libtuning/image.py\n> +++ b/utils/tuning/libtuning/image.py\n> @@ -79,7 +79,7 @@ class Image:\n> # is R, then G, then G, then B.\n> bayer_case = {\n> '0 1 1 2': (lt.Color.R, lt.Color.GR, lt.Color.GB, lt.Color.B),\n> - '1 2 0 1': (lt.Color.GB, lt.Color.R, lt.Color.B, lt.Color.GR),\n> + '1 2 0 1': (lt.Color.GB, lt.Color.B, lt.Color.R, lt.Color.GR),\n> '2 1 1 0': (lt.Color.B, lt.Color.GB, lt.Color.GR, lt.Color.R),\n> '1 0 2 1': (lt.Color.GR, lt.Color.R, lt.Color.B, lt.Color.GB)\n> }\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55C93BD87C\n\tfor ;\n\tThu, 13 Jun 2024 16:16:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D605D65491;\n\tThu, 13 Jun 2024 18:16:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B18D6548B\n\tfor ;\n\tThu, 13 Jun 2024 18:16:03 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3fed:9d83:54f9:6b93])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C077675;\n\tThu, 13 Jun 2024 18:15:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IhMY75Ce\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718295349;\n\tbh=Mz2rAiGw9q0b5xICg9+kc3Iud62BPc2dfXfma+I8Pq0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IhMY75Cep5yWYCCdUSMTemhpdQ2mZQ1SVyXyWOZNVfcqHvmooZTBIplqsofumxIxC\n\tuERcaJWt3dM6uXpUl2i0xl6PHDmrpRoJVyQwdngEB9y32csfRahSEub+i+M3uCt/FE\n\tphzqVGfIh+yZ4qPAJsZeZg3mnMqnuzHwmOWUHBxs=","Date":"Thu, 13 Jun 2024 18:15:59 +0200","From":"Stefan Klug ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] utils: libtuning: Correct GBRG Image parsing","Message-ID":"","References":"<20240613150950.1035299-1-dan.scally@ideasonboard.com>\n\t<20240613150950.1035299-2-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240613150950.1035299-2-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]