[{"id":29970,"web_url":"https://patchwork.libcamera.org/comment/29970/","msgid":"<20240617052037.GK28126@pendragon.ideasonboard.com>","date":"2024-06-17T05:20:37","subject":"Re: [PATCH 02/10] include: linux: Add Mali-C55 Stats and Params V4L2\n\tformat","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Thu, Jun 13, 2024 at 02:25:54PM +0100, Daniel Scally wrote:\n> Add the new format describing the Mali C55's Statistics and Parameters\n> to videodev2.\n\nYou can add that this is a temporary manual addition until the change\ntrickles down from mainline once the C55 driver gets merged.\n\n> Acked-by: Nayden Kanchev \n> Co-developed-by: Jacopo Mondi \n> Signed-off-by: Jacopo Mondi \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/linux/videodev2.h | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\n> index 7fe522e8..fbb8fbcd 100644\n> --- a/include/linux/videodev2.h\n> +++ b/include/linux/videodev2.h\n> @@ -839,6 +839,9 @@ struct v4l2_pix_format {\n> /* The metadata format identifier for FE stats buffers. */\n> #define V4L2_META_FMT_RPI_FE_STATS v4l2_fourcc('R', 'P', 'F', 'S')\n> \n> +#define V4L2_META_FMT_MALI_C55_PARAMS\tv4l2_fourcc('C', '5', '5', 'P') /* ARM Mali-C55 Parameters */\n> +#define V4L2_META_FMT_MALI_C55_3A_STATS v4l2_fourcc('C', '5', '5', 'S') /* ARM Mali-C55 3A Statistics */\n> +\n> /* priv field value to indicates that subsequent fields are valid. */\n> #define V4L2_PIX_FMT_PRIV_MAGIC\t\t0xfeedcafe\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F410FBD87C\n\tfor ;\n\tMon, 17 Jun 2024 05:20:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C4C76548D;\n\tMon, 17 Jun 2024 07:20:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F316A6548A\n\tfor ;\n\tMon, 17 Jun 2024 07:20:57 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3BE2539F;\n\tMon, 17 Jun 2024 07:20:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q9uEuRBA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718601641;\n\tbh=hFIRo0XbFyATsdQQZp2g2Cg/MX+VAw9+fW8q6crX9AE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Q9uEuRBAT9izHC31wnqypWfWQMTf4axBBoUX6oXhOfjgaeQpJ6RpkmRr3Z0wcOAzT\n\tY/z8IvFyB4vJJqZ/leiECCvLrE4GmDQcNCgMvafvO8upb77lfT8Hxl6r46YPMSGr9e\n\td1rWtvTXGOCgI9NH8q5vgDiB+01ZK0qBlfJFZwLo=","Date":"Mon, 17 Jun 2024 08:20:37 +0300","From":"Laurent Pinchart ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org, nayden.kanchev@arm.com,\n\tjacopo.mondi@ideasonboard.com","Subject":"Re: [PATCH 02/10] include: linux: Add Mali-C55 Stats and Params V4L2\n\tformat","Message-ID":"<20240617052037.GK28126@pendragon.ideasonboard.com>","References":"<20240613132602.1021721-1-dan.scally@ideasonboard.com>\n\t<20240613132602.1021721-3-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240613132602.1021721-3-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]