[{"id":2711,"web_url":"https://patchwork.libcamera.org/comment/2711/","msgid":"<20190928105533.fs4bt46uchb7f6qn@uno.localdomain>","date":"2019-09-28T10:55:33","subject":"Re: [libcamera-devel] [PATCH v3 05/13] libcamera: request: Add\n\tIPAMetaData","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Fri, Sep 27, 2019 at 04:44:09AM +0200, Niklas Söderlund wrote:\n> Add a new structure to hold meta data coming out of the IPA. The\n> structure will grow over time but for now only add information about the\n> auto exposure state as it can be directly used by the rkisp1 IPA, which\n> is capable of controlling exposure.\n>\n\nAs commented on the IPA interface, why a C struct ? won't we have the\nsame issue we would have for Controls? Do you think this could be\nreplaced by a ControlList ?\n\nThanks\n j\n\n> Signed-off-by: Niklas Söderlund \n> ---\n> include/libcamera/request.h | 12 +++++++++++\n> src/libcamera/request.cpp | 42 ++++++++++++++++++++++++++++++++++++-\n> 2 files changed, 53 insertions(+), 1 deletion(-)\n>\n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 5eb012e41b4a377b..38a6f008d53dc53a 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -21,6 +21,16 @@ class Buffer;\n> class Camera;\n> class Stream;\n>\n> +enum AeState {\n> +\tInactive,\n> +\tSearching,\n> +\tConverged,\n> +};\n> +\n> +struct IPAMetaData {\n> +\tAeState aeState;\n> +\tbool ready;\n> +};\n>\n> class Request\n> {\n> @@ -41,6 +51,7 @@ public:\n> \tconst std::map &buffers() const { return bufferMap_; }\n> \tint addBuffer(std::unique_ptr buffer);\n> \tBuffer *findBuffer(Stream *stream) const;\n> +\tconst IPAMetaData &metaData() const { return metaData_; };\n>\n> \tuint64_t cookie() const { return cookie_; }\n> \tStatus status() const { return status_; }\n> @@ -60,6 +71,7 @@ private:\n> \tControlList controls_;\n> \tstd::map bufferMap_;\n> \tstd::unordered_set pending_;\n> +\tIPAMetaData metaData_;\n>\n> \tconst uint64_t cookie_;\n> \tStatus status_;\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index ebae99b07c696512..226a10b6a3c048c5 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -24,6 +24,40 @@ namespace libcamera {\n>\n> LOG_DEFINE_CATEGORY(Request)\n>\n> +/**\n> + * \\enum AeState\n> + * State of Auto Exposure algorithm\n> + * \\var AeState::Inactive\n> + * AE not running\n> + * \\var AeState::Searching\n> + * AE is not converged to a good value and is adjusting exposure parameters.\n> + * \\var AeState::Converged\n> + * AE has found good exposure values for the current scene.\n> + */\n> +\n> +/**\n> + * \\struct IPAMetaData\n> + * \\brief Meta data describing the state of the IPA\n> + *\n> + * Container for IPA meta data. The intended creator of this object is an IPA\n> + * and the intended consumer is applications. Applications access the object\n> + * thru the Request object that corresponds to the specific capture event\n> + * that generated the meta data.\n> + */\n> +\n> +/**\n> + * \\var IPAMetaData::aeState\n> + * \\brief Holds the state of the Auto Exposure algorithm\n> + */\n> +\n> +/**\n> + * \\var IPAMetaData::ready\n> + * \\brief Flag to indicate the pipeline have validated the meta data\n> + *\n> + * The meta data should not be returned to the application by the specific\n> + * pipeline handler implementation before this flag is set to true.\n> + */\n> +\n> /**\n> * \\enum Request::Status\n> * Request completion status\n> @@ -55,7 +89,7 @@ LOG_DEFINE_CATEGORY(Request)\n> *\n> */\n> Request::Request(Camera *camera, uint64_t cookie)\n> -\t: camera_(camera), controls_(camera), cookie_(cookie),\n> +\t: camera_(camera), controls_(camera), metaData_({}), cookie_(cookie),\n> \t status_(RequestPending), cancelled_(false)\n> {\n> }\n> @@ -157,6 +191,12 @@ Buffer *Request::findBuffer(Stream *stream) const\n> \treturn it->second;\n> }\n>\n> +/**\n> + * \\fn Request::metaData()\n> + * \\brief Retrieve the request's meta data\n> + * \\return The meta data associated with the request\n> + */\n> +\n> /**\n> * \\fn Request::cookie()\n> * \\brief Retrieve the cookie set when the request was created\n> --\n> 2.23.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A7D460BBA\n\tfor ;\n\tSat, 28 Sep 2019 12:53:52 +0200 (CEST)","from uno.localdomain\n\t(host71-63-dynamic.19-79-r.retail.telecomitalia.it [79.19.63.71])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id AC8B8100005;\n\tSat, 28 Sep 2019 10:53:51 +0000 (UTC)"],"Date":"Sat, 28 Sep 2019 12:55:33 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190928105533.fs4bt46uchb7f6qn@uno.localdomain>","References":"<20190927024417.725906-1-niklas.soderlund@ragnatech.se>\n\t<20190927024417.725906-6-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"ye3r55zxakbwop4v\"","Content-Disposition":"inline","In-Reply-To":"<20190927024417.725906-6-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v3 05/13] libcamera: request: Add\n\tIPAMetaData","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 28 Sep 2019 10:53:52 -0000"}},{"id":2716,"web_url":"https://patchwork.libcamera.org/comment/2716/","msgid":"<20190928192108.GD4865@pendragon.ideasonboard.com>","date":"2019-09-28T19:21:08","subject":"Re: [libcamera-devel] [PATCH v3 05/13] libcamera: request: Add\n\tIPAMetaData","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Sat, Sep 28, 2019 at 12:55:33PM +0200, Jacopo Mondi wrote:\n> On Fri, Sep 27, 2019 at 04:44:09AM +0200, Niklas Söderlund wrote:\n> > Add a new structure to hold meta data coming out of the IPA. The\n> > structure will grow over time but for now only add information about the\n> > auto exposure state as it can be directly used by the rkisp1 IPA, which\n> > is capable of controlling exposure.\n> \n> As commented on the IPA interface, why a C struct ? won't we have the\n> same issue we would have for Controls? Do you think this could be\n> replaced by a ControlList ?\n\nThat's what I was going to mention too, it should be a ControlList.\n\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > include/libcamera/request.h | 12 +++++++++++\n> > src/libcamera/request.cpp | 42 ++++++++++++++++++++++++++++++++++++-\n> > 2 files changed, 53 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> > index 5eb012e41b4a377b..38a6f008d53dc53a 100644\n> > --- a/include/libcamera/request.h\n> > +++ b/include/libcamera/request.h\n> > @@ -21,6 +21,16 @@ class Buffer;\n> > class Camera;\n> > class Stream;\n> >\n> > +enum AeState {\n> > +\tInactive,\n> > +\tSearching,\n> > +\tConverged,\n> > +};\n> > +\n> > +struct IPAMetaData {\n> > +\tAeState aeState;\n> > +\tbool ready;\n> > +};\n> >\n> > class Request\n> > {\n> > @@ -41,6 +51,7 @@ public:\n> > \tconst std::map &buffers() const { return bufferMap_; }\n> > \tint addBuffer(std::unique_ptr buffer);\n> > \tBuffer *findBuffer(Stream *stream) const;\n> > +\tconst IPAMetaData &metaData() const { return metaData_; };\n> >\n> > \tuint64_t cookie() const { return cookie_; }\n> > \tStatus status() const { return status_; }\n> > @@ -60,6 +71,7 @@ private:\n> > \tControlList controls_;\n> > \tstd::map bufferMap_;\n> > \tstd::unordered_set pending_;\n> > +\tIPAMetaData metaData_;\n> >\n> > \tconst uint64_t cookie_;\n> > \tStatus status_;\n> > diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> > index ebae99b07c696512..226a10b6a3c048c5 100644\n> > --- a/src/libcamera/request.cpp\n> > +++ b/src/libcamera/request.cpp\n> > @@ -24,6 +24,40 @@ namespace libcamera {\n> >\n> > LOG_DEFINE_CATEGORY(Request)\n> >\n> > +/**\n> > + * \\enum AeState\n> > + * State of Auto Exposure algorithm\n> > + * \\var AeState::Inactive\n> > + * AE not running\n> > + * \\var AeState::Searching\n> > + * AE is not converged to a good value and is adjusting exposure parameters.\n> > + * \\var AeState::Converged\n> > + * AE has found good exposure values for the current scene.\n> > + */\n> > +\n> > +/**\n> > + * \\struct IPAMetaData\n> > + * \\brief Meta data describing the state of the IPA\n> > + *\n> > + * Container for IPA meta data. The intended creator of this object is an IPA\n> > + * and the intended consumer is applications. Applications access the object\n> > + * thru the Request object that corresponds to the specific capture event\n> > + * that generated the meta data.\n> > + */\n> > +\n> > +/**\n> > + * \\var IPAMetaData::aeState\n> > + * \\brief Holds the state of the Auto Exposure algorithm\n> > + */\n> > +\n> > +/**\n> > + * \\var IPAMetaData::ready\n> > + * \\brief Flag to indicate the pipeline have validated the meta data\n> > + *\n> > + * The meta data should not be returned to the application by the specific\n> > + * pipeline handler implementation before this flag is set to true.\n> > + */\n> > +\n> > /**\n> > * \\enum Request::Status\n> > * Request completion status\n> > @@ -55,7 +89,7 @@ LOG_DEFINE_CATEGORY(Request)\n> > *\n> > */\n> > Request::Request(Camera *camera, uint64_t cookie)\n> > -\t: camera_(camera), controls_(camera), cookie_(cookie),\n> > +\t: camera_(camera), controls_(camera), metaData_({}), cookie_(cookie),\n> > \t status_(RequestPending), cancelled_(false)\n> > {\n> > }\n> > @@ -157,6 +191,12 @@ Buffer *Request::findBuffer(Stream *stream) const\n> > \treturn it->second;\n> > }\n> >\n> > +/**\n> > + * \\fn Request::metaData()\n> > + * \\brief Retrieve the request's meta data\n> > + * \\return The meta data associated with the request\n> > + */\n> > +\n> > /**\n> > * \\fn Request::cookie()\n> > * \\brief Retrieve the cookie set when the request was created","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D23AC60BBA\n\tfor ;\n\tSat, 28 Sep 2019 21:21:20 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 327DC53B;\n\tSat, 28 Sep 2019 21:21:20 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1569698480;\n\tbh=jJX/EsQppImSa03jlbvOv3/vrQnejMUI9ERmQ5pEL+o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=E8sVx4OaBaRTI7iW5+2m50wbxjL7nmC2FKPdlo/2z5ObTSNiHa7mFSNHBOn1pG/13\n\tshkl8cyvE6O8tsHxlchrzn60UY0yMHGXCFuANRGinYNkYseOREeNg3rlBsjd/H3OAn\n\tBacO5akp6a8KZCZCofhe0r3EoQjN4VVOH6BWNTAc=","Date":"Sat, 28 Sep 2019 22:21:08 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"Niklas =?utf-8?q?S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20190928192108.GD4865@pendragon.ideasonboard.com>","References":"<20190927024417.725906-1-niklas.soderlund@ragnatech.se>\n\t<20190927024417.725906-6-niklas.soderlund@ragnatech.se>\n\t<20190928105533.fs4bt46uchb7f6qn@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190928105533.fs4bt46uchb7f6qn@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 05/13] libcamera: request: Add\n\tIPAMetaData","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 28 Sep 2019 19:21:21 -0000"}}]