[{"id":29901,"web_url":"https://patchwork.libcamera.org/comment/29901/","msgid":"<171826887410.1669873.745965538015256698@ping.linuxembedded.co.uk>","date":"2024-06-13T08:54:34","subject":"Re: [PATCH 3/3] ipa: rkisp1: cproc: Drop incorrect [[maybe_unused]]","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2024-06-13 09:33:20)\n> A few function parameters are marked with [[maybe_unused]] but are\n> actually used. Drop the attribute.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/rkisp1/algorithms/cproc.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp\n> index 9f400a52dd96..ef0931b20453 100644\n> --- a/src/ipa/rkisp1/algorithms/cproc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/cproc.cpp\n> @@ -54,7 +54,7 @@ int convertContrastOrSaturation(const float v)\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::init\n> */\n> -int ColorProcessing::init([[maybe_unused]] IPAContext &context,\n> +int ColorProcessing::init(IPAContext &context,\n> [[maybe_unused]] const YamlObject &tuningData)\n> {\n> auto &cmap = context.ctrlMap;\n> @@ -69,7 +69,7 @@ int ColorProcessing::init([[maybe_unused]] IPAContext &context,\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::configure\n> */\n> -int ColorProcessing::configure([[maybe_unused]] IPAContext &context,\n> +int ColorProcessing::configure(IPAContext &context,\n> [[maybe_unused]] const IPACameraSensorInfo &configInfo)\n> {\n> auto &cproc = context.activeState.cproc;\n> @@ -85,7 +85,7 @@ int ColorProcessing::configure([[maybe_unused]] IPAContext &context,\n> * \\copydoc libcamera::ipa::Algorithm::queueRequest\n> */\n> void ColorProcessing::queueRequest(IPAContext &context,\n> - [[maybe_unused]] const uint32_t frame,\n> + const uint32_t frame,\n> IPAFrameContext &frameContext,\n> const ControlList &controls)\n> {\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B6D9BD87C\n\tfor ;\n\tThu, 13 Jun 2024 08:54:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE82765494;\n\tThu, 13 Jun 2024 10:54:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE39C6548D\n\tfor ;\n\tThu, 13 Jun 2024 10:54:36 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F059BBEB;\n\tThu, 13 Jun 2024 10:54:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KuLlYkSS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718268863;\n\tbh=SwBZy9gKTa21T6PPEuAzBwZKdbVtNYm96bqACr0zcKw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=KuLlYkSSbxv1EKyYunCgGxCBU6lMxoNHfxERlS7/vIr96PRWluupwDRj8j7/+qoj2\n\tLHB/EUyIiatfwuf/c2lnd5Kq5trSj+mYV2DBxmKAHIrVCjP5jQdJG52VHMDjD3hsEX\n\te9G4lBrLVyYBl5NriulpGOuNx9tU3wyYA3BtFqHs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240613083533.855791-4-stefan.klug@ideasonboard.com>","References":"<20240613083533.855791-1-stefan.klug@ideasonboard.com>\n\t<20240613083533.855791-4-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH 3/3] ipa: rkisp1: cproc: Drop incorrect [[maybe_unused]]","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 13 Jun 2024 09:54:34 +0100","Message-ID":"<171826887410.1669873.745965538015256698@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29908,"web_url":"https://patchwork.libcamera.org/comment/29908/","msgid":"<20240613110028.GD6019@pendragon.ideasonboard.com>","date":"2024-06-13T11:00:28","subject":"Re: [PATCH 3/3] ipa: rkisp1: cproc: Drop incorrect [[maybe_unused]]","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Thu, Jun 13, 2024 at 10:33:20AM +0200, Stefan Klug wrote:\n> A few function parameters are marked with [[maybe_unused]] but are\n> actually used. Drop the attribute.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/rkisp1/algorithms/cproc.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp\n> index 9f400a52dd96..ef0931b20453 100644\n> --- a/src/ipa/rkisp1/algorithms/cproc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/cproc.cpp\n> @@ -54,7 +54,7 @@ int convertContrastOrSaturation(const float v)\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::init\n> */\n> -int ColorProcessing::init([[maybe_unused]] IPAContext &context,\n> +int ColorProcessing::init(IPAContext &context,\n> \t\t\t [[maybe_unused]] const YamlObject &tuningData)\n> {\n> \tauto &cmap = context.ctrlMap;\n> @@ -69,7 +69,7 @@ int ColorProcessing::init([[maybe_unused]] IPAContext &context,\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::configure\n> */\n> -int ColorProcessing::configure([[maybe_unused]] IPAContext &context,\n> +int ColorProcessing::configure(IPAContext &context,\n> \t\t\t [[maybe_unused]] const IPACameraSensorInfo &configInfo)\n> {\n> \tauto &cproc = context.activeState.cproc;\n> @@ -85,7 +85,7 @@ int ColorProcessing::configure([[maybe_unused]] IPAContext &context,\n> * \\copydoc libcamera::ipa::Algorithm::queueRequest\n> */\n> void ColorProcessing::queueRequest(IPAContext &context,\n> -\t\t\t\t [[maybe_unused]] const uint32_t frame,\n> +\t\t\t\t const uint32_t frame,\n> \t\t\t\t IPAFrameContext &frameContext,\n> \t\t\t\t const ControlList &controls)\n> {\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 690A8C3237\n\tfor ;\n\tThu, 13 Jun 2024 11:00:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 169A565492;\n\tThu, 13 Jun 2024 13:00:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 139E16548B\n\tfor ;\n\tThu, 13 Jun 2024 13:00:49 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0A0D24CC;\n\tThu, 13 Jun 2024 13:00:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"R+AVIO/J\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718276435;\n\tbh=5bwqY+WSHilSPmcTMV3+vhMI2Zd35nJF4VW80VtuiGk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=R+AVIO/JfrcjfR40RYVXLtUgIvJlbw2JpVD7Bk2uMn2a0rtYmY/kCexSi3OO4JO7m\n\tl4QuX/3CtMpOF0GE/GcrY9am+KNO6ufFwyy5yde37B+45WB9rJOb6FsVGdj5sM58nb\n\t55NWoHNwkYuAkC+hW62uC0ezSWXflXr6e06CBD/E=","Date":"Thu, 13 Jun 2024 14:00:28 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 3/3] ipa: rkisp1: cproc: Drop incorrect [[maybe_unused]]","Message-ID":"<20240613110028.GD6019@pendragon.ideasonboard.com>","References":"<20240613083533.855791-1-stefan.klug@ideasonboard.com>\n\t<20240613083533.855791-4-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240613083533.855791-4-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]