{"id":20287,"url":"https://patchwork.libcamera.org/api/patches/20287/?format=json","web_url":"https://patchwork.libcamera.org/patch/20287/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240613083533.855791-4-stefan.klug@ideasonboard.com>","date":"2024-06-13T08:33:20","name":"[3/3] ipa: rkisp1: cproc: Drop incorrect [[maybe_unused]]","commit_ref":"1b917256188b6b6f8faa5e8e3420032f5c76e233","pull_url":null,"state":"accepted","archived":false,"hash":"2ae26b1eed9be8c7a7b841eeadcfa2db9b16850b","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20287/mbox/","series":[{"id":4387,"url":"https://patchwork.libcamera.org/api/series/4387/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4387","date":"2024-06-13T08:33:17","name":"ipa: rkisp1: cproc: Small fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4387/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20287/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20287/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 85AFDC3237\n\tfor ;\n\tThu, 13 Jun 2024 08:36:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4399365491;\n\tThu, 13 Jun 2024 10:36:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 193D365491\n\tfor ;\n\tThu, 13 Jun 2024 10:36:45 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3fed:9d83:54f9:6b93])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 35F89BEB;\n\tThu, 13 Jun 2024 10:36:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"s4lyZhYq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718267791;\n\tbh=FmJxQYeUR4Bl8VI/NfYDxrq007y1nTNet68JV+aXpDk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=s4lyZhYqMeDcgZu/gW5Sezcjr8siHXuGmcflcc2NsXD0hCCDlVp1zA/tmX/qCHQM6\n\tiu94HshqLtb5BCrHagCm5Ac9+A/Vzo5/sjLfFczpt7CNM74XL91y1jiRsa+96B2ZVC\n\tI+m2lL3hHEJAT8u8OWaheYBjZSQA4g9N/sReFlt0=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 3/3] ipa: rkisp1: cproc: Drop incorrect [[maybe_unused]]","Date":"Thu, 13 Jun 2024 10:33:20 +0200","Message-ID":"<20240613083533.855791-4-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240613083533.855791-1-stefan.klug@ideasonboard.com>","References":"<20240613083533.855791-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A few function parameters are marked with [[maybe_unused]] but are\nactually used. Drop the attribute.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/rkisp1/algorithms/cproc.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp\nindex 9f400a52dd96..ef0931b20453 100644\n--- a/src/ipa/rkisp1/algorithms/cproc.cpp\n+++ b/src/ipa/rkisp1/algorithms/cproc.cpp\n@@ -54,7 +54,7 @@ int convertContrastOrSaturation(const float v)\n /**\n * \\copydoc libcamera::ipa::Algorithm::init\n */\n-int ColorProcessing::init([[maybe_unused]] IPAContext &context,\n+int ColorProcessing::init(IPAContext &context,\n \t\t\t [[maybe_unused]] const YamlObject &tuningData)\n {\n \tauto &cmap = context.ctrlMap;\n@@ -69,7 +69,7 @@ int ColorProcessing::init([[maybe_unused]] IPAContext &context,\n /**\n * \\copydoc libcamera::ipa::Algorithm::configure\n */\n-int ColorProcessing::configure([[maybe_unused]] IPAContext &context,\n+int ColorProcessing::configure(IPAContext &context,\n \t\t\t [[maybe_unused]] const IPACameraSensorInfo &configInfo)\n {\n \tauto &cproc = context.activeState.cproc;\n@@ -85,7 +85,7 @@ int ColorProcessing::configure([[maybe_unused]] IPAContext &context,\n * \\copydoc libcamera::ipa::Algorithm::queueRequest\n */\n void ColorProcessing::queueRequest(IPAContext &context,\n-\t\t\t\t [[maybe_unused]] const uint32_t frame,\n+\t\t\t\t const uint32_t frame,\n \t\t\t\t IPAFrameContext &frameContext,\n \t\t\t\t const ControlList &controls)\n {\n","prefixes":["3/3"]}