[{"id":29899,"web_url":"https://patchwork.libcamera.org/comment/29899/","msgid":"<171826879883.1669873.2212384959217698274@ping.linuxembedded.co.uk>","date":"2024-06-13T08:53:18","subject":"Re: [PATCH 1/3] ipa: rkisp1: cproc: Use anonymous namespace to limit\n\tsymbol visibility","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2024-06-13 09:33:18)\n> Use a anonymous namespace instead of the static keyword to limity symbol\n> visibility.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/rkisp1/algorithms/cproc.cpp | 10 +++++++---\n> 1 file changed, 7 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp\n> index 18c7b719d3c7..955298093fda 100644\n> --- a/src/ipa/rkisp1/algorithms/cproc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/cproc.cpp\n> @@ -33,25 +33,29 @@ namespace ipa::rkisp1::algorithms {\n> \n> LOG_DEFINE_CATEGORY(RkISP1CProc)\n> \n> +namespace {\n> +\n> constexpr float kDefaultBrightness = 0.0f;\n> constexpr float kDefaultContrast = 1.0f;\n> constexpr float kDefaultSaturation = 1.0f;\n> \n> -static int convertBrightness(const float v)\n> +int convertBrightness(const float v)\n> {\n> return std::clamp(std::lround(v * 128), -128, 127);\n> }\n> \n> -static int convertContrast(const float v)\n> +int convertContrast(const float v)\n> {\n> return std::clamp(std::lround(v * 128), 0, 255);\n> }\n> \n> -static int convertSaturation(const float v)\n> +int convertSaturation(const float v)\n> {\n> return std::clamp(std::lround(v * 128), 0, 255);\n> }\n> \n> +} /* namespace */\n> +\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::init\n> */\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3463C3237\n\tfor ;\n\tThu, 13 Jun 2024 08:53:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 19FB76548D;\n\tThu, 13 Jun 2024 10:53:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82D606548C\n\tfor ;\n\tThu, 13 Jun 2024 10:53:21 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7094ABEB;\n\tThu, 13 Jun 2024 10:53:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rRhROt26\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718268787;\n\tbh=vpXHbr1GuUePfKjslT6C+mXWwGXQr1KG/Ds3g1sijCA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=rRhROt26+RYgFy6Sfxr0vc0OQ1Z1Z7ZFZVoqZATIb0SRU9Slm0Fu76ixTN5a/b65w\n\tsCn50xE3owXo5ETIL0zgTCjEFvBOyKggB6RyckHglcEddDSnkW13FQxHZNEvBF9xd/\n\tUurkU/km2F/BJ8mMlzvhWnlNwktKWU3qyhtB2MZw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240613083533.855791-2-stefan.klug@ideasonboard.com>","References":"<20240613083533.855791-1-stefan.klug@ideasonboard.com>\n\t<20240613083533.855791-2-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH 1/3] ipa: rkisp1: cproc: Use anonymous namespace to limit\n\tsymbol visibility","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 13 Jun 2024 09:53:18 +0100","Message-ID":"<171826879883.1669873.2212384959217698274@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29906,"web_url":"https://patchwork.libcamera.org/comment/29906/","msgid":"<20240613105943.GB6019@pendragon.ideasonboard.com>","date":"2024-06-13T10:59:43","subject":"Re: [PATCH 1/3] ipa: rkisp1: cproc: Use anonymous namespace to limit\n\tsymbol visibility","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Thu, Jun 13, 2024 at 10:33:18AM +0200, Stefan Klug wrote:\n> Use a anonymous namespace instead of the static keyword to limity symbol\n> visibility.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/rkisp1/algorithms/cproc.cpp | 10 +++++++---\n> 1 file changed, 7 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp\n> index 18c7b719d3c7..955298093fda 100644\n> --- a/src/ipa/rkisp1/algorithms/cproc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/cproc.cpp\n> @@ -33,25 +33,29 @@ namespace ipa::rkisp1::algorithms {\n> \n> LOG_DEFINE_CATEGORY(RkISP1CProc)\n> \n> +namespace {\n> +\n> constexpr float kDefaultBrightness = 0.0f;\n> constexpr float kDefaultContrast = 1.0f;\n> constexpr float kDefaultSaturation = 1.0f;\n> \n> -static int convertBrightness(const float v)\n> +int convertBrightness(const float v)\n> {\n> \treturn std::clamp(std::lround(v * 128), -128, 127);\n> }\n> \n> -static int convertContrast(const float v)\n> +int convertContrast(const float v)\n> {\n> \treturn std::clamp(std::lround(v * 128), 0, 255);\n> }\n> \n> -static int convertSaturation(const float v)\n> +int convertSaturation(const float v)\n> {\n> \treturn std::clamp(std::lround(v * 128), 0, 255);\n> }\n> \n> +} /* namespace */\n> +\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::init\n> */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4731DC3237\n\tfor ;\n\tThu, 13 Jun 2024 11:00:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EBFDA6548E;\n\tThu, 13 Jun 2024 13:00:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D567D634D3\n\tfor ;\n\tThu, 13 Jun 2024 13:00:04 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AB0AE4CC;\n\tThu, 13 Jun 2024 12:59:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Cut4vO9E\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718276390;\n\tbh=jORN5QmuUqxmBetam5mCAfM3GhweRxfN8EuoLKJHzj0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Cut4vO9EkvxVUGuZQ5WlJxGaxes6wqxZzaOBs/7rfOUUUde5WP0g6RFW/Z7DY7fff\n\tlussP81ISkLYWtiMWS8zb8Qpy6bbJta6ekoVD6BOd1msAcKuzEMU0eC136RzKqmAGE\n\tBYUuhtoqUJF9cjljh61OeygoGmNGM3Sb2aLB+Nk8=","Date":"Thu, 13 Jun 2024 13:59:43 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/3] ipa: rkisp1: cproc: Use anonymous namespace to limit\n\tsymbol visibility","Message-ID":"<20240613105943.GB6019@pendragon.ideasonboard.com>","References":"<20240613083533.855791-1-stefan.klug@ideasonboard.com>\n\t<20240613083533.855791-2-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240613083533.855791-2-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]