[{"id":29890,"web_url":"https://patchwork.libcamera.org/comment/29890/","msgid":"<ZmqoLlKcUYGGeciA@pyrite.rasen.tech>","date":"2024-06-13T08:05:02","subject":"Re: [PATCH 09/11] ipa: libipa: pwl: Specialize YamlObject getter","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Jun 13, 2024 at 04:39:42AM +0300, Laurent Pinchart wrote:\n> Implement a specialization of the YamlObject::Getter structure to\n> support deserializing ipa::Pwl objects from YAML data.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n> ---\n>  src/ipa/libipa/pwl.cpp | 35 +++++++++++++++++++++++++++++++++++\n>  1 file changed, 35 insertions(+)\n> \n> diff --git a/src/ipa/libipa/pwl.cpp b/src/ipa/libipa/pwl.cpp\n> index cf864fbb3889..3c639645fa3d 100644\n> --- a/src/ipa/libipa/pwl.cpp\n> +++ b/src/ipa/libipa/pwl.cpp\n> @@ -459,4 +459,39 @@ std::string Pwl::toString() const\n>  \n>  } /* namespace ipa */\n>  \n> +#ifndef __DOXYGEN__\n> +/*\n> + * The YAML data shall be a list of numerical values with an even number of\n> + * elements. They are parsed in pairs into x and y points in the piecewise\n> + * linear function, and added in order. x must be monotonically increasing.\n> + */\n> +template<>\n> +std::optional<ipa::Pwl>\n> +YamlObject::Getter<ipa::Pwl>::get(const YamlObject &obj) const\n> +{\n> +\tif (!obj.size() || obj.size() % 2)\n> +\t\treturn std::nullopt;\n> +\n> +\tipa::Pwl pwl;\n> +\n> +\tconst auto &list = obj.asList();\n> +\n> +\tfor (auto it = list.begin(); it != list.end(); it++) {\n> +\t\tauto x = it->get<double>();\n> +\t\tif (!x)\n> +\t\t\treturn std::nullopt;\n> +\t\tauto y = (++it)->get<double>();\n> +\t\tif (!y)\n> +\t\t\treturn std::nullopt;\n> +\n> +\t\tpwl.append(*x, *y);\n> +\t}\n> +\n> +\tif (pwl.size() != obj.size() / 2)\n> +\t\treturn std::nullopt;\n> +\n> +\treturn pwl;\n> +}\n> +#endif /* __DOXYGEN__ */\n> +\n>  } /* namespace libcamera */","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6BD87BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 13 Jun 2024 08:05:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66B566548F;\n\tThu, 13 Jun 2024 10:05:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AFB1E6548B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Jun 2024 10:05:10 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 67DEABEB;\n\tThu, 13 Jun 2024 10:04:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"svHGgprb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718265896;\n\tbh=zQZxFCcKLgK47fD8St/ER6K1DSRJEiycIyQQfOcJV6E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=svHGgprbtgwLNu6Xd8XQboXv4sOQhCvnnsWoXqT0idUByEF5FjKu8R0pY7XntQTqu\n\tGbEDZ5H01wXLxXIeir1shAxI29j+gpQ9YYX/Spr8VpKQTxk0QUy0eN+Rm1MXmc9f8J\n\tKjVZWcI74FYL0X0wiAzKTujY2FAnUSECqQOP4H5o=","Date":"Thu, 13 Jun 2024 17:05:02 +0900","From":"Paul Elder <paul.elder@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tNaushir Patuck <naush@raspberrypi.com>","Subject":"Re: [PATCH 09/11] ipa: libipa: pwl: Specialize YamlObject getter","Message-ID":"<ZmqoLlKcUYGGeciA@pyrite.rasen.tech>","References":"<20240613013944.23344-1-laurent.pinchart@ideasonboard.com>\n\t<20240613013944.23344-10-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240613013944.23344-10-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":29918,"web_url":"https://patchwork.libcamera.org/comment/29918/","msgid":"<171827861495.1550852.18213529335868695906@ping.linuxembedded.co.uk>","date":"2024-06-13T11:36:54","subject":"Re: [PATCH 09/11] ipa: libipa: pwl: Specialize YamlObject getter","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-06-13 02:39:42)\n> Implement a specialization of the YamlObject::Getter structure to\n> support deserializing ipa::Pwl objects from YAML data.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  src/ipa/libipa/pwl.cpp | 35 +++++++++++++++++++++++++++++++++++\n>  1 file changed, 35 insertions(+)\n> \n> diff --git a/src/ipa/libipa/pwl.cpp b/src/ipa/libipa/pwl.cpp\n> index cf864fbb3889..3c639645fa3d 100644\n> --- a/src/ipa/libipa/pwl.cpp\n> +++ b/src/ipa/libipa/pwl.cpp\n> @@ -459,4 +459,39 @@ std::string Pwl::toString() const\n>  \n>  } /* namespace ipa */\n>  \n> +#ifndef __DOXYGEN__\n> +/*\n> + * The YAML data shall be a list of numerical values with an even number of\n> + * elements. They are parsed in pairs into x and y points in the piecewise\n> + * linear function, and added in order. x must be monotonically increasing.\n> + */\n\nI love this text. But I'm not sure it's where users will see it ;-(\n\n\n\n> +template<>\n> +std::optional<ipa::Pwl>\n> +YamlObject::Getter<ipa::Pwl>::get(const YamlObject &obj) const\n> +{\n> +       if (!obj.size() || obj.size() % 2)\n> +               return std::nullopt;\n> +\n> +       ipa::Pwl pwl;\n> +\n> +       const auto &list = obj.asList();\n> +\n> +       for (auto it = list.begin(); it != list.end(); it++) {\n> +               auto x = it->get<double>();\n> +               if (!x)\n> +                       return std::nullopt;\n> +               auto y = (++it)->get<double>();\n> +               if (!y)\n\nI assume that's safe...\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> +                       return std::nullopt;\n> +\n> +               pwl.append(*x, *y);\n> +       }\n> +\n> +       if (pwl.size() != obj.size() / 2)\n\nNow I see the value of size...\n\n> +               return std::nullopt;\n> +\n> +       return pwl;\n> +}\n> +#endif /* __DOXYGEN__ */\n> +\n>  } /* namespace libcamera */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BF1D5C3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 13 Jun 2024 11:36:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0DD2465497;\n\tThu, 13 Jun 2024 13:36:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 11BDC6548E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Jun 2024 13:36:58 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 089104CF;\n\tThu, 13 Jun 2024 13:36:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mMYh5a3K\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718278604;\n\tbh=m/Iug29yFFZsn96yGiTmEJPrzSqKG0Rga7qDgV2Bgsc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=mMYh5a3KLiAHdXGTSLWJEOgqpmORput9Vmgi66fOCi+kyYGn/M0xUTlGJ7/vux5SF\n\tfSz9RK4y8J+YSCIGr+JFxmlNQckC8b7jLdQv/om2M5uLjG3MXx5Ny0j6llDI2fKHXe\n\tuiFem3qsTXC2ozMTTVL/UA1PA/m4+eV4VRH/xSos=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240613013944.23344-10-laurent.pinchart@ideasonboard.com>","References":"<20240613013944.23344-1-laurent.pinchart@ideasonboard.com>\n\t<20240613013944.23344-10-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 09/11] ipa: libipa: pwl: Specialize YamlObject getter","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Paul Elder <paul.elder@ideasonboard.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tNaushir Patuck <naush@raspberrypi.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 13 Jun 2024 12:36:54 +0100","Message-ID":"<171827861495.1550852.18213529335868695906@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":29921,"web_url":"https://patchwork.libcamera.org/comment/29921/","msgid":"<20240613115942.GJ6019@pendragon.ideasonboard.com>","date":"2024-06-13T11:59:42","subject":"Re: [PATCH 09/11] ipa: libipa: pwl: Specialize YamlObject getter","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jun 13, 2024 at 12:36:54PM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2024-06-13 02:39:42)\n> > Implement a specialization of the YamlObject::Getter structure to\n> > support deserializing ipa::Pwl objects from YAML data.\n> > \n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > ---\n> >  src/ipa/libipa/pwl.cpp | 35 +++++++++++++++++++++++++++++++++++\n> >  1 file changed, 35 insertions(+)\n> > \n> > diff --git a/src/ipa/libipa/pwl.cpp b/src/ipa/libipa/pwl.cpp\n> > index cf864fbb3889..3c639645fa3d 100644\n> > --- a/src/ipa/libipa/pwl.cpp\n> > +++ b/src/ipa/libipa/pwl.cpp\n> > @@ -459,4 +459,39 @@ std::string Pwl::toString() const\n> >  \n> >  } /* namespace ipa */\n> >  \n> > +#ifndef __DOXYGEN__\n> > +/*\n> > + * The YAML data shall be a list of numerical values with an even number of\n> > + * elements. They are parsed in pairs into x and y points in the piecewise\n> > + * linear function, and added in order. x must be monotonically increasing.\n> > + */\n> \n> I love this text. But I'm not sure it's where users will see it ;-(\n\nUsers of libcamera definitely won't. From a user point of view, this\nneeds to be translate to a combination of YAML schema and documentation\nfor the tuning file formats.\n\nFrom an IPA module developer point of view, this comment will not appear\nin generated documentation either. It occurred to me when writing the\npatches, and I'm still not sure if I'm (very slightly) concerned by that\nor not. I don't think it will catch anyone by surprise, and I expect\nmost users to copy code or get inspiration from existing IPA modules.\n\n> > +template<>\n> > +std::optional<ipa::Pwl>\n> > +YamlObject::Getter<ipa::Pwl>::get(const YamlObject &obj) const\n> > +{\n> > +       if (!obj.size() || obj.size() % 2)\n> > +               return std::nullopt;\n> > +\n> > +       ipa::Pwl pwl;\n> > +\n> > +       const auto &list = obj.asList();\n> > +\n> > +       for (auto it = list.begin(); it != list.end(); it++) {\n> > +               auto x = it->get<double>();\n> > +               if (!x)\n> > +                       return std::nullopt;\n> > +               auto y = (++it)->get<double>();\n> > +               if (!y)\n> \n> I assume that's safe...\n> \n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> > +                       return std::nullopt;\n> > +\n> > +               pwl.append(*x, *y);\n> > +       }\n> > +\n> > +       if (pwl.size() != obj.size() / 2)\n> \n> Now I see the value of size...\n> \n> > +               return std::nullopt;\n> > +\n> > +       return pwl;\n> > +}\n> > +#endif /* __DOXYGEN__ */\n> > +\n> >  } /* namespace libcamera */","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 524CCBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 13 Jun 2024 12:00:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0589965496;\n\tThu, 13 Jun 2024 14:00:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D23B6548D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Jun 2024 14:00:04 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 809C64CF;\n\tThu, 13 Jun 2024 13:59:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Gp1ue/i8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718279989;\n\tbh=vjsYOlm0GOL4gMF+gccY/Y5FzDWXgKs9SRk4vMZ/+Bk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Gp1ue/i89WcczFYxQ9i4auS61g1PUEQipGjiq2fElDc3Lc3TcIyb8Se0Gb6+sxEbW\n\tUL09IG4sHNWrQOa49fRgK/tJ3dqJ4D69xoZQWscsKJS1jrAjaj0d79e4x2HfAAMK8l\n\tjobPKZHuZH0GITRktFflI061abKQMDhtDjUiVoYE=","Date":"Thu, 13 Jun 2024 14:59:42 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org,\n\tPaul Elder <paul.elder@ideasonboard.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tNaushir Patuck <naush@raspberrypi.com>","Subject":"Re: [PATCH 09/11] ipa: libipa: pwl: Specialize YamlObject getter","Message-ID":"<20240613115942.GJ6019@pendragon.ideasonboard.com>","References":"<20240613013944.23344-1-laurent.pinchart@ideasonboard.com>\n\t<20240613013944.23344-10-laurent.pinchart@ideasonboard.com>\n\t<171827861495.1550852.18213529335868695906@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<171827861495.1550852.18213529335868695906@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":29923,"web_url":"https://patchwork.libcamera.org/comment/29923/","msgid":"<171828051956.2248009.12793582863892670895@ping.linuxembedded.co.uk>","date":"2024-06-13T12:08:39","subject":"Re: [PATCH 09/11] ipa: libipa: pwl: Specialize YamlObject getter","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-06-13 12:59:42)\n> On Thu, Jun 13, 2024 at 12:36:54PM +0100, Kieran Bingham wrote:\n> > Quoting Laurent Pinchart (2024-06-13 02:39:42)\n> > > Implement a specialization of the YamlObject::Getter structure to\n> > > support deserializing ipa::Pwl objects from YAML data.\n> > > \n> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > > ---\n> > >  src/ipa/libipa/pwl.cpp | 35 +++++++++++++++++++++++++++++++++++\n> > >  1 file changed, 35 insertions(+)\n> > > \n> > > diff --git a/src/ipa/libipa/pwl.cpp b/src/ipa/libipa/pwl.cpp\n> > > index cf864fbb3889..3c639645fa3d 100644\n> > > --- a/src/ipa/libipa/pwl.cpp\n> > > +++ b/src/ipa/libipa/pwl.cpp\n> > > @@ -459,4 +459,39 @@ std::string Pwl::toString() const\n> > >  \n> > >  } /* namespace ipa */\n> > >  \n> > > +#ifndef __DOXYGEN__\n> > > +/*\n> > > + * The YAML data shall be a list of numerical values with an even number of\n> > > + * elements. They are parsed in pairs into x and y points in the piecewise\n> > > + * linear function, and added in order. x must be monotonically increasing.\n> > > + */\n> > \n> > I love this text. But I'm not sure it's where users will see it ;-(\n> \n> Users of libcamera definitely won't. From a user point of view, this\n> needs to be translate to a combination of YAML schema and documentation\n> for the tuning file formats.\n> \n> From an IPA module developer point of view, this comment will not appear\n> in generated documentation either. It occurred to me when writing the\n> patches, and I'm still not sure if I'm (very slightly) concerned by that\n> or not. I don't think it will catch anyone by surprise, and I expect\n> most users to copy code or get inspiration from existing IPA modules.\n\nI meant users of the function... but yes I think it's fine for now.\n\n--\nKieran","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48CD8C3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 13 Jun 2024 12:08:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0DCD96549D;\n\tThu, 13 Jun 2024 14:08:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F1386548D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Jun 2024 14:08:42 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2CA79743;\n\tThu, 13 Jun 2024 14:08:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Jg30clrA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718280508;\n\tbh=rp+qtan/KVEk8tem5HoJrWHpKADLe5+HxQ4BdJSNLiA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Jg30clrAD3nIE3+7IJms3p5phbju5d86AFYSFT4BmDTbFmt0TP30/koRg0U2L/aL5\n\trT/O49yPNxM3wMNNcUhUALAfG1nu0PGy8jCYS+gyIIgHzugPfJwmSFu2H2DMKMTEk5\n\t6PHqLyi1EcAGnbRnBmdOtD/fPYAb9vX9XKcDy0JY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240613115942.GJ6019@pendragon.ideasonboard.com>","References":"<20240613013944.23344-1-laurent.pinchart@ideasonboard.com>\n\t<20240613013944.23344-10-laurent.pinchart@ideasonboard.com>\n\t<171827861495.1550852.18213529335868695906@ping.linuxembedded.co.uk>\n\t<20240613115942.GJ6019@pendragon.ideasonboard.com>","Subject":"Re: [PATCH 09/11] ipa: libipa: pwl: Specialize YamlObject getter","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org,\n\tPaul Elder <paul.elder@ideasonboard.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tNaushir Patuck <naush@raspberrypi.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Date":"Thu, 13 Jun 2024 13:08:39 +0100","Message-ID":"<171828051956.2248009.12793582863892670895@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]