{"id":20276,"url":"https://patchwork.libcamera.org/api/patches/20276/?format=json","web_url":"https://patchwork.libcamera.org/patch/20276/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240613013944.23344-5-laurent.pinchart@ideasonboard.com>","date":"2024-06-13T01:39:37","name":"[04/11] ipa: libipa: vector: Drop readYaml() function","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"421a3e2caddd66e4249822b9e9af2193b2e9ce22","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20276/mbox/","series":[{"id":4386,"url":"https://patchwork.libcamera.org/api/series/4386/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4386","date":"2024-06-13T01:39:33","name":"ipa: libipa: Vector and Pwl improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/4386/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20276/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20276/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB22DC3237\n\tfor ;\n\tThu, 13 Jun 2024 01:40:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 749F26548E;\n\tThu, 13 Jun 2024 03:40:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC2F46548D\n\tfor ;\n\tThu, 13 Jun 2024 03:40:10 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C8D1BEB;\n\tThu, 13 Jun 2024 03:39:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"et9LEaXA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718242796;\n\tbh=6+WxV82SCc7NA/PAiPvjRQwCUTImjbjizgdBq9+JBQc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=et9LEaXAy9YvB70BWQZFoAZLFyH9GHZiof+UtL6mvBEeCsv/YBG6aD4q9zbgivKW1\n\tHUKy++Gaam6AA0ywEfZGh4GswXGpLX415/NGF0sBzHzV6mz/LZl6v/S0Nwk9RpUtGf\n\tFD0As9FfXOtCYyMGlOS9twuJSs0I+Yu+1Nw8/h+A=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder ,\n\tDavid Plowman ,\n\tNaushir Patuck ","Subject":"[PATCH 04/11] ipa: libipa: vector: Drop readYaml() function","Date":"Thu, 13 Jun 2024 04:39:37 +0300","Message-ID":"<20240613013944.23344-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240613013944.23344-1-laurent.pinchart@ideasonboard.com>","References":"<20240613013944.23344-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that YAML deserialization of Vector instances is supported through\nYamlObject::get(), remove the Vector::readYaml() function. It turns out\nnot be used.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/libipa/vector.cpp | 13 -------------\n src/ipa/libipa/vector.h | 23 -----------------------\n 2 files changed, 36 deletions(-)","diff":"diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex 4e987d82fa70..b071b261b9c4 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -40,19 +40,6 @@ namespace ipa {\n * The size of \\a data must be equal to the dimension size Rows of the vector.\n */\n \n-/**\n- * \\fn Vector::readYaml\n- * \\brief Populate the vector with yaml data\n- * \\param yaml Yaml data to populate the vector with\n- *\n- * Any existing data in the vector will be overwritten. The size of the data\n- * read from \\a yaml must be equal to the dimension size Rows of the vector.\n- *\n- * The yaml data is expected to be a list with elements of type T.\n- *\n- * \\return 0 on success, negative error code otherwise\n- */\n-\n /**\n * \\fn T Vector::operator[](size_t i) const\n * \\brief Index to an element in the vector\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex 4b2fe581ecc2..2a2906202ce4 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -39,29 +39,6 @@ public:\n \t\t\tdata_[i] = data[i];\n \t}\n \n-\tint readYaml(const libcamera::YamlObject &yaml)\n-\t{\n-\t\tif (yaml.size() != Rows) {\n-\t\t\tLOG(Vector, Error)\n-\t\t\t\t<< \"Wrong number of values in vector: expected \"\n-\t\t\t\t<< Rows << \", got \" << yaml.size();\n-\t\t\treturn -EINVAL;\n-\t\t}\n-\n-\t\tunsigned int i = 0;\n-\t\tfor (const auto &x : yaml.asList()) {\n-\t\t\tauto value = x.get();\n-\t\t\tif (!value) {\n-\t\t\t\tLOG(Vector, Error) << \"Failed to read vector value\";\n-\t\t\t\treturn -EINVAL;\n-\t\t\t}\n-\n-\t\t\tdata_[i++] = *value;\n-\t\t}\n-\n-\t\treturn 0;\n-\t}\n-\n \tconst T &operator[](size_t i) const\n \t{\n \t\tASSERT(i < data_.size());\n","prefixes":["04/11"]}