[{"id":29862,"web_url":"https://patchwork.libcamera.org/comment/29862/","msgid":"","date":"2024-06-12T07:42:18","subject":"Re: [PATCH 4/6] ipa: rkisp1: goc: Mark default gamma table as static\n\tconstexpr","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nthank you for the patch. This was actually mentioned by Jacopo and I\nmissed it. Sorry for that.\n\nOn Wed, Jun 12, 2024 at 12:20:59AM +0300, Laurent Pinchart wrote:\n> The values for the default gamma table are stored in an array that is\n> never modified. Mark it as static constexpr to facilitate optimizations.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> ---\n> src/ipa/rkisp1/algorithms/goc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp\n> index 65460eb45135..e98c9526722f 100644\n> --- a/src/ipa/rkisp1/algorithms/goc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/goc.cpp\n> @@ -108,7 +108,7 @@ void GammaOutCorrection::prepare(IPAContext &context,\n> \t * The logarithmic segments as specified in the reference.\n> \t * Plus an additional 0 to make the loop easier\n> \t */\n> -\tstd::array segments = {\n> +\tstatic constexpr std::array segments = {\n> \t\t64, 64, 64, 64, 128, 128, 128, 128, 256,\n> \t\t256, 256, 512, 512, 512, 512, 512, 0\n> \t};\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65804C3237\n\tfor ;\n\tWed, 12 Jun 2024 07:42:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8821B65461;\n\tWed, 12 Jun 2024 09:42:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FBB661A2A\n\tfor ;\n\tWed, 12 Jun 2024 09:42:21 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:31fd:fdd2:5613:c54c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 149824D0;\n\tWed, 12 Jun 2024 09:42:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IzRZr6MK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718178128;\n\tbh=fsR1ReE90SItNMsvKB18h78iCL5Szgdd2Dofd93YAy0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IzRZr6MK7lHBeTLgzOXmS990Sn4Y9ZpsVE0M0EFO9peUzIns0fyTxGMo59rECJAKB\n\tTjHeT0hpfyVUrFDb9XHCiVIecmnmX59kOlxNGEp37xZiksfAEMAIUclwwcoJRj+0vo\n\tovK7qpSDBbMq7Nr4hZNUxwAIUKrmIVUQFQYYprig=","Date":"Wed, 12 Jun 2024 09:42:18 +0200","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 4/6] ipa: rkisp1: goc: Mark default gamma table as static\n\tconstexpr","Message-ID":"","References":"<20240611212101.14313-1-laurent.pinchart@ideasonboard.com>\n\t<20240611212101.14313-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240611212101.14313-5-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]