{"id":20268,"url":"https://patchwork.libcamera.org/api/patches/20268/?format=json","web_url":"https://patchwork.libcamera.org/patch/20268/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240611212101.14313-5-laurent.pinchart@ideasonboard.com>","date":"2024-06-11T21:20:59","name":"[4/6] ipa: rkisp1: goc: Mark default gamma table as static constexpr","commit_ref":"1ca1d06d67c1bb1518ce5a96e49fb1cdf64d940b","pull_url":null,"state":"accepted","archived":false,"hash":"50ce5f6804969f8d3eb7667b89e7f5c57edc41ce","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20268/mbox/","series":[{"id":4384,"url":"https://patchwork.libcamera.org/api/series/4384/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4384","date":"2024-06-11T21:20:55","name":"ipa: rksip1: goc: Assorted fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4384/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20268/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20268/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC8BCC3293\n\tfor ;\n\tTue, 11 Jun 2024 21:21:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9209965467;\n\tTue, 11 Jun 2024 23:21:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 814B665446\n\tfor ;\n\tTue, 11 Jun 2024 23:21:26 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7623AE0C;\n\tTue, 11 Jun 2024 23:21:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LO6I5Jr1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718140873;\n\tbh=clXSMilTWHCoCAYcYA/m/lLuDzSJBudUJMZlnhkPkeg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=LO6I5Jr1Fl40ZEajQ473h4Zd4VW2MhsEgObMOksfPDyqg2gTXtQdAwD8/m1B7QW1K\n\tW378qB23uF0MmIQfRY/XU3vAHywZSHX2H/F0GGdpZr7Ail8iqY3LhOwTNvCO+JPYYi\n\tqYEiQsmiASVNT0ua3naMxiCVDcjRqcKDBT27Gtv4=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 4/6] ipa: rkisp1: goc: Mark default gamma table as static\n\tconstexpr","Date":"Wed, 12 Jun 2024 00:20:59 +0300","Message-ID":"<20240611212101.14313-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240611212101.14313-1-laurent.pinchart@ideasonboard.com>","References":"<20240611212101.14313-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The values for the default gamma table are stored in an array that is\nnever modified. Mark it as static constexpr to facilitate optimizations.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/rkisp1/algorithms/goc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp\nindex 65460eb45135..e98c9526722f 100644\n--- a/src/ipa/rkisp1/algorithms/goc.cpp\n+++ b/src/ipa/rkisp1/algorithms/goc.cpp\n@@ -108,7 +108,7 @@ void GammaOutCorrection::prepare(IPAContext &context,\n \t * The logarithmic segments as specified in the reference.\n \t * Plus an additional 0 to make the loop easier\n \t */\n-\tstd::array segments = {\n+\tstatic constexpr std::array segments = {\n \t\t64, 64, 64, 64, 128, 128, 128, 128, 256,\n \t\t256, 256, 512, 512, 512, 512, 512, 0\n \t};\n","prefixes":["4/6"]}