[{"id":29861,"web_url":"https://patchwork.libcamera.org/comment/29861/","msgid":"","date":"2024-06-12T07:27:08","subject":"Re: [PATCH 3/6] ipa: rkisp1: goc: Use copydoc","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nthanks you for the patch. Kieran mentioned the same on cproc and I\nmissed to backport it. Thanks for the fix.\n\nOn Wed, Jun 12, 2024 at 12:20:58AM +0300, Laurent Pinchart wrote:\n> Use the Doygen \\copydoc command instead of duplicating documentation.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> ---\n> src/ipa/rkisp1/algorithms/goc.cpp | 6 +-----\n> 1 file changed, 1 insertion(+), 5 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp\n> index 01331b653c27..65460eb45135 100644\n> --- a/src/ipa/rkisp1/algorithms/goc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/goc.cpp\n> @@ -64,11 +64,7 @@ int GammaOutCorrection::init(IPAContext &context, const YamlObject &tuningData)\n> }\n> \n> /**\n> - * \\brief Configure the Gamma given a configInfo\n> - * \\param[in] context The shared IPA context\n> - * \\param[in] configInfo The IPA configuration data\n> - *\n> - * \\return 0\n> + * \\copydoc libcamera::ipa::Algorithm::configure\n> */\n> int GammaOutCorrection::configure(IPAContext &context,\n> \t\t\t\t [[maybe_unused]] const IPACameraSensorInfo &configInfo)\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D01FBD87C\n\tfor ;\n\tWed, 12 Jun 2024 07:27:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 953B465463;\n\tWed, 12 Jun 2024 09:27:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F1DC6545A\n\tfor ;\n\tWed, 12 Jun 2024 09:27:11 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:31fd:fdd2:5613:c54c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B9D364D0;\n\tWed, 12 Jun 2024 09:26:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PQnu8tSH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718177217;\n\tbh=CSJXyTOrurbdNcCujE7wk5GkolbPrzt1nEqpzf6SeH0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PQnu8tSHD7c3LuJ9ibhPJ0tgXtceCJXXr42zA8v36USiuD7uqeN+M9vVSf1RPGyMJ\n\tddyruizFm9eHJCmjFLzinqKoXugk3pJx532bKaFbKD1P9o/SFgJxfm9NJw6ZkcWGtu\n\tB/yZ1NoNoVvq5lBxCzmVe9N8cR0mTI13cDjOZKb8=","Date":"Wed, 12 Jun 2024 09:27:08 +0200","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 3/6] ipa: rkisp1: goc: Use copydoc","Message-ID":"","References":"<20240611212101.14313-1-laurent.pinchart@ideasonboard.com>\n\t<20240611212101.14313-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240611212101.14313-4-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]