[{"id":29860,"web_url":"https://patchwork.libcamera.org/comment/29860/","msgid":"","date":"2024-06-12T07:20:52","subject":"Re: [PATCH 2/6] ipa: rkisp1: goc: Drop incorrect [[maybe_unused]]","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nthanks you for the patch. You are absolutely right...\n\nOn Wed, Jun 12, 2024 at 12:20:57AM +0300, Laurent Pinchart wrote:\n> A few function parameters are marked with [[maybe_unused]] but are\n> actually used. Drop the attribute.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> ---\n> src/ipa/rkisp1/algorithms/goc.cpp | 10 ++++------\n> 1 file changed, 4 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp\n> index fc5ad9f9177e..01331b653c27 100644\n> --- a/src/ipa/rkisp1/algorithms/goc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/goc.cpp\n> @@ -48,8 +48,7 @@ const float kDefaultGamma = 2.2f;\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::init\n> */\n> -int GammaOutCorrection::init([[maybe_unused]] IPAContext &context,\n> -\t\t\t [[maybe_unused]] const YamlObject &tuningData)\n> +int GammaOutCorrection::init(IPAContext &context, const YamlObject &tuningData)\n> {\n> \tif (context.hw->numGammaOutSamples !=\n> \t RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10) {\n> @@ -81,8 +80,7 @@ int GammaOutCorrection::configure(IPAContext &context,\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::queueRequest\n> */\n> -void GammaOutCorrection::queueRequest([[maybe_unused]] IPAContext &context,\n> -\t\t\t\t [[maybe_unused]] const uint32_t frame,\n> +void GammaOutCorrection::queueRequest(IPAContext &context, const uint32_t frame,\n> \t\t\t\t IPAFrameContext &frameContext,\n> \t\t\t\t const ControlList &controls)\n> {\n> @@ -102,9 +100,9 @@ void GammaOutCorrection::queueRequest([[maybe_unused]] IPAContext &context,\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::prepare\n> */\n> -void GammaOutCorrection::prepare([[maybe_unused]] IPAContext &context,\n> +void GammaOutCorrection::prepare(IPAContext &context,\n> \t\t\t\t [[maybe_unused]] const uint32_t frame,\n> -\t\t\t\t [[maybe_unused]] IPAFrameContext &frameContext,\n> +\t\t\t\t IPAFrameContext &frameContext,\n> \t\t\t\t rkisp1_params_cfg *params)\n> {\n> \tASSERT(context.hw->numGammaOutSamples ==\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 600A6C3237\n\tfor ;\n\tWed, 12 Jun 2024 07:20:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 62F7D6545A;\n\tWed, 12 Jun 2024 09:20:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C64F61A2A\n\tfor ;\n\tWed, 12 Jun 2024 09:20:55 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:31fd:fdd2:5613:c54c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A27B04D0;\n\tWed, 12 Jun 2024 09:20:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hl4Vt3s5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718176841;\n\tbh=Tl8aFf+9qHH/o/t+/oBC/C1LfkKtusVRFMs+jn4ztpc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hl4Vt3s5850zTLAfTUm59QegXVwV7RdAQ345chLBwdVyM1rHjCy3v09SD5kU47bHN\n\th1YusD5J61J0SHJOUuENkFVYBx5c690fuYGorbG/INXUL6DzH++ZIofZhh2/XJ4yvF\n\tAmnGUpbF8wWMPdd0JO2+GQqc+vbjD3jqhxFZ76cU=","Date":"Wed, 12 Jun 2024 09:20:52 +0200","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/6] ipa: rkisp1: goc: Drop incorrect [[maybe_unused]]","Message-ID":"","References":"<20240611212101.14313-1-laurent.pinchart@ideasonboard.com>\n\t<20240611212101.14313-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240611212101.14313-3-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]