{"id":20266,"url":"https://patchwork.libcamera.org/api/patches/20266/?format=json","web_url":"https://patchwork.libcamera.org/patch/20266/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240611212101.14313-3-laurent.pinchart@ideasonboard.com>","date":"2024-06-11T21:20:57","name":"[2/6] ipa: rkisp1: goc: Drop incorrect [[maybe_unused]]","commit_ref":"2a253be3339d70f92c8e3d63ea19bafafc628219","pull_url":null,"state":"accepted","archived":false,"hash":"f11ac1338eb4dcd37aec12d354f7226117cd8b7d","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20266/mbox/","series":[{"id":4384,"url":"https://patchwork.libcamera.org/api/series/4384/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4384","date":"2024-06-11T21:20:55","name":"ipa: rksip1: goc: Assorted fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4384/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20266/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20266/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0353C3293\n\tfor ;\n\tTue, 11 Jun 2024 21:21:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AB8926546D;\n\tTue, 11 Jun 2024 23:21:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD72561A26\n\tfor ;\n\tTue, 11 Jun 2024 23:21:23 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C587EA9A;\n\tTue, 11 Jun 2024 23:21:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"t853/Tsz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718140871;\n\tbh=BY1KvL2omlGgZG8+YS/cug+bFLeSdBplKzmoA0SinE4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=t853/TszN8QmyM8IlCpKtFHLZPqNuB4aLFcAGyr13u8d5AKVaLAVV4tzB1diUMqlX\n\tyfE0XA4y7EAa15NO6qzC8orMFLt55Zu+MlxzPBBmuRbkDqIIwBtq/wrkCIbdJBFttK\n\tfiPn/YTeXhJ4OxFd/hxye3GFHgjpxeVG1NPGwH2w=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 2/6] ipa: rkisp1: goc: Drop incorrect [[maybe_unused]]","Date":"Wed, 12 Jun 2024 00:20:57 +0300","Message-ID":"<20240611212101.14313-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240611212101.14313-1-laurent.pinchart@ideasonboard.com>","References":"<20240611212101.14313-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A few function parameters are marked with [[maybe_unused]] but are\nactually used. Drop the attribute.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/rkisp1/algorithms/goc.cpp | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp\nindex fc5ad9f9177e..01331b653c27 100644\n--- a/src/ipa/rkisp1/algorithms/goc.cpp\n+++ b/src/ipa/rkisp1/algorithms/goc.cpp\n@@ -48,8 +48,7 @@ const float kDefaultGamma = 2.2f;\n /**\n * \\copydoc libcamera::ipa::Algorithm::init\n */\n-int GammaOutCorrection::init([[maybe_unused]] IPAContext &context,\n-\t\t\t [[maybe_unused]] const YamlObject &tuningData)\n+int GammaOutCorrection::init(IPAContext &context, const YamlObject &tuningData)\n {\n \tif (context.hw->numGammaOutSamples !=\n \t RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10) {\n@@ -81,8 +80,7 @@ int GammaOutCorrection::configure(IPAContext &context,\n /**\n * \\copydoc libcamera::ipa::Algorithm::queueRequest\n */\n-void GammaOutCorrection::queueRequest([[maybe_unused]] IPAContext &context,\n-\t\t\t\t [[maybe_unused]] const uint32_t frame,\n+void GammaOutCorrection::queueRequest(IPAContext &context, const uint32_t frame,\n \t\t\t\t IPAFrameContext &frameContext,\n \t\t\t\t const ControlList &controls)\n {\n@@ -102,9 +100,9 @@ void GammaOutCorrection::queueRequest([[maybe_unused]] IPAContext &context,\n /**\n * \\copydoc libcamera::ipa::Algorithm::prepare\n */\n-void GammaOutCorrection::prepare([[maybe_unused]] IPAContext &context,\n+void GammaOutCorrection::prepare(IPAContext &context,\n \t\t\t\t [[maybe_unused]] const uint32_t frame,\n-\t\t\t\t [[maybe_unused]] IPAFrameContext &frameContext,\n+\t\t\t\t IPAFrameContext &frameContext,\n \t\t\t\t rkisp1_params_cfg *params)\n {\n \tASSERT(context.hw->numGammaOutSamples ==\n","prefixes":["2/6"]}