[{"id":29859,"web_url":"https://patchwork.libcamera.org/comment/29859/","msgid":"","date":"2024-06-12T07:17:23","subject":"Re: [PATCH 1/6] ipa: rkisp1: goc: Fix typographical issues in\n\tdocumentation.","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nthank you for the fixup.\n\nOn Wed, Jun 12, 2024 at 12:20:56AM +0300, Laurent Pinchart wrote:\n> Fix a few assorted typographical issues:\n> \n> - Sentences should end with a period.\n> - Paragraphs should be separated by a blank line, and there should be no\n> line break within a paragraph.\n> - Doxygen lists need a list marker ('-' or '*', use '-' here).\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\nStefan\n\n> ---\n> src/ipa/rkisp1/algorithms/goc.cpp | 9 +++++----\n> 1 file changed, 5 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp\n> index 0201a59deba3..fc5ad9f9177e 100644\n> --- a/src/ipa/rkisp1/algorithms/goc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/goc.cpp\n> @@ -29,15 +29,16 @@ namespace ipa::rkisp1::algorithms {\n> * \\class GammaOutCorrection\n> * \\brief RkISP1 Gamma out correction\n> *\n> - * This algorithm implements the gamma out curve for the RkISP1.\n> - * It defaults to a gamma value of 2.2\n> + * This algorithm implements the gamma out curve for the RkISP1. It defaults to\n> + * a gamma value of 2.2.\n> + *\n> * As gamma is internally represented as a piecewise linear function with only\n> * 17 knots, the difference between gamma=2.2 and sRGB gamma is minimal.\n> * Therefore sRGB gamma was not implemented as special case.\n> *\n> * Useful links:\n> - * https://www.cambridgeincolour.com/tutorials/gamma-correction.htm\n> - * https://en.wikipedia.org/wiki/SRGB\n> + * - https://www.cambridgeincolour.com/tutorials/gamma-correction.htm\n> + * - https://en.wikipedia.org/wiki/SRGB\n> */\n> \n> LOG_DEFINE_CATEGORY(RkISP1Gamma)\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A146BD87C\n\tfor ;\n\tWed, 12 Jun 2024 07:17:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6377D65461;\n\tWed, 12 Jun 2024 09:17:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4EFD61A2A\n\tfor ;\n\tWed, 12 Jun 2024 09:17:26 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:31fd:fdd2:5613:c54c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6018E4D0;\n\tWed, 12 Jun 2024 09:17:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XrYq4sCW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718176633;\n\tbh=yH6hBY9yob2RpjYq152k1cfhDtZGpr/48BJ4hod+wq0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XrYq4sCWiA2MNVjgvffdMpR9M5uFT50FsN3UzHaUeOVEgw++IzUFU/M+jSVSQq+9R\n\tyHwRcxcNabsJbJfxh96UFiI2EtRe9s/3SO3ELDXnAkmQOiv/FCwf8k/JejOuhUTx10\n\tbbLpguL3p030jhQooZelQDA/WFnWjDccU/tDfdiA=","Date":"Wed, 12 Jun 2024 09:17:23 +0200","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/6] ipa: rkisp1: goc: Fix typographical issues in\n\tdocumentation.","Message-ID":"","References":"<20240611212101.14313-1-laurent.pinchart@ideasonboard.com>\n\t<20240611212101.14313-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240611212101.14313-2-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]