{"id":20265,"url":"https://patchwork.libcamera.org/api/patches/20265/?format=json","web_url":"https://patchwork.libcamera.org/patch/20265/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240611212101.14313-2-laurent.pinchart@ideasonboard.com>","date":"2024-06-11T21:20:56","name":"[1/6] ipa: rkisp1: goc: Fix typographical issues in documentation.","commit_ref":"6dba3f461259461f62417d567e8766da27767216","pull_url":null,"state":"accepted","archived":false,"hash":"59bfc4e01ded40db120c85037445c0ddbacf28e8","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20265/mbox/","series":[{"id":4384,"url":"https://patchwork.libcamera.org/api/series/4384/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4384","date":"2024-06-11T21:20:55","name":"ipa: rksip1: goc: Assorted fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4384/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20265/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20265/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6B6DC3237\n\tfor ;\n\tTue, 11 Jun 2024 21:21:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E34E66546A;\n\tTue, 11 Jun 2024 23:21:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BC8061A26\n\tfor ;\n\tTue, 11 Jun 2024 23:21:22 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72786A9A;\n\tTue, 11 Jun 2024 23:21:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nOkYMqNs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718140869;\n\tbh=Qlx/ro7vGVh832Dvby6lQaoJDsrvKu6KQnztNbCPIkc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nOkYMqNsL31bdRpaN+DyvyYC/EuiaJj7fLQwzmhDA9M0c/m5N+PW+HiSVQSP9iC64\n\t8NJFSIE1Vb2Oo2VDueW8/9T+Or5EZu5dekrHkBVCFOt0yMDmN0m4o9Pcz94lfoEl85\n\tNdBaqymS6u9Isi6xbULEF8DM9g7R4kE/4kmbfGWo=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 1/6] ipa: rkisp1: goc: Fix typographical issues in\n\tdocumentation.","Date":"Wed, 12 Jun 2024 00:20:56 +0300","Message-ID":"<20240611212101.14313-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240611212101.14313-1-laurent.pinchart@ideasonboard.com>","References":"<20240611212101.14313-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Fix a few assorted typographical issues:\n\n- Sentences should end with a period.\n- Paragraphs should be separated by a blank line, and there should be no\n line break within a paragraph.\n- Doxygen lists need a list marker ('-' or '*', use '-' here).\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/rkisp1/algorithms/goc.cpp | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp\nindex 0201a59deba3..fc5ad9f9177e 100644\n--- a/src/ipa/rkisp1/algorithms/goc.cpp\n+++ b/src/ipa/rkisp1/algorithms/goc.cpp\n@@ -29,15 +29,16 @@ namespace ipa::rkisp1::algorithms {\n * \\class GammaOutCorrection\n * \\brief RkISP1 Gamma out correction\n *\n- * This algorithm implements the gamma out curve for the RkISP1.\n- * It defaults to a gamma value of 2.2\n+ * This algorithm implements the gamma out curve for the RkISP1. It defaults to\n+ * a gamma value of 2.2.\n+ *\n * As gamma is internally represented as a piecewise linear function with only\n * 17 knots, the difference between gamma=2.2 and sRGB gamma is minimal.\n * Therefore sRGB gamma was not implemented as special case.\n *\n * Useful links:\n- * https://www.cambridgeincolour.com/tutorials/gamma-correction.htm\n- * https://en.wikipedia.org/wiki/SRGB\n+ * - https://www.cambridgeincolour.com/tutorials/gamma-correction.htm\n+ * - https://en.wikipedia.org/wiki/SRGB\n */\n \n LOG_DEFINE_CATEGORY(RkISP1Gamma)\n","prefixes":["1/6"]}