[{"id":2715,"web_url":"https://patchwork.libcamera.org/comment/2715/","msgid":"<20190928172815.GC4865@pendragon.ideasonboard.com>","date":"2019-09-28T17:28:15","subject":"Re: [libcamera-devel] [PATCH v3 02/13] libcamera: controls: Add\n\tAeEnable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Sep 27, 2019 at 04:44:06AM +0200, Niklas Söderlund wrote:\n> Add a control to turn Auto Exposure on or off.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> include/libcamera/control_ids.h | 1 +\n> src/libcamera/controls.cpp | 17 +++++++++++++++--\n> 2 files changed, 16 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/control_ids.h b/include/libcamera/control_ids.h\n> index 75b6a2d5cafeca72..8cd44e571f705ac5 100644\n> --- a/include/libcamera/control_ids.h\n> +++ b/include/libcamera/control_ids.h\n> @@ -13,6 +13,7 @@\n> namespace libcamera {\n> \n> enum ControlId {\n> +\tAeEnable,\n> \tAwbEnable,\n> \tBrightness,\n> \tContrast,\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 727fdbd9450d2f40..44cb09d9102d93f6 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -186,6 +186,13 @@ std::string ControlValue::toString() const\n> * \\brief Numerical control ID\n> */\n> \n> +/**\n> + * \\var AeEnable\n> + * ControlType: Bool\n> + *\n> + * Enable or disable the auto-exposure algorithm. \\sa ControlId::ManualExposure.\n\ns/ \\\\sa/\\r * \\\\sa/ (a.k.a. line break before \\sa :-))\n\n> + */\n> +\n> /**\n> * \\var AwbEnable\n> * ControlType: Bool\n> @@ -218,14 +225,20 @@ std::string ControlValue::toString() const\n> * \\var ManualExposure\n> * ControlType: Integer\n> *\n> - * Specify a fixed exposure time in milli-seconds\n> + * Specify a fixed exposure time in milli-seconds.\n> + *\n> + * This control is only considered if AeEnable is not enabled. If present at\n\ns/is not enabled/is disabled/\n\n> + * at the same time as AeEnable the value will be ignored.\n\nIs it ignored but stored, in which case the value will take effect when\nAeEnable is turned off, or is it ignored completely ? I think the\nwording needs to be clarified a bit.\n\n> */\n> \n> /**\n> * \\var ManualGain\n> * ControlType: Integer\n> *\n> - * Specify a fixed gain parameter\n> + * Specify a fixed gain parameter.\n> + *\n> + * This control is only considered if AeEnable is not enabled. If present at\n> + * at the same time as AeEnable the value will be ignored.\n\nSame here.\n\n> */\n> \n> /**","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 878F460BBA\n\tfor ;\n\tSat, 28 Sep 2019 19:28:26 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 08CDF53B;\n\tSat, 28 Sep 2019 19:28:25 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1569691706;\n\tbh=bG2kR4OV3aWXHpRT0sycX01Ye847sxkyYumkt8FzTWY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FiaNuYId7yEULGUfGJ22jbFeK59jUaBhjn01m2hlexCti6url0mXFnuO3L+uCA92K\n\tP8DnUq0Bz6FUg/sMKyBoHTAP4kb/HOdi2MVZxHwpFi+P5M7taRGCCCbadIRA8/GFm/\n\tbKpUoLEDeudlXYs33vMq4aXqC7KyJy6gSzkZOyPw=","Date":"Sat, 28 Sep 2019 20:28:15 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190928172815.GC4865@pendragon.ideasonboard.com>","References":"<20190927024417.725906-1-niklas.soderlund@ragnatech.se>\n\t<20190927024417.725906-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190927024417.725906-3-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 02/13] libcamera: controls: Add\n\tAeEnable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 28 Sep 2019 17:28:26 -0000"}}]