[{"id":29830,"web_url":"https://patchwork.libcamera.org/comment/29830/","msgid":"<171811211394.2248009.15505228145831127074@ping.linuxembedded.co.uk>","date":"2024-06-11T13:21:53","subject":"Re: [PATCH] meson: Group libipa and libipa_includes in a dependency\n\tobject","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-06-11 13:42:05)\n> Many build targets link with libipa and need libipa_includes. Group them\n> in a libipa_dep dependency object to simplify the users.\n> \n> Signed-off-by: Laurent Pinchart \n\nI've been through, it seems reasonable to me.\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/ipu3/meson.build | 5 ++---\n> src/ipa/libipa/meson.build | 4 ++++\n> src/ipa/rkisp1/meson.build | 5 ++---\n> src/ipa/rpi/vc4/meson.build | 4 +---\n> src/ipa/simple/meson.build | 5 ++---\n> src/ipa/vimc/meson.build | 5 ++---\n> test/ipa/meson.build | 6 +++---\n> test/ipa/rkisp1/meson.build | 6 +++---\n> 8 files changed, 19 insertions(+), 21 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\n> index 66c398432d43..e76f97c07c87 100644\n> --- a/src/ipa/ipu3/meson.build\n> +++ b/src/ipa/ipu3/meson.build\n> @@ -15,9 +15,8 @@ ipu3_ipa_sources += ipu3_ipa_algorithms\n> mod = shared_module(ipa_name,\n> [ipu3_ipa_sources, libcamera_generated_ipa_headers],\n> name_prefix : '',\n> - include_directories : [ipa_includes, libipa_includes],\n> - dependencies : libcamera_private,\n> - link_with : libipa,\n> + include_directories : [ipa_includes],\n> + dependencies : [libcamera_private, libipa_dep],\n> install : true,\n> install_dir : ipa_install_dir)\n> \n> diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\n> index 8ec9c7847348..7f038c90cd87 100644\n> --- a/src/ipa/libipa/meson.build\n> +++ b/src/ipa/libipa/meson.build\n> @@ -27,3 +27,7 @@ libipa_includes = include_directories('..')\n> libipa = static_library('ipa', [libipa_sources, libipa_headers],\n> include_directories : ipa_includes,\n> dependencies : libcamera_private)\n> +\n> +libipa_dep = declare_dependency(sources : libipa_headers,\n> + include_directories : libipa_includes,\n> + link_with : libipa)\n> diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\n> index cf05cdb27943..e8b266f1ccca 100644\n> --- a/src/ipa/rkisp1/meson.build\n> +++ b/src/ipa/rkisp1/meson.build\n> @@ -16,9 +16,8 @@ rkisp1_ipa_sources += rkisp1_ipa_algorithms\n> mod = shared_module(ipa_name,\n> [rkisp1_ipa_sources, libcamera_generated_ipa_headers],\n> name_prefix : '',\n> - include_directories : [ipa_includes, libipa_includes],\n> - dependencies : libcamera_private,\n> - link_with : libipa,\n> + include_directories : [ipa_includes],\n> + dependencies : [libcamera_private, libipa_dep],\n> install : true,\n> install_dir : ipa_install_dir)\n> \n> diff --git a/src/ipa/rpi/vc4/meson.build b/src/ipa/rpi/vc4/meson.build\n> index 590e9197756d..63fc5925b06c 100644\n> --- a/src/ipa/rpi/vc4/meson.build\n> +++ b/src/ipa/rpi/vc4/meson.build\n> @@ -15,7 +15,6 @@ vc4_ipa_libs = [\n> \n> vc4_ipa_includes = [\n> ipa_includes,\n> - libipa_includes,\n> ]\n> \n> vc4_ipa_sources = files([\n> @@ -28,8 +27,7 @@ mod = shared_module(ipa_name,\n> [vc4_ipa_sources, libcamera_generated_ipa_headers],\n> name_prefix : '',\n> include_directories : vc4_ipa_includes,\n> - dependencies : vc4_ipa_deps,\n> - link_with : libipa,\n> + dependencies : [vc4_ipa_deps, libipa_dep],\n> link_whole : vc4_ipa_libs,\n> install : true,\n> install_dir : ipa_install_dir)\n> diff --git a/src/ipa/simple/meson.build b/src/ipa/simple/meson.build\n> index 44b5f1d70cd3..33d1c96aa4f2 100644\n> --- a/src/ipa/simple/meson.build\n> +++ b/src/ipa/simple/meson.build\n> @@ -10,9 +10,8 @@ soft_simple_sources = files([\n> mod = shared_module(ipa_name,\n> [soft_simple_sources, libcamera_generated_ipa_headers],\n> name_prefix : '',\n> - include_directories : [ipa_includes, libipa_includes],\n> - dependencies : libcamera_private,\n> - link_with : libipa,\n> + include_directories : [ipa_includes],\n> + dependencies : [libcamera_private, libipa_dep],\n> install : true,\n> install_dir : ipa_install_dir)\n> \n> diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build\n> index 264a2d9a8964..d0b63eddd5f6 100644\n> --- a/src/ipa/vimc/meson.build\n> +++ b/src/ipa/vimc/meson.build\n> @@ -5,9 +5,8 @@ ipa_name = 'ipa_vimc'\n> mod = shared_module(ipa_name,\n> ['vimc.cpp', libcamera_generated_ipa_headers],\n> name_prefix : '',\n> - include_directories : [ipa_includes, libipa_includes],\n> - dependencies : libcamera_private,\n> - link_with : libipa,\n> + include_directories : [ipa_includes],\n> + dependencies : [libcamera_private, libipa_dep],\n> install : true,\n> install_dir : ipa_install_dir)\n> \n> diff --git a/test/ipa/meson.build b/test/ipa/meson.build\n> index dc956284c4b1..fe21ca58b64f 100644\n> --- a/test/ipa/meson.build\n> +++ b/test/ipa/meson.build\n> @@ -9,9 +9,9 @@ ipa_test = [\n> \n> foreach test : ipa_test\n> exe = executable(test['name'], test['sources'], libcamera_generated_ipa_headers,\n> - dependencies : libcamera_private,\n> - link_with : [libipa, test_libraries],\n> - include_directories : [libipa_includes, test_includes_internal])\n> + dependencies : [libcamera_private, libipa_dep],\n> + link_with : [test_libraries],\n> + include_directories : [test_includes_internal])\n> \n> test(test['name'], exe, suite : 'ipa')\n> endforeach\n> diff --git a/test/ipa/rkisp1/meson.build b/test/ipa/rkisp1/meson.build\n> index 5ffc5dd607b6..5b08e2939ce6 100644\n> --- a/test/ipa/rkisp1/meson.build\n> +++ b/test/ipa/rkisp1/meson.build\n> @@ -6,9 +6,9 @@ rkisp1_ipa_test = [\n> \n> foreach test : rkisp1_ipa_test\n> exe = executable(test['name'], test['sources'], libcamera_generated_ipa_headers,\n> - dependencies : libcamera_private,\n> - link_with : [libipa, test_libraries],\n> - include_directories : [libipa_includes, test_includes_internal,\n> + dependencies : [libcamera_private, libipa_dep],\n> + link_with : [test_libraries],\n> + include_directories : [test_includes_internal,\n> '../../../src/ipa/rkisp1/'])\n> \n> test(test['name'], exe, suite : 'ipa')\n> \n> base-commit: f3caea0ff7e63b529c9464f911162aa457e9b858\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2ACAEBD87C\n\tfor ;\n\tTue, 11 Jun 2024 13:22:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47C2365456;\n\tTue, 11 Jun 2024 15:21:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B7EA61A26\n\tfor ;\n\tTue, 11 Jun 2024 15:21:57 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9E79C183;\n\tTue, 11 Jun 2024 15:21:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jMVla1hX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718112104;\n\tbh=mmx1iQVKyZ7lyTPDdjVFF5oKlwA0CuimqjPb3r5+BXQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=jMVla1hX1YB59uvZAaMz2B4SatgKRqAv2ZET2ueq1XT2Nbh4gWbVF9jWQFTZPP8mZ\n\tG+V30UR62ddA6UqKWc5UUxnooLUKWgqi6HV5mGnKnZjOCookpW+zL5XlBMXUec+Jr0\n\t4IIKmim8DWRh/rVg1oTUcHC8y5AdWPc5k4rLTWWc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240611124205.18093-1-laurent.pinchart@ideasonboard.com>","References":"<20240611124205.18093-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] meson: Group libipa and libipa_includes in a dependency\n\tobject","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 11 Jun 2024 14:21:53 +0100","Message-ID":"<171811211394.2248009.15505228145831127074@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29831,"web_url":"https://patchwork.libcamera.org/comment/29831/","msgid":"","date":"2024-06-11T13:35:30","subject":"Re: [PATCH] meson: Group libipa and libipa_includes in a dependency\n\tobject","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Tue, Jun 11, 2024 at 03:42:05PM +0300, Laurent Pinchart wrote:\n> Many build targets link with libipa and need libipa_includes. Group them\n> in a libipa_dep dependency object to simplify the users.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/ipu3/meson.build | 5 ++---\n> src/ipa/libipa/meson.build | 4 ++++\n> src/ipa/rkisp1/meson.build | 5 ++---\n> src/ipa/rpi/vc4/meson.build | 4 +---\n> src/ipa/simple/meson.build | 5 ++---\n> src/ipa/vimc/meson.build | 5 ++---\n> test/ipa/meson.build | 6 +++---\n> test/ipa/rkisp1/meson.build | 6 +++---\n> 8 files changed, 19 insertions(+), 21 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\n> index 66c398432d43..e76f97c07c87 100644\n> --- a/src/ipa/ipu3/meson.build\n> +++ b/src/ipa/ipu3/meson.build\n> @@ -15,9 +15,8 @@ ipu3_ipa_sources += ipu3_ipa_algorithms\n> mod = shared_module(ipa_name,\n> [ipu3_ipa_sources, libcamera_generated_ipa_headers],\n> name_prefix : '',\n> - include_directories : [ipa_includes, libipa_includes],\n> - dependencies : libcamera_private,\n> - link_with : libipa,\n> + include_directories : [ipa_includes],\n> + dependencies : [libcamera_private, libipa_dep],\n> install : true,\n> install_dir : ipa_install_dir)\n> \n> diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\n> index 8ec9c7847348..7f038c90cd87 100644\n> --- a/src/ipa/libipa/meson.build\n> +++ b/src/ipa/libipa/meson.build\n> @@ -27,3 +27,7 @@ libipa_includes = include_directories('..')\n> libipa = static_library('ipa', [libipa_sources, libipa_headers],\n> include_directories : ipa_includes,\n> dependencies : libcamera_private)\n> +\n> +libipa_dep = declare_dependency(sources : libipa_headers,\n> + include_directories : libipa_includes,\n> + link_with : libipa)\n> diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\n> index cf05cdb27943..e8b266f1ccca 100644\n> --- a/src/ipa/rkisp1/meson.build\n> +++ b/src/ipa/rkisp1/meson.build\n> @@ -16,9 +16,8 @@ rkisp1_ipa_sources += rkisp1_ipa_algorithms\n> mod = shared_module(ipa_name,\n> [rkisp1_ipa_sources, libcamera_generated_ipa_headers],\n> name_prefix : '',\n> - include_directories : [ipa_includes, libipa_includes],\n> - dependencies : libcamera_private,\n> - link_with : libipa,\n> + include_directories : [ipa_includes],\n> + dependencies : [libcamera_private, libipa_dep],\n> install : true,\n> install_dir : ipa_install_dir)\n> \n> diff --git a/src/ipa/rpi/vc4/meson.build b/src/ipa/rpi/vc4/meson.build\n> index 590e9197756d..63fc5925b06c 100644\n> --- a/src/ipa/rpi/vc4/meson.build\n> +++ b/src/ipa/rpi/vc4/meson.build\n> @@ -15,7 +15,6 @@ vc4_ipa_libs = [\n> \n> vc4_ipa_includes = [\n> ipa_includes,\n> - libipa_includes,\n> ]\n> \n> vc4_ipa_sources = files([\n> @@ -28,8 +27,7 @@ mod = shared_module(ipa_name,\n> [vc4_ipa_sources, libcamera_generated_ipa_headers],\n> name_prefix : '',\n> include_directories : vc4_ipa_includes,\n> - dependencies : vc4_ipa_deps,\n> - link_with : libipa,\n> + dependencies : [vc4_ipa_deps, libipa_dep],\n> link_whole : vc4_ipa_libs,\n> install : true,\n> install_dir : ipa_install_dir)\n> diff --git a/src/ipa/simple/meson.build b/src/ipa/simple/meson.build\n> index 44b5f1d70cd3..33d1c96aa4f2 100644\n> --- a/src/ipa/simple/meson.build\n> +++ b/src/ipa/simple/meson.build\n> @@ -10,9 +10,8 @@ soft_simple_sources = files([\n> mod = shared_module(ipa_name,\n> [soft_simple_sources, libcamera_generated_ipa_headers],\n> name_prefix : '',\n> - include_directories : [ipa_includes, libipa_includes],\n> - dependencies : libcamera_private,\n> - link_with : libipa,\n> + include_directories : [ipa_includes],\n> + dependencies : [libcamera_private, libipa_dep],\n> install : true,\n> install_dir : ipa_install_dir)\n> \n> diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build\n> index 264a2d9a8964..d0b63eddd5f6 100644\n> --- a/src/ipa/vimc/meson.build\n> +++ b/src/ipa/vimc/meson.build\n> @@ -5,9 +5,8 @@ ipa_name = 'ipa_vimc'\n> mod = shared_module(ipa_name,\n> ['vimc.cpp', libcamera_generated_ipa_headers],\n> name_prefix : '',\n> - include_directories : [ipa_includes, libipa_includes],\n> - dependencies : libcamera_private,\n> - link_with : libipa,\n> + include_directories : [ipa_includes],\n> + dependencies : [libcamera_private, libipa_dep],\n> install : true,\n> install_dir : ipa_install_dir)\n> \n> diff --git a/test/ipa/meson.build b/test/ipa/meson.build\n> index dc956284c4b1..fe21ca58b64f 100644\n> --- a/test/ipa/meson.build\n> +++ b/test/ipa/meson.build\n> @@ -9,9 +9,9 @@ ipa_test = [\n> \n> foreach test : ipa_test\n> exe = executable(test['name'], test['sources'], libcamera_generated_ipa_headers,\n> - dependencies : libcamera_private,\n> - link_with : [libipa, test_libraries],\n> - include_directories : [libipa_includes, test_includes_internal])\n> + dependencies : [libcamera_private, libipa_dep],\n> + link_with : [test_libraries],\n> + include_directories : [test_includes_internal])\n> \n> test(test['name'], exe, suite : 'ipa')\n> endforeach\n> diff --git a/test/ipa/rkisp1/meson.build b/test/ipa/rkisp1/meson.build\n> index 5ffc5dd607b6..5b08e2939ce6 100644\n> --- a/test/ipa/rkisp1/meson.build\n> +++ b/test/ipa/rkisp1/meson.build\n> @@ -6,9 +6,9 @@ rkisp1_ipa_test = [\n> \n> foreach test : rkisp1_ipa_test\n> exe = executable(test['name'], test['sources'], libcamera_generated_ipa_headers,\n> - dependencies : libcamera_private,\n> - link_with : [libipa, test_libraries],\n> - include_directories : [libipa_includes, test_includes_internal,\n> + dependencies : [libcamera_private, libipa_dep],\n> + link_with : [test_libraries],\n> + include_directories : [test_includes_internal,\n> '../../../src/ipa/rkisp1/'])\n> \n> test(test['name'], exe, suite : 'ipa')\n> \n> base-commit: f3caea0ff7e63b529c9464f911162aa457e9b858\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55FD7BD87C\n\tfor ;\n\tTue, 11 Jun 2024 13:35:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 26EC265463;\n\tTue, 11 Jun 2024 15:35:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2458265455\n\tfor ;\n\tTue, 11 Jun 2024 15:35:41 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4C1A8183;\n\tTue, 11 Jun 2024 15:35:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TiWsIDMh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718112928;\n\tbh=afEThyoPVSlHKLUosIts6rrjwm1nA2q69BVJU2ZpQEc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TiWsIDMhVuIb/8KaQXS0p7nhbKIwqEsfokwSF0XiW2yd01DeL+qHSFDn0Lh1NVIrY\n\tE44TAtxqg2BTcDOviSIlnl0OGTIe1JhWdNDFNKxnbOZleUhLG1r8jbQDnjisy0IUl2\n\tDotr7YWX2K8AGws+e3M1WMJGW0ycaIyYtAywykXc=","Date":"Tue, 11 Jun 2024 22:35:30 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] meson: Group libipa and libipa_includes in a dependency\n\tobject","Message-ID":"","References":"<20240611124205.18093-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240611124205.18093-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29832,"web_url":"https://patchwork.libcamera.org/comment/29832/","msgid":"<4xTGoJJvVQLBIJdsCCo1sdtwOhs8ivAxVc9jMJ802oVyQaKGXoZuXnzVQs0A3YGjc1GCAhKIX0T2KwLF7woimvPghFOimZEzF5jHW9FC2fk=@protonmail.com>","date":"2024-06-11T13:40:55","subject":"Re: [PATCH] meson: Group libipa and libipa_includes in a dependency\n\tobject","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"Hi\n\n\n2024. június 11., kedd 14:42 keltezéssel, Laurent Pinchart írta:\n\n> Many build targets link with libipa and need libipa_includes. Group them\n> in a libipa_dep dependency object to simplify the users.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/ipu3/meson.build | 5 ++---\n> src/ipa/libipa/meson.build | 4 ++++\n> src/ipa/rkisp1/meson.build | 5 ++---\n> src/ipa/rpi/vc4/meson.build | 4 +---\n> src/ipa/simple/meson.build | 5 ++---\n> src/ipa/vimc/meson.build | 5 ++---\n> test/ipa/meson.build | 6 +++---\n> test/ipa/rkisp1/meson.build | 6 +++---\n> 8 files changed, 19 insertions(+), 21 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\n> index 66c398432d43..e76f97c07c87 100644\n> --- a/src/ipa/ipu3/meson.build\n> +++ b/src/ipa/ipu3/meson.build\n> @@ -15,9 +15,8 @@ ipu3_ipa_sources += ipu3_ipa_algorithms\n> mod = shared_module(ipa_name,\n> [ipu3_ipa_sources, libcamera_generated_ipa_headers],\n> name_prefix : '',\n> - include_directories : [ipa_includes, libipa_includes],\n> - dependencies : libcamera_private,\n> - link_with : libipa,\n> + include_directories : [ipa_includes],\n> + dependencies : [libcamera_private, libipa_dep],\n> install : true,\n> install_dir : ipa_install_dir)\n> \n> diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\n> index 8ec9c7847348..7f038c90cd87 100644\n> --- a/src/ipa/libipa/meson.build\n> +++ b/src/ipa/libipa/meson.build\n> @@ -27,3 +27,7 @@ libipa_includes = include_directories('..')\n> libipa = static_library('ipa', [libipa_sources, libipa_headers],\n> include_directories : ipa_includes,\n> dependencies : libcamera_private)\n> +\n> +libipa_dep = declare_dependency(sources : libipa_headers,\n\nIs this `sources` argument necessary?\n\n\nRegards,\nBarnabás Pőcze\n\n\n> + include_directories : libipa_includes,\n> + link_with : libipa)\n> [...]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B6F2C31E9\n\tfor ;\n\tTue, 11 Jun 2024 13:41:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 77B6E65456;\n\tTue, 11 Jun 2024 15:41:00 +0200 (CEST)","from mail-4322.protonmail.ch (mail-4322.protonmail.ch\n\t[185.70.43.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A097661A26\n\tfor ;\n\tTue, 11 Jun 2024 15:40:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"QZrpxu/b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1718113257; x=1718372457;\n\tbh=VnKwJKRs7iRQnx3avV7YqJwyag0UDWHK0VwD67dyDj0=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=QZrpxu/bhNsDuUXpO5QMw19WdQFnYuR294ifdCgkrUw+BortmZN9ya2RGe3TPSWkV\n\tuRZlAdKn7lRtNuu0NNZZybP+JMbhshmzew9A9Cg5x6bwY2RlTtxaMw10jF3l1oz3ak\n\teaIkV1QxOzNCzoivWeuKpM3ZUmSAO6PGPK4T0XGALUe7zBkB+nTRSo3Fm0BCpAnbV+\n\tzh7zlSAXLIYvs9giqU3ouCff/BJxkhMGJkkR0xR+N/M7sHmFVgW5NxOcx0dUtIITUB\n\tgGOpi8gYEZkU6vg2x/Iavm8oyjgCLOc4c9dROsFuu8lYM1yMiOgScmJrSQhvO7S1Xs\n\tipHQgrGRwsZ0A==","Date":"Tue, 11 Jun 2024 13:40:55 +0000","To":"Laurent Pinchart ","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] meson: Group libipa and libipa_includes in a dependency\n\tobject","Message-ID":"<4xTGoJJvVQLBIJdsCCo1sdtwOhs8ivAxVc9jMJ802oVyQaKGXoZuXnzVQs0A3YGjc1GCAhKIX0T2KwLF7woimvPghFOimZEzF5jHW9FC2fk=@protonmail.com>","In-Reply-To":"<20240611124205.18093-1-laurent.pinchart@ideasonboard.com>","References":"<20240611124205.18093-1-laurent.pinchart@ideasonboard.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"1d2516e7033337e1d320e5f85926f9ceb71187e0","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29836,"web_url":"https://patchwork.libcamera.org/comment/29836/","msgid":"<20240611142528.GA10397@pendragon.ideasonboard.com>","date":"2024-06-11T14:25:28","subject":"Re: [PATCH] meson: Group libipa and libipa_includes in a dependency\n\tobject","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jun 11, 2024 at 01:40:55PM +0000, Barnabás Pőcze wrote:\n> 2024. június 11., kedd 14:42 keltezéssel, Laurent Pinchart írta:\n> \n> > Many build targets link with libipa and need libipa_includes. Group them\n> > in a libipa_dep dependency object to simplify the users.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/ipa/ipu3/meson.build | 5 ++---\n> > src/ipa/libipa/meson.build | 4 ++++\n> > src/ipa/rkisp1/meson.build | 5 ++---\n> > src/ipa/rpi/vc4/meson.build | 4 +---\n> > src/ipa/simple/meson.build | 5 ++---\n> > src/ipa/vimc/meson.build | 5 ++---\n> > test/ipa/meson.build | 6 +++---\n> > test/ipa/rkisp1/meson.build | 6 +++---\n> > 8 files changed, 19 insertions(+), 21 deletions(-)\n> > \n> > diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\n> > index 66c398432d43..e76f97c07c87 100644\n> > --- a/src/ipa/ipu3/meson.build\n> > +++ b/src/ipa/ipu3/meson.build\n> > @@ -15,9 +15,8 @@ ipu3_ipa_sources += ipu3_ipa_algorithms\n> > mod = shared_module(ipa_name,\n> > [ipu3_ipa_sources, libcamera_generated_ipa_headers],\n> > name_prefix : '',\n> > - include_directories : [ipa_includes, libipa_includes],\n> > - dependencies : libcamera_private,\n> > - link_with : libipa,\n> > + include_directories : [ipa_includes],\n> > + dependencies : [libcamera_private, libipa_dep],\n> > install : true,\n> > install_dir : ipa_install_dir)\n> > \n> > diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\n> > index 8ec9c7847348..7f038c90cd87 100644\n> > --- a/src/ipa/libipa/meson.build\n> > +++ b/src/ipa/libipa/meson.build\n> > @@ -27,3 +27,7 @@ libipa_includes = include_directories('..')\n> > libipa = static_library('ipa', [libipa_sources, libipa_headers],\n> > include_directories : ipa_includes,\n> > dependencies : libcamera_private)\n> > +\n> > +libipa_dep = declare_dependency(sources : libipa_headers,\n> \n> Is this `sources` argument necessary?\n\nProbably not, as we don't generate any of those headers. They shouldn't\nhurt though, as the dependency on sources and headers is already there\nimplicitly, through 'link_with: libipa'. Should I drop the sources here\nor keep them to be ready for code generation in the future ? :-)\n\n> > + include_directories : libipa_includes,\n> > + link_with : libipa)\n> > [...]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C62AC31E9\n\tfor ;\n\tTue, 11 Jun 2024 14:25:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A9E465463;\n\tTue, 11 Jun 2024 16:25:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9241761A26\n\tfor ;\n\tTue, 11 Jun 2024 16:25:48 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9E49F29A;\n\tTue, 11 Jun 2024 16:25:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lNAtx5Ry\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718115935;\n\tbh=jJhU5oBtqKKPEkOk33Umhj/+dGGqcsJnpvUtH1dw38U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lNAtx5RyyohhE0V63K9HZHt2MQ5wrbEA+VsY+QZfDasA2uWR99+plrWPDpvhr1EZg\n\tSdtjqtw+EPu/DYHQYg2bd9GqhcsB1me5nAj0msLTNxKgjJfWFcokt4UFIdj0xeKvww\n\tKJcrwFmNfxWG/ZrvWQyn8Ca3el7PZMHu2TWptBYY=","Date":"Tue, 11 Jun 2024 17:25:28 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] meson: Group libipa and libipa_includes in a dependency\n\tobject","Message-ID":"<20240611142528.GA10397@pendragon.ideasonboard.com>","References":"<20240611124205.18093-1-laurent.pinchart@ideasonboard.com>\n\t<4xTGoJJvVQLBIJdsCCo1sdtwOhs8ivAxVc9jMJ802oVyQaKGXoZuXnzVQs0A3YGjc1GCAhKIX0T2KwLF7woimvPghFOimZEzF5jHW9FC2fk=@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<4xTGoJJvVQLBIJdsCCo1sdtwOhs8ivAxVc9jMJ802oVyQaKGXoZuXnzVQs0A3YGjc1GCAhKIX0T2KwLF7woimvPghFOimZEzF5jHW9FC2fk=@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29844,"web_url":"https://patchwork.libcamera.org/comment/29844/","msgid":"","date":"2024-06-11T21:24:16","subject":"Re: [PATCH] meson: Group libipa and libipa_includes in a dependency\n\tobject","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"2024. június 11., kedd 16:25 keltezéssel, Laurent Pinchart írta:\n\n> On Tue, Jun 11, 2024 at 01:40:55PM +0000, Barnabás Pőcze wrote:\n> > 2024. június 11., kedd 14:42 keltezéssel, Laurent Pinchart írta:\n> >\n> > > Many build targets link with libipa and need libipa_includes. Group them\n> > > in a libipa_dep dependency object to simplify the users.\n> > >\n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > src/ipa/ipu3/meson.build | 5 ++---\n> > > src/ipa/libipa/meson.build | 4 ++++\n> > > src/ipa/rkisp1/meson.build | 5 ++---\n> > > src/ipa/rpi/vc4/meson.build | 4 +---\n> > > src/ipa/simple/meson.build | 5 ++---\n> > > src/ipa/vimc/meson.build | 5 ++---\n> > > test/ipa/meson.build | 6 +++---\n> > > test/ipa/rkisp1/meson.build | 6 +++---\n> > > 8 files changed, 19 insertions(+), 21 deletions(-)\n> > >\n> > > diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\n> > > index 66c398432d43..e76f97c07c87 100644\n> > > --- a/src/ipa/ipu3/meson.build\n> > > +++ b/src/ipa/ipu3/meson.build\n> > > @@ -15,9 +15,8 @@ ipu3_ipa_sources += ipu3_ipa_algorithms\n> > > mod = shared_module(ipa_name,\n> > > [ipu3_ipa_sources, libcamera_generated_ipa_headers],\n> > > name_prefix : '',\n> > > - include_directories : [ipa_includes, libipa_includes],\n> > > - dependencies : libcamera_private,\n> > > - link_with : libipa,\n> > > + include_directories : [ipa_includes],\n> > > + dependencies : [libcamera_private, libipa_dep],\n> > > install : true,\n> > > install_dir : ipa_install_dir)\n> > >\n> > > diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\n> > > index 8ec9c7847348..7f038c90cd87 100644\n> > > --- a/src/ipa/libipa/meson.build\n> > > +++ b/src/ipa/libipa/meson.build\n> > > @@ -27,3 +27,7 @@ libipa_includes = include_directories('..')\n> > > libipa = static_library('ipa', [libipa_sources, libipa_headers],\n> > > include_directories : ipa_includes,\n> > > dependencies : libcamera_private)\n> > > +\n> > > +libipa_dep = declare_dependency(sources : libipa_headers,\n> >\n> > Is this `sources` argument necessary?\n> \n> Probably not, as we don't generate any of those headers. They shouldn't\n> hurt though, as the dependency on sources and headers is already there\n> implicitly, through 'link_with: libipa'. Should I drop the sources here\n> or keep them to be ready for code generation in the future ? :-)\n\nIt was just unexpected for me to see it because I hadn't seen anything that\nwould necessitate it, so I would omit it. But as you said, it does not change anything now.\n\n\nRegards,\nBarnabás Pőcze\n\n> \n> > > + include_directories : libipa_includes,\n> > > + link_with : libipa)\n> > > [...]\n> \n> --\n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E922BD87C\n\tfor ;\n\tTue, 11 Jun 2024 21:24:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA00E65461;\n\tTue, 11 Jun 2024 23:24:23 +0200 (CEST)","from mail-43167.protonmail.ch (mail-43167.protonmail.ch\n\t[185.70.43.167])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DABE461A26\n\tfor ;\n\tTue, 11 Jun 2024 23:24:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"BNNw1Jug\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1718141061; x=1718400261;\n\tbh=RD4e3bcuOVeAAbIbL3JrNgti7yOw17APRODUXW6C60g=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=BNNw1JugpwRM4wJrmNH9lGgw0VV46J3cqhHmMKRgGnKxEyapplzGFGulPs7QToz0m\n\tBfm6xc7vylhXISJfUPfwj3UbLoCgh3toCsTNZj4whdDBJ/S0+gtJ6Qie189TIVf8rt\n\teywIz7BecYIdv7N017CQTiZzykP9k+CqWiTvoAEVEKvWEn7YDYjtxvC2vluKXWM/jm\n\t5kdBLXfomDmrYR2K9E3aBQ4U1xt1VjfkqEnmDrjZvLIiuMIdYzkfezo5gxQ0v8mDEa\n\tG/8bw6LUl2GqNv2aJ6IVyHIn2o7at6ZDS6nW/CkZEv2Vc6AazvA+sXYIAPIs4O2+aA\n\teeg0XV9IF879Q==","Date":"Tue, 11 Jun 2024 21:24:16 +0000","To":"Laurent Pinchart ","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] meson: Group libipa and libipa_includes in a dependency\n\tobject","Message-ID":"","In-Reply-To":"<20240611142528.GA10397@pendragon.ideasonboard.com>","References":"<20240611124205.18093-1-laurent.pinchart@ideasonboard.com>\n\t<4xTGoJJvVQLBIJdsCCo1sdtwOhs8ivAxVc9jMJ802oVyQaKGXoZuXnzVQs0A3YGjc1GCAhKIX0T2KwLF7woimvPghFOimZEzF5jHW9FC2fk=@protonmail.com>\n\t<20240611142528.GA10397@pendragon.ideasonboard.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"21562b3f4e6bdfc1e191684cd435a91adef5540e","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29845,"web_url":"https://patchwork.libcamera.org/comment/29845/","msgid":"","date":"2024-06-11T21:28:52","subject":"Re: [PATCH] meson: Group libipa and libipa_includes in a dependency\n\tobject","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"2024. június 11., kedd 23:24 keltezéssel, Barnabás Pőcze írta:\n\n> 2024. június 11., kedd 16:25 keltezéssel, Laurent Pinchart írta:\n> \n> > On Tue, Jun 11, 2024 at 01:40:55PM +0000, Barnabás Pőcze wrote:\n> > > 2024. június 11., kedd 14:42 keltezéssel, Laurent Pinchart írta:\n> > >\n> > > > Many build targets link with libipa and need libipa_includes. Group them\n> > > > in a libipa_dep dependency object to simplify the users.\n> > > >\n> > > > Signed-off-by: Laurent Pinchart \n> > > > [...]\n> > > > diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\n> > > > index 8ec9c7847348..7f038c90cd87 100644\n> > > > --- a/src/ipa/libipa/meson.build\n> > > > +++ b/src/ipa/libipa/meson.build\n> > > > @@ -27,3 +27,7 @@ libipa_includes = include_directories('..')\n> > > > libipa = static_library('ipa', [libipa_sources, libipa_headers],\n> > > > include_directories : ipa_includes,\n> > > > dependencies : libcamera_private)\n> > > > +\n> > > > +libipa_dep = declare_dependency(sources : libipa_headers,\n> > >\n> > > Is this `sources` argument necessary?\n> >\n> > Probably not, as we don't generate any of those headers. They shouldn't\n> > hurt though, as the dependency on sources and headers is already there\n> > implicitly, through 'link_with: libipa'. Should I drop the sources here\n> > or keep them to be ready for code generation in the future ? :-)\n> \n> It was just unexpected for me to see it because I hadn't seen anything that\n> would necessitate it, so I would omit it. But as you said, it does not change anything now.\n> [...]\n\nOops, never mind, I haven't noticed this change had already been merged.\n\n\nRegards,\nBarnabás Pőcze","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E41CCC3237\n\tfor ;\n\tTue, 11 Jun 2024 21:29:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E471E65463;\n\tTue, 11 Jun 2024 23:29:01 +0200 (CEST)","from mail-40141.protonmail.ch (mail-40141.protonmail.ch\n\t[185.70.40.141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C7FA65446\n\tfor ;\n\tTue, 11 Jun 2024 23:29:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"UNsIqXPv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1718141338; x=1718400538;\n\tbh=BBjprb+IegqfNCZOUA9wbRJYWioQiyhVcJbKq48c87A=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=UNsIqXPvP/3+vJzDbxGGPuc2QH52kDGcpJ8I0eh5toqOWG5juzkscXYwl+w3mRaJb\n\tjmUWMLzq9xp73IrSC/O8mkTjMQ7GDg5kcvXSuhqNG3p7fKYIFL3vefN+upMO9mnTjs\n\ta6+uMTsF1b/UFh1kINcDl67ueEwAtzJNhq9WEO56Cmn4PNKoSKosruuMZaeQjR/Hjw\n\t/QL4ZkXqolxeI5QoG02s/T6bLY8FyjBu1UBgsN/djegwdWsAa6lPTLMM4qVce/GIV9\n\t6120+HBgWf0wKrrsmjCA25p80maRSorxrQ0dQy0kZz31YCT46KCbBCkxBYHNZ2rfRO\n\tFYEPUqvXTbZrw==","Date":"Tue, 11 Jun 2024 21:28:52 +0000","To":"Laurent Pinchart ","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] meson: Group libipa and libipa_includes in a dependency\n\tobject","Message-ID":"","In-Reply-To":"","References":"<20240611124205.18093-1-laurent.pinchart@ideasonboard.com>\n\t<4xTGoJJvVQLBIJdsCCo1sdtwOhs8ivAxVc9jMJ802oVyQaKGXoZuXnzVQs0A3YGjc1GCAhKIX0T2KwLF7woimvPghFOimZEzF5jHW9FC2fk=@protonmail.com>\n\t<20240611142528.GA10397@pendragon.ideasonboard.com>\n\t","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"505045cde2610b85c8041b0ddb7be5df3b138302","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29846,"web_url":"https://patchwork.libcamera.org/comment/29846/","msgid":"<20240611213030.GI10397@pendragon.ideasonboard.com>","date":"2024-06-11T21:30:30","subject":"Re: [PATCH] meson: Group libipa and libipa_includes in a dependency\n\tobject","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jun 11, 2024 at 09:28:52PM +0000, Barnabás Pőcze wrote:\n> 2024. június 11., kedd 23:24 keltezéssel, Barnabás Pőcze írta:\n> \n> > 2024. június 11., kedd 16:25 keltezéssel, Laurent Pinchart írta:\n> > \n> > > On Tue, Jun 11, 2024 at 01:40:55PM +0000, Barnabás Pőcze wrote:\n> > > > 2024. június 11., kedd 14:42 keltezéssel, Laurent Pinchart írta:\n> > > >\n> > > > > Many build targets link with libipa and need libipa_includes. Group them\n> > > > > in a libipa_dep dependency object to simplify the users.\n> > > > >\n> > > > > Signed-off-by: Laurent Pinchart \n> > > > > [...]\n> > > > > diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\n> > > > > index 8ec9c7847348..7f038c90cd87 100644\n> > > > > --- a/src/ipa/libipa/meson.build\n> > > > > +++ b/src/ipa/libipa/meson.build\n> > > > > @@ -27,3 +27,7 @@ libipa_includes = include_directories('..')\n> > > > > libipa = static_library('ipa', [libipa_sources, libipa_headers],\n> > > > > include_directories : ipa_includes,\n> > > > > dependencies : libcamera_private)\n> > > > > +\n> > > > > +libipa_dep = declare_dependency(sources : libipa_headers,\n> > > >\n> > > > Is this `sources` argument necessary?\n> > >\n> > > Probably not, as we don't generate any of those headers. They shouldn't\n> > > hurt though, as the dependency on sources and headers is already there\n> > > implicitly, through 'link_with: libipa'. Should I drop the sources here\n> > > or keep them to be ready for code generation in the future ? :-)\n> > \n> > It was just unexpected for me to see it because I hadn't seen anything that\n> > would necessitate it, so I would omit it. But as you said, it does not change anything now.\n> > [...]\n> \n> Oops, never mind, I haven't noticed this change had already been merged.\n\nI can still send a fix on top :-) Your reviews are appreciated, even\nafter patches get merged.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAED5C3237\n\tfor ;\n\tTue, 11 Jun 2024 21:30:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CFE7A61A26;\n\tTue, 11 Jun 2024 23:30:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9876165446\n\tfor ;\n\tTue, 11 Jun 2024 23:30:50 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 828EC512;\n\tTue, 11 Jun 2024 23:30:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vEJ8jpam\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718141437;\n\tbh=r6bJFYnbHg+04agNhXzQ4plLHaRzJJGPMSqgT3w51bE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vEJ8jpamNXnohcfZkYY1XzA0EJF62TnhNNkrDpJei/JoaApxyVaDO29+7RZAIz0ri\n\tl1dK5mlRfZD5PWhzMgFlTP1lp7NY8t4CsA4ieA4nWbLjpwU4s1Z5Sd/vyI+tTEeaNX\n\trOwqZ2M/5lWoNg3h2Ut3VseEiu/gC5F9RtcK8b5U=","Date":"Wed, 12 Jun 2024 00:30:30 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] meson: Group libipa and libipa_includes in a dependency\n\tobject","Message-ID":"<20240611213030.GI10397@pendragon.ideasonboard.com>","References":"<20240611124205.18093-1-laurent.pinchart@ideasonboard.com>\n\t<4xTGoJJvVQLBIJdsCCo1sdtwOhs8ivAxVc9jMJ802oVyQaKGXoZuXnzVQs0A3YGjc1GCAhKIX0T2KwLF7woimvPghFOimZEzF5jHW9FC2fk=@protonmail.com>\n\t<20240611142528.GA10397@pendragon.ideasonboard.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]