[{"id":29818,"web_url":"https://patchwork.libcamera.org/comment/29818/","msgid":"<20240610185712.GL26663@pendragon.ideasonboard.com>","date":"2024-06-10T18:57:12","subject":"Re: [PATCH 2/2] libcamera: software_isp: Fix includes ordering in\n\tsimple.cpp","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Jun 10, 2024 at 08:08:50PM +0200, Milan Zamazal wrote:\n> Let's make it conforming to the defined clang-format.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index db3575c3..eb36578e 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -13,8 +13,8 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -38,7 +38,6 @@\n> #include \"libcamera/internal/v4l2_subdevice.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n> \n> -\n> namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(SimplePipeline)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83ED2BD87C\n\tfor ;\n\tMon, 10 Jun 2024 18:57:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 302756545E;\n\tMon, 10 Jun 2024 20:57:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9FC4E634D5\n\tfor ;\n\tMon, 10 Jun 2024 20:57:31 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 73646397;\n\tMon, 10 Jun 2024 20:57:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AlLsrfSn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718045839;\n\tbh=5JLD6/aawsCkqTJYbNrNRKy7yqKMbM4Ez1pksByS9wQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AlLsrfSntN/uqhYbolXYgTnbIQBQ04am1doya1ccEIkwb4JFVGc3fAZaiaCx0ame1\n\tbjhE8aSwqsE3TBcOsqkfm5FdQsKVVx7Jdq9mLeEB45T2OTXYegHV45czkbMJn+euRI\n\tjHKGwqzFe1C/5b8pEpvQuQyMiyszaH8+lvaRtGak=","Date":"Mon, 10 Jun 2024 21:57:12 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] libcamera: software_isp: Fix includes ordering in\n\tsimple.cpp","Message-ID":"<20240610185712.GL26663@pendragon.ideasonboard.com>","References":"<20240610180855.1643125-1-mzamazal@redhat.com>\n\t<20240610180855.1643125-3-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240610180855.1643125-3-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29829,"web_url":"https://patchwork.libcamera.org/comment/29829/","msgid":"<171810742240.2248009.5036473504108822927@ping.linuxembedded.co.uk>","date":"2024-06-11T12:03:42","subject":"Re: [PATCH 2/2] libcamera: software_isp: Fix includes ordering in\n\tsimple.cpp","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-06-10 19:08:50)\n> Let's make it conforming to the defined clang-format.\n> \n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Milan Zamazal \n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index db3575c3..eb36578e 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -13,8 +13,8 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -38,7 +38,6 @@\n> #include \"libcamera/internal/v4l2_subdevice.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n> \n> -\n> namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(SimplePipeline)\n> -- \n> 2.44.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AFCDABD87C\n\tfor ;\n\tTue, 11 Jun 2024 12:03:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B6AB65463;\n\tTue, 11 Jun 2024 14:03:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3124265446\n\tfor ;\n\tTue, 11 Jun 2024 14:03:45 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B2787E0;\n\tTue, 11 Jun 2024 14:03:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Welwli8S\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718107412;\n\tbh=jCp8n9tuqDwd+Tirb3Ng7N/MlTPlMqiqjQQadyYWfa0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Welwli8S88Dz3NgOKfgIYXYr7dRyhH0UMweBOONAvM+/MQ1Zpdw812XewxICIF0dV\n\tSblBP+OZ/PseTa823X6znNyQ1K1z6dxj6dW8mM/h3tHox+mwcGQne/KblciqRTgKzD\n\tKuKOvokHSVJ8il/j9+fFisv9/PLlYgSZAXncOjF0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240610180855.1643125-3-mzamazal@redhat.com>","References":"<20240610180855.1643125-1-mzamazal@redhat.com>\n\t<20240610180855.1643125-3-mzamazal@redhat.com>","Subject":"Re: [PATCH 2/2] libcamera: software_isp: Fix includes ordering in\n\tsimple.cpp","From":"Kieran Bingham ","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Tue, 11 Jun 2024 13:03:42 +0100","Message-ID":"<171810742240.2248009.5036473504108822927@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]