{"id":20252,"url":"https://patchwork.libcamera.org/api/patches/20252/?format=json","web_url":"https://patchwork.libcamera.org/patch/20252/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240610180855.1643125-3-mzamazal@redhat.com>","date":"2024-06-10T18:08:50","name":"[2/2] libcamera: software_isp: Fix includes ordering in simple.cpp","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"646dd1a2bef36bb05336745fb032a6fb1b6c52dd","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20252/mbox/","series":[{"id":4379,"url":"https://patchwork.libcamera.org/api/series/4379/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4379","date":"2024-06-10T18:08:48","name":"Includes ordering fix","version":1,"mbox":"https://patchwork.libcamera.org/series/4379/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20252/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20252/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C416AC3292\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 10 Jun 2024 18:09:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6341365468;\n\tMon, 10 Jun 2024 20:09:29 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B31165461\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Jun 2024 20:09:27 +0200 (CEST)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-443-hlw9IH4qOwOJpPR1SKhvFw-1;\n\tMon, 10 Jun 2024 14:09:23 -0400","from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id F271519560B8; Mon, 10 Jun 2024 18:09:21 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.224.30])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 1F2251956089; Mon, 10 Jun 2024 18:09:19 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Uw95X7vb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1718042966;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=DqF5PBGW9c10qqSv+aqKnU6COleiHDABaQ4NoOG9qi8=;\n\tb=Uw95X7vbakI/+Mjxdka5ZHoxihAgDII/fXOIVMvWTpJYg7FmxIJMrTBiIHlvfYcB2fj5N3\n\thz6CZJDitbLDJSCxlBmzzsLnvviyS0QnbcVLPEs1LNpDcpJ1pqEkT/dTb3xtNIW9WDnia6\n\tt0G7Vfk24DNi6F0C+iSsuLrBEQrE1hs=","X-MC-Unique":"hlw9IH4qOwOJpPR1SKhvFw-1","From":"Milan Zamazal <mzamazal@redhat.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>","Subject":"[PATCH 2/2] libcamera: software_isp: Fix includes ordering in\n\tsimple.cpp","Date":"Mon, 10 Jun 2024 20:08:50 +0200","Message-ID":"<20240610180855.1643125-3-mzamazal@redhat.com>","In-Reply-To":"<20240610180855.1643125-1-mzamazal@redhat.com>","References":"<20240610180855.1643125-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.15","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Let's make it conforming to the defined clang-format.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex db3575c3..eb36578e 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -13,8 +13,8 @@\n #include <memory>\n #include <queue>\n #include <set>\n-#include <string>\n #include <string.h>\n+#include <string>\n #include <unordered_map>\n #include <utility>\n #include <vector>\n@@ -38,7 +38,6 @@\n #include \"libcamera/internal/v4l2_subdevice.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n \n-\n namespace libcamera {\n \n LOG_DEFINE_CATEGORY(SimplePipeline)\n","prefixes":["2/2"]}