[{"id":29817,"web_url":"https://patchwork.libcamera.org/comment/29817/","msgid":"<20240610185640.GK26663@pendragon.ideasonboard.com>","date":"2024-06-10T18:56:40","subject":"Re: [PATCH 1/2] clang-format: Make Qt includes matching case\n\tsensitive","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Jun 10, 2024 at 08:08:49PM +0200, Milan Zamazal wrote:\n> This fixes the problem that includes like\n> \n>   #include <queue>\n> \n> are put near the end.\n> \n> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>\n> ---\n>  .clang-format | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/.clang-format b/.clang-format\n> index cac7029f..b48d4e1e 100644\n> --- a/.clang-format\n> +++ b/.clang-format\n> @@ -75,6 +75,7 @@ IncludeCategories:\n>      Priority:        9\n>    # Qt includes (match before C++ standard library)\n>    - Regex:           '<Q([A-Za-z0-9\\-_])+>'\n> +    CaseSensitive:   true\n\nThis option is available in clang-format 12 and later. There are no\ndistribution versions we specifically care about that ship a too old\nclang-formation version (Debian buster ships 11 by default but has a\nclang-format-13 package), so this is fine. We should however update the\ncomment at the beginning of the file to indicate this. I can handle it\nwhen applying this patch.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nBy the way, see commit d1cdaeb6f078677d5bf46cb596102bfe8da070b9 :-)\n\n>      Priority:        9\n>    # Headers in <> with an extension. (+system libraries)\n>    - Regex:           '<([A-Za-z0-9\\-_])+\\.h>'","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80EC8BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 10 Jun 2024 18:57:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 88FB465462;\n\tMon, 10 Jun 2024 20:57:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51B5C634D5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Jun 2024 20:57:00 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF02A397;\n\tMon, 10 Jun 2024 20:56:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rXtGdfeq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718045808;\n\tbh=umIqfDcwqznVdBM+BQy6N3aa6FRBWPk2QAlZZ5alVMk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rXtGdfeq9WIEA1WA09kq6kE69Tmx+r/pEb3nhmPj3AF3+mr31sC8GNQVWFU8BCrnd\n\t8IhLngKs45dFoZAxSXYtwe1DMozuYOEwLccxcepeggsL+ludaP5t8/TUw7ikARooSS\n\t1s+4+F1iZhUui8e7FLT4gTsfmdQCTBuAWuLr6uwo=","Date":"Mon, 10 Jun 2024 21:56:40 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Milan Zamazal <mzamazal@redhat.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/2] clang-format: Make Qt includes matching case\n\tsensitive","Message-ID":"<20240610185640.GK26663@pendragon.ideasonboard.com>","References":"<20240610180855.1643125-1-mzamazal@redhat.com>\n\t<20240610180855.1643125-2-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240610180855.1643125-2-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":29819,"web_url":"https://patchwork.libcamera.org/comment/29819/","msgid":"<20240610190100.GM26663@pendragon.ideasonboard.com>","date":"2024-06-10T19:01:00","subject":"Re: [PATCH 1/2] clang-format: Make Qt includes matching case\n\tsensitive","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jun 10, 2024 at 09:56:42PM +0300, Laurent Pinchart wrote:\n> Hi Milan,\n> \n> Thank you for the patch.\n> \n> On Mon, Jun 10, 2024 at 08:08:49PM +0200, Milan Zamazal wrote:\n> > This fixes the problem that includes like\n\nI will also expand this to\n\n    Now that stable versions of all major distributions ship clang-format 12\n    or newer, we can use the CaseSensitive option for the Qt include\n    category. This fixes the problem that includes like\n\nto add more context.\n\n> > \n> >   #include <queue>\n> > \n> > are put near the end.\n> > \n> > Signed-off-by: Milan Zamazal <mzamazal@redhat.com>\n> > ---\n> >  .clang-format | 1 +\n> >  1 file changed, 1 insertion(+)\n> > \n> > diff --git a/.clang-format b/.clang-format\n> > index cac7029f..b48d4e1e 100644\n> > --- a/.clang-format\n> > +++ b/.clang-format\n> > @@ -75,6 +75,7 @@ IncludeCategories:\n> >      Priority:        9\n> >    # Qt includes (match before C++ standard library)\n> >    - Regex:           '<Q([A-Za-z0-9\\-_])+>'\n> > +    CaseSensitive:   true\n> \n> This option is available in clang-format 12 and later. There are no\n> distribution versions we specifically care about that ship a too old\n> clang-formation version (Debian buster ships 11 by default but has a\n> clang-format-13 package), so this is fine. We should however update the\n> comment at the beginning of the file to indicate this. I can handle it\n> when applying this patch.\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> By the way, see commit d1cdaeb6f078677d5bf46cb596102bfe8da070b9 :-)\n> \n> >      Priority:        9\n> >    # Headers in <> with an extension. (+system libraries)\n> >    - Regex:           '<([A-Za-z0-9\\-_])+\\.h>'","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47D7DC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 10 Jun 2024 19:01:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 13C9165467;\n\tMon, 10 Jun 2024 21:01:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2939C6545E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Jun 2024 21:01:20 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ACABB39F;\n\tMon, 10 Jun 2024 21:01:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PdZnQCvY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718046067;\n\tbh=jnEWvhEx8gTZPn9PRXqZbarQSrP8uIm27yzJIGDTRKs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PdZnQCvY38BVYJCIFUKkW5jqpT1yrhsEjhr4KPr5QEYSCOvLZ/w/vSc7t9KsTaK5i\n\tUFMNgmrZBcvbJx3vXlnZiPGdJWMyzltsMqhdjSdLJQjw4yDZfszI3Jr13e+wxs5uX9\n\tC5/eClcCxR7Gp7PfrUZH7b4Mom5qyx0nW8r4K6lU=","Date":"Mon, 10 Jun 2024 22:01:00 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Milan Zamazal <mzamazal@redhat.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/2] clang-format: Make Qt includes matching case\n\tsensitive","Message-ID":"<20240610190100.GM26663@pendragon.ideasonboard.com>","References":"<20240610180855.1643125-1-mzamazal@redhat.com>\n\t<20240610180855.1643125-2-mzamazal@redhat.com>\n\t<20240610185640.GK26663@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240610185640.GK26663@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":29823,"web_url":"https://patchwork.libcamera.org/comment/29823/","msgid":"<87h6dzexam.fsf@redhat.com>","date":"2024-06-11T07:46:57","subject":"Re: [PATCH 1/2] clang-format: Make Qt includes matching case\n\tsensitive","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Laurent,\n\nthank you for review.\n\nLaurent Pinchart <laurent.pinchart@ideasonboard.com> writes:\n\n> Hi Milan,\n>\n> Thank you for the patch.\n>\n> On Mon, Jun 10, 2024 at 08:08:49PM +0200, Milan Zamazal wrote:\n>> This fixes the problem that includes like\n>> \n>>   #include <queue>\n>> \n>> are put near the end.\n>> \n>> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>\n>> ---\n>>  .clang-format | 1 +\n>>  1 file changed, 1 insertion(+)\n>> \n>> diff --git a/.clang-format b/.clang-format\n>> index cac7029f..b48d4e1e 100644\n>> --- a/.clang-format\n>> +++ b/.clang-format\n>> @@ -75,6 +75,7 @@ IncludeCategories:\n>>      Priority:        9\n>>    # Qt includes (match before C++ standard library)\n>>    - Regex:           '<Q([A-Za-z0-9\\-_])+>'\n>> +    CaseSensitive:   true\n>\n> This option is available in clang-format 12 and later. There are no\n> distribution versions we specifically care about that ship a too old\n> clang-formation version (Debian buster ships 11 by default but has a\n> clang-format-13 package), so this is fine. We should however update the\n> comment at the beginning of the file to indicate this. I can handle it\n> when applying this patch.\n\nYes, please do.\n\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>\n> By the way, see commit d1cdaeb6f078677d5bf46cb596102bfe8da070b9 :-)\n\nI see, thanks for explanation.\n\n>>      Priority:        9\n>>    # Headers in <> with an extension. (+system libraries)\n>>    - Regex:           '<([A-Za-z0-9\\-_])+\\.h>'\n\n[...]\n\n>> On Mon, Jun 10, 2024 at 08:08:49PM +0200, Milan Zamazal wrote:\n>> > This fixes the problem that includes like\n>\n> I will also expand this to\n>\n>     Now that stable versions of all major distributions ship clang-format 12\n>     or newer, we can use the CaseSensitive option for the Qt include\n>     category. This fixes the problem that includes like\n>\n> to add more context.\n\nOK, thank you.\n\n>> > \n>> >   #include <queue>\n>> > \n>> > are put near the end.\n\n[...]","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04827C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 11 Jun 2024 07:47:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 068C265461;\n\tTue, 11 Jun 2024 09:47:06 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0CABF634D3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Jun 2024 09:47:03 +0200 (CEST)","from mail-wr1-f69.google.com (mail-wr1-f69.google.com\n\t[209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-577-aJixV1_GPzGWhbjUUE3E2Q-1; Tue, 11 Jun 2024 03:47:01 -0400","by mail-wr1-f69.google.com with SMTP id\n\tffacd0b85a97d-35f15fae680so832100f8f.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Jun 2024 00:47:00 -0700 (PDT)","from nuthatch (nat-pool-brq-t.redhat.com. [213.175.37.10])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-35f23a651d4sm4913383f8f.50.2024.06.11.00.46.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 11 Jun 2024 00:46:57 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"jLyxnIhU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1718092022;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=TDn9n9QTU1n3dyvnCpzz9ELKSByZBqXuNzGorQlhetk=;\n\tb=jLyxnIhUEqxH8uI4gTWFqJIe/Ub21cTdmyr1EFcjYQQojAb9gXoSxeFfC5PlwnP3uZfKw6\n\t0xHq955zvDsDhdoIoyz5XmCLYuD2otNFeANg1s5NNJ5pwfynh5U9zcxyEWmQwlcjUeNJLD\n\t/jU8gDsUOCw8lozwGYAAVHeAetM67ts=","X-MC-Unique":"aJixV1_GPzGWhbjUUE3E2Q-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1718092019; x=1718696819;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=TDn9n9QTU1n3dyvnCpzz9ELKSByZBqXuNzGorQlhetk=;\n\tb=fs4roserAcThF1irWfo2LAAo/s1NyAU2JimAUg6WnYu7su52dZJ4Y+R9iEM96R9i9X\n\tpHBuOpMRa/YqR+E4motS5Xx1rEZnYK4KEKTrQIf5ERjOPLhlaLflDN1TokQYRrPZ/12V\n\tx/7hsCtc/znfw/wZE+UmceNpyQTmtt31OyU+ImLeV5lSli2yY7ol05GGqCWlTMX9tLVC\n\tlUplW60Gg5MpweIj9zm3uOgJc1TIU36DE9TzqZKy+VpxVv5o3ezCQBSdPKp4ZzrlG3ei\n\tGXyn7U3rExJNBOI0j0I08tLPgb86WjX0mKjEMNa6Mh5V6WkYjqGQjz41W0rv48Dc0YHA\n\tJ2lg==","X-Gm-Message-State":"AOJu0YzeG9i6FsWcYbgjzy7RKPoS89uqwdWdK57/DPPTvk0glaabeB5m\n\td1KvQTUmk67VWQxyuQJ6R2flRzBgXuf8n4p+//YooUxBg5EvYr2Jc0496ertYYOVGJEhuU0+owW\n\tXMl6lRbencUtIOdXy253XmzWAbYc18WM0qa9xmSWhsufNpBDPomIkbqm9Wh3lA6FSgwO4NB4rmc\n\t4g3zWjwCetbilJzD0vdLlVz97Lh6AheX83LTTqPVdqBH37KgSvEGNU0QU=","X-Received":["by 2002:a05:6000:1786:b0:35f:23a2:8162 with SMTP id\n\tffacd0b85a97d-35f23a28204mr3890944f8f.25.1718092019029; \n\tTue, 11 Jun 2024 00:46:59 -0700 (PDT)","by 2002:a05:6000:1786:b0:35f:23a2:8162 with SMTP id\n\tffacd0b85a97d-35f23a28204mr3890928f8f.25.1718092018605; \n\tTue, 11 Jun 2024 00:46:58 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IFMtblpLG5auzUdQCEAab+PXovBRgz1t4xBpBqGMev5VOMNkPZVTSzdSpZCT4xaPuv9wxISMA==","From":"Milan Zamazal <mzamazal@redhat.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/2] clang-format: Make Qt includes matching case\n\tsensitive","In-Reply-To":"<20240610185640.GK26663@pendragon.ideasonboard.com> (Laurent\n\tPinchart's message of \"Mon, 10 Jun 2024 21:56:40 +0300\")","References":"<20240610180855.1643125-1-mzamazal@redhat.com>\n\t<20240610180855.1643125-2-mzamazal@redhat.com>\n\t<20240610185640.GK26663@pendragon.ideasonboard.com>","Date":"Tue, 11 Jun 2024 09:46:57 +0200","Message-ID":"<87h6dzexam.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":29828,"web_url":"https://patchwork.libcamera.org/comment/29828/","msgid":"<171810738738.2248009.14969350769859206287@ping.linuxembedded.co.uk>","date":"2024-06-11T12:03:07","subject":"Re: [PATCH 1/2] clang-format: Make Qt includes matching case\n\tsensitive","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-06-11 08:46:57)\n> Hi Laurent,\n> \n> thank you for review.\n> \n> Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:\n> \n> > Hi Milan,\n> >\n> > Thank you for the patch.\n> >\n> > On Mon, Jun 10, 2024 at 08:08:49PM +0200, Milan Zamazal wrote:\n> >> This fixes the problem that includes like\n> >> \n> >>   #include <queue>\n> >> \n> >> are put near the end.\n> >> \n> >> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>\n> >> ---\n> >>  .clang-format | 1 +\n> >>  1 file changed, 1 insertion(+)\n> >> \n> >> diff --git a/.clang-format b/.clang-format\n> >> index cac7029f..b48d4e1e 100644\n> >> --- a/.clang-format\n> >> +++ b/.clang-format\n> >> @@ -75,6 +75,7 @@ IncludeCategories:\n> >>      Priority:        9\n> >>    # Qt includes (match before C++ standard library)\n> >>    - Regex:           '<Q([A-Za-z0-9\\-_])+>'\n> >> +    CaseSensitive:   true\n> >\n> > This option is available in clang-format 12 and later. There are no\n> > distribution versions we specifically care about that ship a too old\n> > clang-formation version (Debian buster ships 11 by default but has a\n> > clang-format-13 package), so this is fine. We should however update the\n> > comment at the beginning of the file to indicate this. I can handle it\n> > when applying this patch.\n> \n> Yes, please do.\n> \n> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> >\n> > By the way, see commit d1cdaeb6f078677d5bf46cb596102bfe8da070b9 :-)\n> \n> I see, thanks for explanation.\n\nOh fantastic! I'm /very/ happy to see this reverted at last.\nI tried making a system that would detect what version of clang-format\nwas available on the system and switch the .clang-format file - but it\nwas horrendous and wasn't really feasible.\n\nJust moving to newer versions of clang-format is great from my\nperspective ;D\n\n\n> >>      Priority:        9\n> >>    # Headers in <> with an extension. (+system libraries)\n> >>    - Regex:           '<([A-Za-z0-9\\-_])+\\.h>'\n> \n> [...]\n> \n> >> On Mon, Jun 10, 2024 at 08:08:49PM +0200, Milan Zamazal wrote:\n> >> > This fixes the problem that includes like\n> >\n> > I will also expand this to\n> >\n> >     Now that stable versions of all major distributions ship clang-format 12\n> >     or newer, we can use the CaseSensitive option for the Qt include\n> >     category. This fixes the problem that includes like\n> >\n> > to add more context.\n> \n> OK, thank you.\n\nAll that sounds good to me.\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> \n> >> > \n> >> >   #include <queue>\n> >> > \n> >> > are put near the end.\n> \n> [...]\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 888A7C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 11 Jun 2024 12:03:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B429C65446;\n\tTue, 11 Jun 2024 14:03:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E84A61A26\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Jun 2024 14:03:10 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DFFDB7E0;\n\tTue, 11 Jun 2024 14:02:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dQIhIWHF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718107378;\n\tbh=Z4jbZhQGCFvfx0/3DtR2/TDjff5zfG0TKjD3z3vb5Fk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=dQIhIWHFDKZOCejaPat0FQco/uHje/UlFVrFA2gVdwVzZ0uEBpvcrPuBA9xoJ/dsS\n\tcy1HRwbjTm9GOgQ9LROYY7et+0sqMurWqcfNO/jYVJvR2e1fABtI9+1HnVATcc1WLO\n\tBpInCESIy1u+lX+H40D9Zyx6jitWNeHtyGbg+XjQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<87h6dzexam.fsf@redhat.com>","References":"<20240610180855.1643125-1-mzamazal@redhat.com>\n\t<20240610180855.1643125-2-mzamazal@redhat.com>\n\t<20240610185640.GK26663@pendragon.ideasonboard.com>\n\t<87h6dzexam.fsf@redhat.com>","Subject":"Re: [PATCH 1/2] clang-format: Make Qt includes matching case\n\tsensitive","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>","Date":"Tue, 11 Jun 2024 13:03:07 +0100","Message-ID":"<171810738738.2248009.14969350769859206287@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]