[{"id":29789,"web_url":"https://patchwork.libcamera.org/comment/29789/","msgid":"<CAHW6GY+5qmYb_EkQqn_wRAqwmvxyxAUiOjh6_9C5y7QjK=6FoA@mail.gmail.com>","date":"2024-06-06T13:26:53","subject":"Re: [PATCH] pipeline: rpi: Don't validate configuration in\n\tgenerateConfiguration()","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the patch. I agree that this is more helpful behaviour for users.\n\nOn Thu, 6 Jun 2024 at 12:52, Naushir Patuck <naush@raspberrypi.com> wrote:\n>\n> generateConfiguration() called validate() as a final step, causing the\n> stride and frameSize fields in StreamConfiguration to be filled in based\n> on the pixel format and width/height.\n>\n> If a user application did not clear the stride field when setting up a\n> custom pixel format and width/height, the pipeline handler would respect\n> this stride and possibly overallocate buffers with a larger stride than\n> needed.\n>\n> Fix this by removing the call to validate() completely, leaving the\n> stride and frameSize fields defaulting to 0. Removal of this call is\n> inconsequential as we hard-code a valid configuration for Raspberry Pi\n> platforms in generateConfiguration().\n>\n> Bug: https://github.com/raspberrypi/libcamera/issues/138\n> Bug: https://github.com/raspberrypi/libcamera/issues/141\n> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n\nThanks\nDavid\n\n> ---\n>  src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 2 --\n>  1 file changed, 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> index 289af5165766..3041fd1ed9fd 100644\n> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> @@ -496,8 +496,6 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span<const StreamRole\n>                 config->addConfiguration(cfg);\n>         }\n>\n> -       config->validate();\n> -\n>         return config;\n>  }\n>\n> --\n> 2.34.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31A8DBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  6 Jun 2024 13:27:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 362CA65457;\n\tThu,  6 Jun 2024 15:27:08 +0200 (CEST)","from mail-oo1-xc2d.google.com (mail-oo1-xc2d.google.com\n\t[IPv6:2607:f8b0:4864:20::c2d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30012634CA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  6 Jun 2024 15:27:06 +0200 (CEST)","by mail-oo1-xc2d.google.com with SMTP id\n\t006d021491bc7-5ba69e446f4so350321eaf.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 06 Jun 2024 06:27:06 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"E+EOAb7y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1717680424; x=1718285224;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=38W1U3JVNZXMInucGMUuwYu9oSxdULYMzumOjNrlB0M=;\n\tb=E+EOAb7yxhDjq5Dz+i6IPc5Qz/+kSgNI1PPqvwq5u+ex33wZXeUGfiOwgR2fvduVN3\n\tdoocci4RVDyUKdRX8itlfBKnNthej/5iscm164rdVd7oUT7HEWm8imo/D21SjUZJIphe\n\tjNuJ01OihiOg8NbRVYcXfi7v7UmVGxJNPvS/HfAM2DyXpBErQGRM8cTiw0qvDea4sJ3J\n\t8OBg66bPruI3rAIzEVc7EXqCNtr3RUnn2G1mcbSP025d9T5N9bd9WsHS8eEnfCjwJnpz\n\tTMhdtzZLiYKoL7CRWuRR/F64ipXWgK7PtPGixQz7+0YAOSoYybukplAh9OhSrpCQawfF\n\trgXQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1717680424; x=1718285224;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=38W1U3JVNZXMInucGMUuwYu9oSxdULYMzumOjNrlB0M=;\n\tb=eDObsooxbVeg065v6fZExlhfGam8DSXeIs0WpH0qfia6g+IIiAq7McQ1y3CPq3A70S\n\tPzamJpp5Nh9ziIcIqreO45YUU0soXdjSCaDHwj/+dmPNcWIhE7jWqLoUwArASeH+iA8O\n\tNw8zc3VCIcWdbA+w3jgpeMipdU84nH6wfcpgKPC/A9NN79NqPvfFRiPN8cqjs6/HIri3\n\tBPU24rbPkimwsjq9WY+oWme4Hw/uCkUqXiYXZxUn1qvTci/z3jz2KruovPl+6zS9HD7c\n\t7JjWuk+G4kRZDFh8Ij4qrr8CrcKpPGsocixxbaOmgT/h+OKoUI3Vb5C4a05qGE0TQlW0\n\tOD9g==","X-Gm-Message-State":"AOJu0Yy3eK0eXT7h69qrk4wTljw5oz0zjupluU1Q+Nk6H0vHV41O6fLT\n\tS1B5wC9c9DAHFPexFSDJRs3I4+Gj3I86IS3fu/5Kj9cOLTDWydoX7vdFgtysaSmtDJm8/rat5al\n\tS8FkGGrxgTSYksLDOF/ls/RmLR9zmnceZnyo6vg==","X-Google-Smtp-Source":"AGHT+IHuNjEFmCtt0D328OKHUbBKOAspOLrV+i0e4eYUVnbkzJLvNxHw7olxRaX8k0x5jwBHi4D7UZsuzj5HYoQHFlI=","X-Received":"by 2002:a05:6870:4203:b0:250:821c:7425 with SMTP id\n\t586e51a60fabf-25122094bbemr5744368fac.46.1717680424488;\n\tThu, 06 Jun 2024 06:27:04 -0700 (PDT)","MIME-Version":"1.0","References":"<20240606115223.14868-1-naush@raspberrypi.com>","In-Reply-To":"<20240606115223.14868-1-naush@raspberrypi.com>","From":"David Plowman <david.plowman@raspberrypi.com>","Date":"Thu, 6 Jun 2024 14:26:53 +0100","Message-ID":"<CAHW6GY+5qmYb_EkQqn_wRAqwmvxyxAUiOjh6_9C5y7QjK=6FoA@mail.gmail.com>","Subject":"Re: [PATCH] pipeline: rpi: Don't validate configuration in\n\tgenerateConfiguration()","To":"Naushir Patuck <naush@raspberrypi.com>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":29790,"web_url":"https://patchwork.libcamera.org/comment/29790/","msgid":"<171768582194.414188.17736889616907703552@ping.linuxembedded.co.uk>","date":"2024-06-06T14:57:01","subject":"Re: [PATCH] pipeline: rpi: Don't validate configuration in\n\tgenerateConfiguration()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting David Plowman (2024-06-06 14:26:53)\n> Hi Naush\n> \n> Thanks for the patch. I agree that this is more helpful behaviour for users.\n> \n> On Thu, 6 Jun 2024 at 12:52, Naushir Patuck <naush@raspberrypi.com> wrote:\n> >\n> > generateConfiguration() called validate() as a final step, causing the\n> > stride and frameSize fields in StreamConfiguration to be filled in based\n> > on the pixel format and width/height.\n> >\n> > If a user application did not clear the stride field when setting up a\n> > custom pixel format and width/height, the pipeline handler would respect\n> > this stride and possibly overallocate buffers with a larger stride than\n> > needed.\n> >\n> > Fix this by removing the call to validate() completely, leaving the\n> > stride and frameSize fields defaulting to 0. Removal of this call is\n> > inconsequential as we hard-code a valid configuration for Raspberry Pi\n> > platforms in generateConfiguration().\n> >\n> > Bug: https://github.com/raspberrypi/libcamera/issues/138\n> > Bug: https://github.com/raspberrypi/libcamera/issues/141\n> > Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> \n> Reviewed-by: David Plowman <david.plowman@raspberrypi.com>\n> \n> Thanks\n> David\n> \n> > ---\n> >  src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 2 --\n> >  1 file changed, 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > index 289af5165766..3041fd1ed9fd 100644\n> > --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > @@ -496,8 +496,6 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span<const StreamRole\n> >                 config->addConfiguration(cfg);\n> >         }\n> >\n> > -       config->validate();\n> > -\n\nI think we expect that configurations (except a completely empty one) we\nreturn are 'valid'. We hardcode this so it should be fine, but I guess\nwe might potentially 'forget' and re-introduce this call later?\n\nDoes it mean we should never call validate on any pipeline that would\ncause the same issue? (or maybe this is just specific to the patch that\nwent into the RPi kernel anyway).\n\nI guess it's \"impossible\" for us to validate stride after it's gone to\nthe application (other than making sure it is at least bigger than the\nwidth*bpp?) as applications might set it larger ...\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nI'll leave merging to next week incase there are any other comments /\nconcerns - but I do see this already fixes user facing issues.\n\n\n> >         return config;\n> >  }\n> >\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89BEEBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  6 Jun 2024 14:57:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A992365448;\n\tThu,  6 Jun 2024 16:57:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD28D634CA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  6 Jun 2024 16:57:04 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 66694904;\n\tThu,  6 Jun 2024 16:56:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pyj8AmdI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717685815;\n\tbh=Y8TUJwKTD1ij+i5zh3zNkGbIb78TmtYwa6EA0UXQgzo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=pyj8AmdIM4F2ZcMpukuBC2SNeeLJFYIity5m4ZXAIqNPQAE1m6wxVLCeY0Q6BgBlV\n\tdD0PMjPME3mpYqymTdXBM8z/HPxL8WiITeRoI+SnaCobfay5LEIb6cc0B3CyIkg9vK\n\tfwDnTIU6ZJ3+cb960RPcjgLqZ29p0vH11yvYis6s=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<CAHW6GY+5qmYb_EkQqn_wRAqwmvxyxAUiOjh6_9C5y7QjK=6FoA@mail.gmail.com>","References":"<20240606115223.14868-1-naush@raspberrypi.com>\n\t<CAHW6GY+5qmYb_EkQqn_wRAqwmvxyxAUiOjh6_9C5y7QjK=6FoA@mail.gmail.com>","Subject":"Re: [PATCH] pipeline: rpi: Don't validate configuration in\n\tgenerateConfiguration()","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","To":"David Plowman <david.plowman@raspberrypi.com>,\n\tNaushir Patuck <naush@raspberrypi.com>","Date":"Thu, 06 Jun 2024 15:57:01 +0100","Message-ID":"<171768582194.414188.17736889616907703552@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":29791,"web_url":"https://patchwork.libcamera.org/comment/29791/","msgid":"<CAEmqJPqbPwPAbSywD8H+oRJnSe5EaHjUMV+NS0vXqXTRx_ug-g@mail.gmail.com>","date":"2024-06-06T15:23:52","subject":"Re: [PATCH] pipeline: rpi: Don't validate configuration in\n\tgenerateConfiguration()","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\nOn Thu, 6 Jun 2024 at 15:57, Kieran Bingham\n<kieran.bingham@ideasonboard.com> wrote:\n>\n> Quoting David Plowman (2024-06-06 14:26:53)\n> > Hi Naush\n> >\n> > Thanks for the patch. I agree that this is more helpful behaviour for users.\n> >\n> > On Thu, 6 Jun 2024 at 12:52, Naushir Patuck <naush@raspberrypi.com> wrote:\n> > >\n> > > generateConfiguration() called validate() as a final step, causing the\n> > > stride and frameSize fields in StreamConfiguration to be filled in based\n> > > on the pixel format and width/height.\n> > >\n> > > If a user application did not clear the stride field when setting up a\n> > > custom pixel format and width/height, the pipeline handler would respect\n> > > this stride and possibly overallocate buffers with a larger stride than\n> > > needed.\n> > >\n> > > Fix this by removing the call to validate() completely, leaving the\n> > > stride and frameSize fields defaulting to 0. Removal of this call is\n> > > inconsequential as we hard-code a valid configuration for Raspberry Pi\n> > > platforms in generateConfiguration().\n> > >\n> > > Bug: https://github.com/raspberrypi/libcamera/issues/138\n> > > Bug: https://github.com/raspberrypi/libcamera/issues/141\n> > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> >\n> > Reviewed-by: David Plowman <david.plowman@raspberrypi.com>\n> >\n> > Thanks\n> > David\n> >\n> > > ---\n> > >  src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 2 --\n> > >  1 file changed, 2 deletions(-)\n> > >\n> > > diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > index 289af5165766..3041fd1ed9fd 100644\n> > > --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > @@ -496,8 +496,6 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span<const StreamRole\n> > >                 config->addConfiguration(cfg);\n> > >         }\n> > >\n> > > -       config->validate();\n> > > -\n>\n> I think we expect that configurations (except a completely empty one) we\n> return are 'valid'. We hardcode this so it should be fine, but I guess\n> we might potentially 'forget' and re-introduce this call later?\n\n\nAs long as we never change the defaults (I don't see why we will), I\nthink we can remove the validate() call permanently.\n\n>\n>\n> Does it mean we should never call validate on any pipeline that would\n> cause the same issue? (or maybe this is just specific to the patch that\n> went into the RPi kernel anyway).\n\n\nPossibly, but the key thing going wrong is for RPi validate() will\nupdate the stride fields to what the driver chooses.  We use this\nfunctionality to allocate dmabufs outside of v4l2 if needed.  Not sure\nif other pipeline handlers do this.\n\n>\n>\n> I guess it's \"impossible\" for us to validate stride after it's gone to\n> the application (other than making sure it is at least bigger than the\n> width*bpp?) as applications might set it larger ...\n\n\nYes, this will still happen when configure() calls validate().\n\nRegards,\nNaush\n\n>\n>\n>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>\n> I'll leave merging to next week incase there are any other comments /\n> concerns - but I do see this already fixes user facing issues.\n>\n>\n> > >         return config;\n> > >  }\n> > >\n> > > --\n> > > 2.34.1\n> > >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35F62BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  6 Jun 2024 15:24:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 465BE65457;\n\tThu,  6 Jun 2024 17:24:30 +0200 (CEST)","from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com\n\t[IPv6:2607:f8b0:4864:20::b34])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A386634CA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  6 Jun 2024 17:24:29 +0200 (CEST)","by mail-yb1-xb34.google.com with SMTP id\n\t3f1490d57ef6-df4d5d0b8d0so1098847276.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 06 Jun 2024 08:24:29 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"cWDKQ4mt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1717687468; x=1718292268;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=iylBpYBsg0dftnMOzN8rqRPaJ5F4XVdYedooVYirL4s=;\n\tb=cWDKQ4mt/DVy1zoAEVLoyHIZieseU6UuNFEe4NgGHgrfBdluhgzQ/lbN3BNrXOggaj\n\t30D2QacwfaG6VE8Pul8Rpe63OGzBHEV4s9dGuwgDWLC4SEbfMJmAk4lzUTn0gJnhssIY\n\tBuM6mRVJkG1k7erCELaKtJ5e9GSlmwRZFuK6XNnPSyquxAL7Mxlbm3IMeofmX7DMpyDE\n\tP65jSwLXOmRYIBR14snYmtiSGhggw5i+QK07RrBbNsSn3Uh9Hcty283+ahtlZOpiIpp7\n\tNzVCOb8RYkdoDlmH+n2dwic3qsixTPiSgdIptEIiKc4C+D476QBws1OPFSh/Z1ieg/id\n\tiH/A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1717687468; x=1718292268;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=iylBpYBsg0dftnMOzN8rqRPaJ5F4XVdYedooVYirL4s=;\n\tb=uK2CL6RunUZY0ILh4R4z5j4ZI2jXaMoSWf3rVPBFdS6iHs2qpwkRyF0/U2soxEnje7\n\tswr8uNX7zYcwvFnHgXuMOM/q5rV0T6dJYq9wlYbf8FpLd2EiyHhHRcdP6LgXFdpdEpxU\n\t2I8yJGZsakSenB3fyXruYjGE4ekZK5zLQKc7R0PWtqAtNzT5/OXOMV6Li6TwgVIsKJJI\n\tx4adSIlF1bD1uo7RSGJmmeJn2C1SS/FmXAIelzlLGHsIImMrqwGr/fISObFzxw8BauxO\n\tD8sh2vR0yL4Izk5MjCjHhZDUnNskomY20h9KkdXMp+SWbhVqVAMyws6k/w1L9hnPrNcF\n\tyVCg==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCWs/52S5T7BArUA7bIG8fGF/X59RtGwllwUbGUa9ebisM8GdHIoTYHFqh+a5ikWMDNqsdS64tu84ofkwxrGNwedCVYYFwrlk+L3bpWnvxz0J9+Fdg==","X-Gm-Message-State":"AOJu0YxA56uMKyB3RPHdtk9TeILNOsCDOlPdx40yTqu37tnN2iPSr93A\n\tqDi+oux+IVPSeP7Hi6VC18g2pJNEd2eL00w8v2PSvvUgKpl6zMwLLXynjRdlv6xidFJa+Mnx3Yl\n\t7nTX4xW22zOVJsyDMEp6EGhfKdneeHVHmpXOD/Q==","X-Google-Smtp-Source":"AGHT+IG4NpiGjlUyiYYNWvp9ZgmjtATffpdl+8RmC8xSsHBJBK7GIqflzO05ogHV/cdlLUAtrUdL1N6sf91XN6326Cw=","X-Received":"by 2002:a25:ac4e:0:b0:dfa:6e39:95c4 with SMTP id\n\t3f1490d57ef6-dfacad24fcdmr6174618276.58.1717687467908;\n\tThu, 06 Jun 2024 08:24:27 -0700 (PDT)","MIME-Version":"1.0","References":"<20240606115223.14868-1-naush@raspberrypi.com>\n\t<CAHW6GY+5qmYb_EkQqn_wRAqwmvxyxAUiOjh6_9C5y7QjK=6FoA@mail.gmail.com>\n\t<171768582194.414188.17736889616907703552@ping.linuxembedded.co.uk>","In-Reply-To":"<171768582194.414188.17736889616907703552@ping.linuxembedded.co.uk>","From":"Naushir Patuck <naush@raspberrypi.com>","Date":"Thu, 6 Jun 2024 16:23:52 +0100","Message-ID":"<CAEmqJPqbPwPAbSywD8H+oRJnSe5EaHjUMV+NS0vXqXTRx_ug-g@mail.gmail.com>","Subject":"Re: [PATCH] pipeline: rpi: Don't validate configuration in\n\tgenerateConfiguration()","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"David Plowman <david.plowman@raspberrypi.com>,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]