[{"id":30477,"web_url":"https://patchwork.libcamera.org/comment/30477/","msgid":"","date":"2024-07-25T08:46:54","subject":"Re: [PATCH] Document additional environmental variables","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Pablo\n thanks for the patch and sorry for the delay. Don't be shy in\npinging us if delays like this happens again in future ;)\n\nOn Wed, Jun 05, 2024 at 12:42:17PM GMT, Pablo Pita wrote:\n\nWe usually require a commit message, even if the change is simple.\nAs a reference https://cbea.ms/git-commit/\n\nAlso you need to sign-off your change. Documentation/contributing.rst\nprovides more details\n\n> ---\n> Documentation/environment_variables.rst | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n>\n> diff --git a/Documentation/environment_variables.rst b/Documentation/environment_variables.rst\n> index 4e9fbb27..7cc13e9f 100644\n> --- a/Documentation/environment_variables.rst\n> +++ b/Documentation/environment_variables.rst\n> @@ -37,6 +37,11 @@ LIBCAMERA_IPA_MODULE_PATH\n>\n> Example value: ``${HOME}/.libcamera/lib:/opt/libcamera/vendor/lib``\n>\n> +LIBCAMERA_IPA_PROXY_PATH\n> + Define custom full path for a proxy worker for a given executable name.\n> +\n> + Example value: ``${HOME}/.libcamera/proxy/worker:/opt/libcamera/vendor/proxy/worker``\n> +\n> LIBCAMERA_PIPELINES_MATCH_LIST\n> Define an ordered list of pipeline names to be used to match the media\n> devices in the system. The pipeline handler names used to populate the\n> @@ -50,6 +55,11 @@ LIBCAMERA_RPI_CONFIG_FILE\n>\n> Example value: ``/usr/local/share/libcamera/pipeline/rpi/vc4/minimal_mem.yaml``\n>\n> +LIBCAMERA_RPI_TUNING_FILE\n> + Define a custom JSON tuning file to use in the Raspberry Pi.\n> +\n> + Example value: ``/usr/local/share/libcamera/ipa/rpi/vc4/custom_sensor.json``\n> +\n\nThe path looks good to me\nReviewed-by: Jacopo Mondi \n\n> Further details\n> ---------------\n>\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 76C5DC323E\n\tfor ;\n\tThu, 25 Jul 2024 08:47:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B96E6336F;\n\tThu, 25 Jul 2024 10:46:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F2E96199A\n\tfor ;\n\tThu, 25 Jul 2024 10:46:58 +0200 (CEST)","from ideasonboard.com (mob-5-90-42-5.net.vodafone.it [5.90.42.5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B90A45B;\n\tThu, 25 Jul 2024 10:46:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZnLQ3ODe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721897174;\n\tbh=paRPQfaCCi8UApozPzdGkKz2VuMBY5v5xLAR3/eVzDE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZnLQ3ODeamyx7zt3IiN1500lpiW4yt8SjG+3uvbzEX5zD7kXj8ng1M/jRMi/y9Omt\n\tjPZmZpN8H7wIV2deNTvq5DEkV3ZImJ8TcmmimhzZmsfOZ53DGDf6308caZ6rgDnwgx\n\tDmSvC/fzYSqIu3yfMtUpIZfXTbiSaBKVYoxm61t8=","Date":"Thu, 25 Jul 2024 10:46:54 +0200","From":"Jacopo Mondi ","To":"Pablo Pita ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] Document additional environmental variables","Message-ID":"","References":"<20240605104217.59803-1-pablo.pita@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240605104217.59803-1-pablo.pita@gmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30484,"web_url":"https://patchwork.libcamera.org/comment/30484/","msgid":"<172190564270.392292.16733133604501974890@ping.linuxembedded.co.uk>","date":"2024-07-25T11:07:22","subject":"Re: [PATCH] Document additional environmental variables","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2024-07-25 09:46:54)\n> Hi Pablo\n> thanks for the patch and sorry for the delay. Don't be shy in\n> pinging us if delays like this happens again in future ;)\n> \n> On Wed, Jun 05, 2024 at 12:42:17PM GMT, Pablo Pita wrote:\n> \n> We usually require a commit message, even if the change is simple.\n> As a reference https://cbea.ms/git-commit/\n> \n> Also you need to sign-off your change. Documentation/contributing.rst\n> provides more details\n\nI'd recommend something simple like:\n\n\"\"\"\nDocumentation: Document additional environment variables\n\nThe LIBCAMERA_IPA_PROXY_PATH and LIBCAMERA_RPI_TUNING_FILE environment\nvariables have been added without providing documentation.\n\nAdd a description of each and a corresponding example.\n\"\"\"\n\nIf you can reply with your Signed-off-by: Your Name \nthen we can update while applying.\n\n\n> \n> > ---\n> > Documentation/environment_variables.rst | 10 ++++++++++\n> > 1 file changed, 10 insertions(+)\n> >\n> > diff --git a/Documentation/environment_variables.rst b/Documentation/environment_variables.rst\n> > index 4e9fbb27..7cc13e9f 100644\n> > --- a/Documentation/environment_variables.rst\n> > +++ b/Documentation/environment_variables.rst\n> > @@ -37,6 +37,11 @@ LIBCAMERA_IPA_MODULE_PATH\n> >\n> > Example value: ``${HOME}/.libcamera/lib:/opt/libcamera/vendor/lib``\n> >\n> > +LIBCAMERA_IPA_PROXY_PATH\n> > + Define custom full path for a proxy worker for a given executable name.\n> > +\n> > + Example value: ``${HOME}/.libcamera/proxy/worker:/opt/libcamera/vendor/proxy/worker``\n> > +\n> > LIBCAMERA_PIPELINES_MATCH_LIST\n> > Define an ordered list of pipeline names to be used to match the media\n> > devices in the system. The pipeline handler names used to populate the\n> > @@ -50,6 +55,11 @@ LIBCAMERA_RPI_CONFIG_FILE\n> >\n> > Example value: ``/usr/local/share/libcamera/pipeline/rpi/vc4/minimal_mem.yaml``\n> >\n> > +LIBCAMERA_RPI_TUNING_FILE\n> > + Define a custom JSON tuning file to use in the Raspberry Pi.\n> > +\n> > + Example value: ``/usr/local/share/libcamera/ipa/rpi/vc4/custom_sensor.json``\n> > +\n> \n> The path looks good to me\n> Reviewed-by: Jacopo Mondi \n\nAgreed, the patch should be fine, but we need that signoff to be able to\nmerge it.\n\n\nReviewed-by: Kieran Bingham \n\n> \n> > Further details\n> > ---------------\n> >\n> > --\n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B010C323E\n\tfor ;\n\tThu, 25 Jul 2024 11:07:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 54EC46336F;\n\tThu, 25 Jul 2024 13:07:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6921D6199E\n\tfor ;\n\tThu, 25 Jul 2024 13:07:25 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8C3F745B;\n\tThu, 25 Jul 2024 13:06:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZNPD2gDO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721905601;\n\tbh=P1TkYV7yWmKezfnm50r4ULZm8mF7TWw9wqh5PIHbCN4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ZNPD2gDOf5VyNkdNOPxm2rqGCqTxsmeEMUmbDoQJvxl6InOvTDhKliwskVolKc1ET\n\tkxoLlKyzb2Zq0dcjHj4uvlokfzjx14rSAdXcLIdnBrPYrpl6NhCxyvBJpGxcDeJo9a\n\tcfxYV8Xr2+lwROUSudntDTauLcVqbBMSV66IrMT0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20240605104217.59803-1-pablo.pita@gmail.com>\n\t","Subject":"Re: [PATCH] Document additional environmental variables","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Jacopo Mondi ,\n\tPablo Pita ","Date":"Thu, 25 Jul 2024 12:07:22 +0100","Message-ID":"<172190564270.392292.16733133604501974890@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]