[{"id":29781,"web_url":"https://patchwork.libcamera.org/comment/29781/","msgid":"<171758435837.2248009.9166935443748956315@ping.linuxembedded.co.uk>","date":"2024-06-05T10:45:58","subject":"Re: [PATCH v4 1/3] libcamera: Add gamma control id","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2024-06-05 10:53:49)\n> A camera gamma of roughly 2.2 is necessary to produce correct output\n> images on a standard monitor. Add a control for that.\n> \n> Further information is available here:\n> https://en.wikipedia.org/wiki/SRGB\n> https://www.cambridgeincolour.com/tutorials/gamma-correction.htm\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Daniel Scally \n> Reviewed-by: Kieran Bingham \n> ---\n> src/libcamera/control_ids_core.yaml | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index bf1f1a839f6a..303b0d32e020 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -243,6 +243,13 @@ controls:\n> Specify a fixed contrast parameter. Normal contrast is given by the\n> value 1.0; larger values produce images with more contrast.\n> \n> + - Gamma:\n> + type: float\n> + description: |\n> + Specify a fixed gamma value. Default must be 2.2 which closely mimics \n> + sRGB gamma. Note that this is camera gamma, so it is applied as \n> + 1.0/gamma\n> +\n\nAha - one small issue here.\n\nCan you append the control instead of adding it in alphabetically?\n(Yeah, normally we'd definitely sort things alphabetically...)\n\nThat will prevent an ABI breakage. I think we can run a sort operation\non any occasion where we do an ABI breaking release - but hopefully\nthere's no need to introduce an ABI break here.\n\n--\nKieran\n\n\n> - Lux:\n> type: float\n> description: |\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2E2FBD87C\n\tfor ;\n\tWed, 5 Jun 2024 10:46:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C801E6543C;\n\tWed, 5 Jun 2024 12:46:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 245F6634B5\n\tfor ;\n\tWed, 5 Jun 2024 12:46:01 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 860A616D4;\n\tWed, 5 Jun 2024 12:45:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"H/wVM4Ew\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717584352;\n\tbh=i+OAyiC5xWvwk7RZ2gQM4Ei7aqcFKyUkZ2VzirUy/Wo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=H/wVM4Ew/No4N3RIq52XGzaeSMO+HuLKEBGFuXvEb7xFCpa7vjwTHZ6ZUjVelsBtd\n\t6LGsG1kqNOHPrnBGEfcFK1jmMGBkZLtlTyIRG3VEM4Fdyvpf+kxdiok9HtlpKtKisM\n\tgsPkEIEGtWX33jPSt04rnBl/Bfk8ZDCAVT/VFJS8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240605095417.157703-2-stefan.klug@ideasonboard.com>","References":"<20240605095417.157703-1-stefan.klug@ideasonboard.com>\n\t<20240605095417.157703-2-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v4 1/3] libcamera: Add gamma control id","From":"Kieran Bingham ","Cc":"Stefan Klug ,\n\tDaniel Scally ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 05 Jun 2024 11:45:58 +0100","Message-ID":"<171758435837.2248009.9166935443748956315@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29787,"web_url":"https://patchwork.libcamera.org/comment/29787/","msgid":"","date":"2024-06-06T06:23:47","subject":"Re: [PATCH v4 1/3] libcamera: Add gamma control id","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Jun 05, 2024 at 11:45:58AM +0100, Kieran Bingham wrote:\n> Quoting Stefan Klug (2024-06-05 10:53:49)\n> > A camera gamma of roughly 2.2 is necessary to produce correct output\n> > images on a standard monitor. Add a control for that.\n> > \n> > Further information is available here:\n> > https://en.wikipedia.org/wiki/SRGB\n> > https://www.cambridgeincolour.com/tutorials/gamma-correction.htm\n> > \n> > Signed-off-by: Stefan Klug \n> > Reviewed-by: Daniel Scally \n> > Reviewed-by: Kieran Bingham \n> > ---\n> > src/libcamera/control_ids_core.yaml | 7 +++++++\n> > 1 file changed, 7 insertions(+)\n> > \n> > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> > index bf1f1a839f6a..303b0d32e020 100644\n> > --- a/src/libcamera/control_ids_core.yaml\n> > +++ b/src/libcamera/control_ids_core.yaml\n> > @@ -243,6 +243,13 @@ controls:\n> > Specify a fixed contrast parameter. Normal contrast is given by the\n> > value 1.0; larger values produce images with more contrast.\n> > \n> > + - Gamma:\n> > + type: float\n> > + description: |\n> > + Specify a fixed gamma value. Default must be 2.2 which closely mimics \n> > + sRGB gamma. Note that this is camera gamma, so it is applied as \n> > + 1.0/gamma\n> > +\n> \n> Aha - one small issue here.\n> \n> Can you append the control instead of adding it in alphabetically?\n> (Yeah, normally we'd definitely sort things alphabetically...)\n> \n> That will prevent an ABI breakage. I think we can run a sort operation\n> on any occasion where we do an ABI breaking release - but hopefully\n> there's no need to introduce an ABI break here.\n\nI wasn't aware of that. Changed it locally. Will be fixed when applying.\n\nCheers,\nStefan\n\n> \n> --\n> Kieran\n> \n> \n> > - Lux:\n> > type: float\n> > description: |\n> > -- \n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14312C31E9\n\tfor ;\n\tThu, 6 Jun 2024 06:23:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F34616544E;\n\tThu, 6 Jun 2024 08:23:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A38AA633DD\n\tfor ;\n\tThu, 6 Jun 2024 08:23:50 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7b40:34c7:ae34:72b0])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D4E2EAB;\n\tThu, 6 Jun 2024 08:23:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QErRk6z7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717655021;\n\tbh=+w74wujuUbdcwtfq3rtBEkECEV1woaua6NJLMPvXXAQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QErRk6z7JBE+FMZKU1qmziaLHShsm+id/iBgYTqNiKoImvZMhLTSooTTJxRQN6NQ7\n\tew93hSYbLlfNN3n6jrwNoEoctzQLvqxBWQ2/KbKrnwAjQW63+8wFfMaD1BUWUE3/08\n\tgGGZGjrxNuyTiCrtuc0gcrwBizQdIC3HBrufNzms=","Date":"Thu, 6 Jun 2024 08:23:47 +0200","From":"Stefan Klug ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org, \n\tDaniel Scally ","Subject":"Re: [PATCH v4 1/3] libcamera: Add gamma control id","Message-ID":"","References":"<20240605095417.157703-1-stefan.klug@ideasonboard.com>\n\t<20240605095417.157703-2-stefan.klug@ideasonboard.com>\n\t<171758435837.2248009.9166935443748956315@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<171758435837.2248009.9166935443748956315@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29796,"web_url":"https://patchwork.libcamera.org/comment/29796/","msgid":"","date":"2024-06-10T10:27:17","subject":"Re: [PATCH v4 1/3] libcamera: Add gamma control id","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Jun 05, 2024 at 11:53:49AM +0200, Stefan Klug wrote:\n> A camera gamma of roughly 2.2 is necessary to produce correct output\n> images on a standard monitor. Add a control for that.\n> \n> Further information is available here:\n> https://en.wikipedia.org/wiki/SRGB\n> https://www.cambridgeincolour.com/tutorials/gamma-correction.htm\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Daniel Scally \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/control_ids_core.yaml | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index bf1f1a839f6a..303b0d32e020 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -243,6 +243,13 @@ controls:\n> Specify a fixed contrast parameter. Normal contrast is given by the\n> value 1.0; larger values produce images with more contrast.\n> \n> + - Gamma:\n> + type: float\n> + description: |\n> + Specify a fixed gamma value. Default must be 2.2 which closely mimics \n> + sRGB gamma. Note that this is camera gamma, so it is applied as \n> + 1.0/gamma\n> +\n> - Lux:\n> type: float\n> description: |\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ED7D1BD87C\n\tfor ;\n\tMon, 10 Jun 2024 10:27:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC1BC65461;\n\tMon, 10 Jun 2024 12:27:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 07F0A65446\n\tfor ;\n\tMon, 10 Jun 2024 12:27:25 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A422C512;\n\tMon, 10 Jun 2024 12:27:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IUiCEwQh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718015233;\n\tbh=f5vqzFJVIC8RbyhzeSqy0wtx0FBo1a85MgH8Q3mE7Lk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IUiCEwQhWwKROdOdHO8WJWR64ll8zEtbjfp9+kMAfCbvGkYZRE6olsELN+nIjjlLI\n\tVcS9qUtuGr4MUvD2enAqYZohhffW88RzYCeMkTTLvAKaNL1M5Kl8HDADioRARSEmk1\n\tP4/UB2sY4sFcVm/seE1nVn9VdA3MVPRxkQjVDL64=","Date":"Mon, 10 Jun 2024 19:27:17 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tDaniel Scally ,\n\tKieran Bingham ","Subject":"Re: [PATCH v4 1/3] libcamera: Add gamma control id","Message-ID":"","References":"<20240605095417.157703-1-stefan.klug@ideasonboard.com>\n\t<20240605095417.157703-2-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240605095417.157703-2-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29842,"web_url":"https://patchwork.libcamera.org/comment/29842/","msgid":"<20240611201627.GD10397@pendragon.ideasonboard.com>","date":"2024-06-11T20:16:27","subject":"Re: [PATCH v4 1/3] libcamera: Add gamma control id","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jun 05, 2024 at 11:53:49AM +0200, Stefan Klug wrote:\n> A camera gamma of roughly 2.2 is necessary to produce correct output\n> images on a standard monitor. Add a control for that.\n> \n> Further information is available here:\n> https://en.wikipedia.org/wiki/SRGB\n> https://www.cambridgeincolour.com/tutorials/gamma-correction.htm\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Daniel Scally \n> Reviewed-by: Kieran Bingham \n> ---\n> src/libcamera/control_ids_core.yaml | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index bf1f1a839f6a..303b0d32e020 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -243,6 +243,13 @@ controls:\n> Specify a fixed contrast parameter. Normal contrast is given by the\n> value 1.0; larger values produce images with more contrast.\n> \n> + - Gamma:\n> + type: float\n> + description: |\n> + Specify a fixed gamma value. Default must be 2.2 which closely mimics \n> + sRGB gamma. Note that this is camera gamma, so it is applied as \n> + 1.0/gamma\n\nSmall typo here, missing period at the end of the line.\n\nIt would be nice to tell a bit more about the lower and upper bounds,\nbut that can come later. We should also document the camera pipeline at\nsome point, to show where gamma is applied.\n\n> +\n> - Lux:\n> type: float\n> description: |","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B28D7C31E9\n\tfor ;\n\tTue, 11 Jun 2024 20:16:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B163E65463;\n\tTue, 11 Jun 2024 22:16:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B6EC65446\n\tfor ;\n\tTue, 11 Jun 2024 22:16:47 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 04CBD29A;\n\tTue, 11 Jun 2024 22:16:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DiWmefJP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718136994;\n\tbh=ANudwmYnLFPilwCK39BSTwc0KEPl6ldOcfv2sFpUCpw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DiWmefJPXU6NU+WXdpmLwQYPRKa4sjFQ/SNWxkbU9bPHmo5k648j3La2BYsE86wAo\n\tvCl4Z7+F9EQegEXHTbGBeRfLE5W3YTBlFBHORSODzamDOhI0U4/e479k5UxZN5JL6+\n\tPFQkRmQYY8Qv3xm19zqqIm6fO/SAi3b9zPb3/gzQ=","Date":"Tue, 11 Jun 2024 23:16:27 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tDaniel Scally ,\n\tKieran Bingham ","Subject":"Re: [PATCH v4 1/3] libcamera: Add gamma control id","Message-ID":"<20240611201627.GD10397@pendragon.ideasonboard.com>","References":"<20240605095417.157703-1-stefan.klug@ideasonboard.com>\n\t<20240605095417.157703-2-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240605095417.157703-2-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]