[{"id":29743,"web_url":"https://patchwork.libcamera.org/comment/29743/","msgid":"<171740817800.1000377.6215716147391743110@ping.linuxembedded.co.uk>","date":"2024-06-03T09:49:38","subject":"Re: [PATCH] ipa: rpi: Disable StatsOutputEnable control by default","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2024-06-03 10:42:09)\n> Set the default value of controls::rpi::StatsOutputEnable to false,\n> disabling the functionality. This stops unnecessary copies of the\n> statistics output ending up in the Request metdata if not needed.\n\nDefault false here is certainly reasonable.\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/rpi/common/ipa_base.cpp | 7 ++++---\n> 1 file changed, 4 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> index 1d12262bda01..6fb90209aa0f 100644\n> --- a/src/ipa/rpi/common/ipa_base.cpp\n> +++ b/src/ipa/rpi/common/ipa_base.cpp\n> @@ -73,7 +73,7 @@ const ControlInfoMap::Map ipaControls{\n> { &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },\n> { &controls::FrameDurationLimits, ControlInfo(INT64_C(33333), INT64_C(120000)) },\n> { &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n> - { &controls::rpi::StatsOutputEnable, ControlInfo(false, true) },\n> + { &controls::rpi::StatsOutputEnable, ControlInfo(false, true, false) },\n> };\n> \n> /* IPA controls handled conditionally, if the sensor is not mono */\n> @@ -103,8 +103,9 @@ LOG_DEFINE_CATEGORY(IPARPI)\n> namespace ipa::RPi {\n> \n> IpaBase::IpaBase()\n> - : controller_(), frameLengths_(FrameLengthsQueueSize, 0s), stitchSwapBuffers_(false), frameCount_(0),\n> - mistrustCount_(0), lastRunTimestamp_(0), firstStart_(true), flickerState_({ 0, 0s })\n> + : controller_(), frameLengths_(FrameLengthsQueueSize, 0s), statsMetadataOutput_(false),\n> + stitchSwapBuffers_(false), frameCount_(0), mistrustCount_(0), lastRunTimestamp_(0),\n> + firstStart_(true), flickerState_({ 0, 0s })\n> {\n> }\n> \n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62025BDE6B\n\tfor ;\n\tMon, 3 Jun 2024 09:49:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AC1BF634CB;\n\tMon, 3 Jun 2024 11:49:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B515634AF\n\tfor ;\n\tMon, 3 Jun 2024 11:49:40 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 36FB2C67;\n\tMon, 3 Jun 2024 11:49:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vAyUoXaR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717408173;\n\tbh=hXVl2RVIuMlYVRMqfSMeAx+lfkJ1opPc3nD+cmzokXI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=vAyUoXaRpS/8jISAKHuRnFKjbJxsH8iee3E3Snm3iqGk8Svkwl2O8DSMD4HMYQ4lN\n\t6mdzUvRDSHrqBNv2eaKm5n+3ZQheEfztDyBRMFtcLQxAXAFFaRPMTE88d+YYTOWinQ\n\tUoGdFFnCiRcWJIS7onQFhNplX1CKLVPe0BC0tS0U=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240603094209.13921-1-naush@raspberrypi.com>","References":"<20240603094209.13921-1-naush@raspberrypi.com>","Subject":"Re: [PATCH] ipa: rpi: Disable StatsOutputEnable control by default","From":"Kieran Bingham ","Cc":"Naushir Patuck ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 03 Jun 2024 10:49:38 +0100","Message-ID":"<171740817800.1000377.6215716147391743110@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29747,"web_url":"https://patchwork.libcamera.org/comment/29747/","msgid":"","date":"2024-06-03T11:23:37","subject":"Re: [PATCH] ipa: rpi: Disable StatsOutputEnable control by default","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the fix!\n\nOn Mon, 3 Jun 2024 at 10:49, Kieran Bingham\n wrote:\n>\n> Quoting Naushir Patuck (2024-06-03 10:42:09)\n> > Set the default value of controls::rpi::StatsOutputEnable to false,\n> > disabling the functionality. This stops unnecessary copies of the\n> > statistics output ending up in the Request metdata if not needed.\n>\n> Default false here is certainly reasonable.\n>\n> Reviewed-by: Kieran Bingham \n>\n> >\n> > Signed-off-by: Naushir Patuck \n\nReviewed-by: David Plowman \n\nDavid\n\n> > ---\n> > src/ipa/rpi/common/ipa_base.cpp | 7 ++++---\n> > 1 file changed, 4 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> > index 1d12262bda01..6fb90209aa0f 100644\n> > --- a/src/ipa/rpi/common/ipa_base.cpp\n> > +++ b/src/ipa/rpi/common/ipa_base.cpp\n> > @@ -73,7 +73,7 @@ const ControlInfoMap::Map ipaControls{\n> > { &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },\n> > { &controls::FrameDurationLimits, ControlInfo(INT64_C(33333), INT64_C(120000)) },\n> > { &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n> > - { &controls::rpi::StatsOutputEnable, ControlInfo(false, true) },\n> > + { &controls::rpi::StatsOutputEnable, ControlInfo(false, true, false) },\n> > };\n> >\n> > /* IPA controls handled conditionally, if the sensor is not mono */\n> > @@ -103,8 +103,9 @@ LOG_DEFINE_CATEGORY(IPARPI)\n> > namespace ipa::RPi {\n> >\n> > IpaBase::IpaBase()\n> > - : controller_(), frameLengths_(FrameLengthsQueueSize, 0s), stitchSwapBuffers_(false), frameCount_(0),\n> > - mistrustCount_(0), lastRunTimestamp_(0), firstStart_(true), flickerState_({ 0, 0s })\n> > + : controller_(), frameLengths_(FrameLengthsQueueSize, 0s), statsMetadataOutput_(false),\n> > + stitchSwapBuffers_(false), frameCount_(0), mistrustCount_(0), lastRunTimestamp_(0),\n> > + firstStart_(true), flickerState_({ 0, 0s })\n> > {\n> > }\n> >\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E09BEBD87C\n\tfor ;\n\tMon, 3 Jun 2024 11:23:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 09BBB634C5;\n\tMon, 3 Jun 2024 13:23:52 +0200 (CEST)","from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com\n\t[IPv6:2607:f8b0:4864:20::f32])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFF3361A3B\n\tfor ;\n\tMon, 3 Jun 2024 13:23:49 +0200 (CEST)","by mail-qv1-xf32.google.com with SMTP id\n\t6a1803df08f44-6aedd5167d1so14947196d6.1\n\tfor ;\n\tMon, 03 Jun 2024 04:23:49 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"GYgKJQHb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1717413828; x=1718018628;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=jBziyddzpB9009uQFqX0K/fhyhzuw8aFir+fViRWQ9Q=;\n\tb=GYgKJQHbrP3uU5Y4b3oq73BWBjjbrD2hAimW3Fh0E6qqjQok9JO1zZ4m+ZT2XawBWc\n\txYqzmW+Fm7pryot06nUI00RjhVqT3yVK0zdtmG2JJ+aCuLvrgg6wpZdHe6SQJRJU7wvo\n\tKUAUN98h5Mf2hmU8RAr6I20fhuVIdIRZnrWE2XHCFrlV+24mvbIImB5ZUj0q/6vt2bK2\n\tM43f57W8kk3iIJbwp4lhbZjof4LzagUrHkzYVvg5eEa+qAPpmxUCAVcN3y4STm0mb6Df\n\t6YQ45DjclrnOa+/J8MeXdlYjU25cFw/AmXkIT+UipQYkU03Ay05QrAnFDfbkLTce03ZH\n\tXlng==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1717413828; x=1718018628;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=jBziyddzpB9009uQFqX0K/fhyhzuw8aFir+fViRWQ9Q=;\n\tb=Qn3MBgPFbZ+nvL4rLzt42krxj14bL8HKgOiXMcF2wdvPYGy69d3chqie5Kp09jxtxy\n\tkiZ1LZbi24y1aQXDtouZR95zFLBa99KNH52Va9X3plZPImrn9LMjI/m8OcdD/m0ggB3o\n\t6zE/8iMhg6bgfWOZ3oX2z3RWsqLR2fee9GJNGSqdMl4QEcqgXmPQjZdRyAlxgLjlaosG\n\tADvOfxsXK3c0snciTjVr3uHrbXjV2i1ryU/jWNtZMTuBSOTxVYaRvQDXoJFMc5rMGXih\n\t9ScfmZ8+xPk9+Y6vfM6G/9d9T/5BZqXG8WwVqMu+mHhzNH2OMTmVNPWzkr33ESe9hhIz\n\tBQXQ==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCXBkzs5jgGkeUXQEPaAbxCbyy4HOYZRCL5kzES5s645aL3sBvdxrq+eSsaiyyfB1+J5cqM9yuLhO/OhruavlxreoLA27Qks+nygKzipYZ5j6noa3w==","X-Gm-Message-State":"AOJu0YzDyxUtniKb5+Qn3gPBya8FZHTwvnj77al+HWnGHdGQ0EmIxMCT\n\tmW4rteHVe9/4dQ1FgC+uHJTwL+Y3XIMwPBs+E0grzD7rOaj2B1mechSp0UvmRbOTISqEHY2RDMh\n\tzqqbbnrsAFROSPAHXKOjqE5/L4LevlJldjbhKIA==","X-Google-Smtp-Source":"AGHT+IEs9GVZHupcj3Tt3Py3ADrUC/I5xQPMwENk1avfPGabMERWsKYkTNOoi43o8rb45GB058do0Y3IGklIqP/XW5s=","X-Received":"by 2002:a05:6214:3b87:b0:6af:b70d:55e9 with SMTP id\n\t6a1803df08f44-6afb70d56b0mr34814116d6.42.1717413828538;\n\tMon, 03 Jun 2024 04:23:48 -0700 (PDT)","MIME-Version":"1.0","References":"<20240603094209.13921-1-naush@raspberrypi.com>\n\t<171740817800.1000377.6215716147391743110@ping.linuxembedded.co.uk>","In-Reply-To":"<171740817800.1000377.6215716147391743110@ping.linuxembedded.co.uk>","From":"David Plowman ","Date":"Mon, 3 Jun 2024 12:23:37 +0100","Message-ID":"","Subject":"Re: [PATCH] ipa: rpi: Disable StatsOutputEnable control by default","To":"Kieran Bingham ","Cc":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]