[{"id":29736,"web_url":"https://patchwork.libcamera.org/comment/29736/","msgid":"","date":"2024-06-02T16:48:57","subject":"Re: [PATCH] test: ipa: rkisp1-utils: Fix coding style for template\n\targuments","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Sun, Jun 02, 2024 at 02:57:40AM +0300, Laurent Pinchart wrote:\n> The coding style names template arguments using CamelCase with an\n> uppercase initial letter. Fix the template arguments in the rkisp1-utils\n> test.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> test/ipa/rkisp1/rkisp1-utils.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/test/ipa/rkisp1/rkisp1-utils.cpp b/test/ipa/rkisp1/rkisp1-utils.cpp\n> index 9fff0cdcef15..e48f8d3622d2 100644\n> --- a/test/ipa/rkisp1/rkisp1-utils.cpp\n> +++ b/test/ipa/rkisp1/rkisp1-utils.cpp\n> @@ -21,10 +21,10 @@ using namespace ipa::rkisp1;\n> class RkISP1UtilsTest : public Test\n> {\n> protected:\n> -\ttemplate\n> +\ttemplate\n> \tint testSingleFixedPoint(double input, T expected)\n> \t{\n> -\t\tT ret = utils::floatingToFixedPoint(input);\n> +\t\tT ret = utils::floatingToFixedPoint(input);\n> \t\tif (ret != expected) {\n> \t\t\tcerr << \"Expected \" << input << \" to convert to \"\n> \t\t\t << expected << \", got \" << ret << std::endl;\n> @@ -35,7 +35,7 @@ protected:\n> \t\t * The precision check is fairly arbitrary but is based on what\n> \t\t * the rkisp1 is capable of in the crosstalk module.\n> \t\t */\n> -\t\tdouble f = utils::fixedToFloatingPoint(ret);\n> +\t\tdouble f = utils::fixedToFloatingPoint(ret);\n> \t\tif (std::abs(f - input) > 0.005) {\n> \t\t\tcerr << \"Reverse conversion expected \" << ret\n> \t\t\t << \" to convert to \" << input\n> \n> base-commit: aad5837d70f8d3dc19f62f88f1434e3c9cf5ffbe","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11255BDE6B\n\tfor ;\n\tSun, 2 Jun 2024 16:49:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D77CB634C8;\n\tSun, 2 Jun 2024 18:49:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3992F61A45\n\tfor ;\n\tSun, 2 Jun 2024 18:49:06 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A9C231BA;\n\tSun, 2 Jun 2024 18:48:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nr+bCkTc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717346939;\n\tbh=kLrBCPlO6vYlX2Fxss+l5nTt6pwyGXJfxe9fu2u/nnQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nr+bCkTcR6oqjzYSMOdQDAxVtECUmJH48H4p5dAcTm6ilFhCJGiZfyw78KALrL9f9\n\tbMGjXPCpFs81xMC9MCABHPCNgUGUhkOHiqMbmjqegQ2OPVBa7XVqlPYa8zyEzCPeBK\n\t4mtrOB31D8kk1JiSv8A2VksE9GdQm1sOWXB5tZdc=","Date":"Mon, 3 Jun 2024 01:48:57 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] test: ipa: rkisp1-utils: Fix coding style for template\n\targuments","Message-ID":"","References":"<20240601235740.14594-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240601235740.14594-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29740,"web_url":"https://patchwork.libcamera.org/comment/29740/","msgid":"<171740481870.1000377.6672717329059263625@ping.linuxembedded.co.uk>","date":"2024-06-03T08:53:38","subject":"Re: [PATCH] test: ipa: rkisp1-utils: Fix coding style for template\n\targuments","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-06-02 00:57:40)\n> The coding style names template arguments using CamelCase with an\n> uppercase initial letter. Fix the template arguments in the rkisp1-utils\n> test.\n> \n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> test/ipa/rkisp1/rkisp1-utils.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/test/ipa/rkisp1/rkisp1-utils.cpp b/test/ipa/rkisp1/rkisp1-utils.cpp\n> index 9fff0cdcef15..e48f8d3622d2 100644\n> --- a/test/ipa/rkisp1/rkisp1-utils.cpp\n> +++ b/test/ipa/rkisp1/rkisp1-utils.cpp\n> @@ -21,10 +21,10 @@ using namespace ipa::rkisp1;\n> class RkISP1UtilsTest : public Test\n> {\n> protected:\n> - template\n> + template\n> int testSingleFixedPoint(double input, T expected)\n> {\n> - T ret = utils::floatingToFixedPoint(input);\n> + T ret = utils::floatingToFixedPoint(input);\n> if (ret != expected) {\n> cerr << \"Expected \" << input << \" to convert to \"\n> << expected << \", got \" << ret << std::endl;\n> @@ -35,7 +35,7 @@ protected:\n> * The precision check is fairly arbitrary but is based on what\n> * the rkisp1 is capable of in the crosstalk module.\n> */\n> - double f = utils::fixedToFloatingPoint(ret);\n> + double f = utils::fixedToFloatingPoint(ret);\n> if (std::abs(f - input) > 0.005) {\n> cerr << \"Reverse conversion expected \" << ret\n> << \" to convert to \" << input\n> \n> base-commit: aad5837d70f8d3dc19f62f88f1434e3c9cf5ffbe\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3138EBD87C\n\tfor ;\n\tMon, 3 Jun 2024 08:53:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 137F7634CE;\n\tMon, 3 Jun 2024 10:53:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D02A634C5\n\tfor ;\n\tMon, 3 Jun 2024 10:53:41 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8014DB53;\n\tMon, 3 Jun 2024 10:53:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kRKvEElW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717404814;\n\tbh=zKZ42AaqK2sg+ik1Yuh9p8HZ5jH9Fcm1nkQ8Q56JaHY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=kRKvEElWX3b4Md3B1uYOhTnNsBWiX8E4LXYHOkEfTT1L/nHiQNXp7NLFcpsDL49cy\n\t4TiAoCEWTWJ9jeV6rCbMO7fKVn/DBvY02bqL5xnqr2w+X+75CC4RzoiGQySRUFF7v9\n\tk6ZA2DXEvCgd/DErclxSlDLEBk7kjY6M4qvxRtXo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240601235740.14594-1-laurent.pinchart@ideasonboard.com>","References":"<20240601235740.14594-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] test: ipa: rkisp1-utils: Fix coding style for template\n\targuments","From":"Kieran Bingham ","Cc":"Paul Elder ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 03 Jun 2024 09:53:38 +0100","Message-ID":"<171740481870.1000377.6672717329059263625@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]