[{"id":29727,"web_url":"https://patchwork.libcamera.org/comment/29727/","msgid":"<20240601230006.GC6683@pendragon.ideasonboard.com>","date":"2024-06-01T23:00:06","subject":"Re: [PATCH v6 5/5] libcamera: software_isp: Remove TODO about\n\tinternal representation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Fri, May 31, 2024 at 02:38:40PM +0200, Milan Zamazal wrote:\n> TODO #4 was recorded at a time where the IPA module computed gain values\n> and the ISP computed the look up tables. The gains were higher-level\n> parameters. Now that the look up tables are computed in the IPA module,\n> the IPA and ISP are more tightly coupled and the TODO item is less\n> relevant.\n> \n> Let's drop the TODO item. We may or may not need to switch to a\n> different representation in future but there is currently no good need\n> for this and the conversion of the values would be just waste of CPU\n> cycles.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/software_isp/TODO | 13 -------------\n> 1 file changed, 13 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO\n> index 4fcee39b..6bdc5905 100644\n> --- a/src/libcamera/software_isp/TODO\n> +++ b/src/libcamera/software_isp/TODO\n> @@ -72,19 +72,6 @@ stats in hardware, such as the i.MX7), but please keep it on your radar.\n> \n> ---\n> \n> -4. Hide internal representation of gains from callers\n> -\n> -> struct DebayerParams {\n> -> \tstatic constexpr unsigned int kGain10 = 256;\n> -\n> -Forcing the caller to deal with the internal representation of gains\n> -isn't nice, especially given that it precludes implementing gains of\n> -different precisions in different backend. Wouldn't it be better to pass\n> -the values as floating point numbers, and convert them to the internal\n> -representation in the implementation of process() before using them ?\n> -\n> ----\n> -\n> 5. Store ISP parameters in per-frame buffers\n> \n> > /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5486BDE6B\n\tfor ;\n\tSat, 1 Jun 2024 23:00:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA1F9634BA;\n\tSun, 2 Jun 2024 01:00:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C623461A46\n\tfor ;\n\tSun, 2 Jun 2024 01:00:20 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 66D46675;\n\tSun, 2 Jun 2024 01:00:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pNtqeFSu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717282814;\n\tbh=dgsfJ+FPQqDFdi5x331nx2EUmTZJu7i0lx2ZZJVISLQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pNtqeFSuOHDRvjBcGwJqPANymogoUB/HtwPnccD//3KunnQDB4Rl64X0FS4AKSrbZ\n\tCdxpxpF2ERzpb9XsdVZbzVylB5gL48UBiZ7UTnvroBNFE3cYVJ8E0evWM10WYz9mB0\n\tSydrlVOtQr56cpednl1CwIo6V3/0XEkZPGHTeTw0=","Date":"Sun, 2 Jun 2024 02:00:06 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\tAndrei Konovalov ","Subject":"Re: [PATCH v6 5/5] libcamera: software_isp: Remove TODO about\n\tinternal representation","Message-ID":"<20240601230006.GC6683@pendragon.ideasonboard.com>","References":"<20240531123840.713364-1-mzamazal@redhat.com>\n\t<20240531123840.713364-6-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240531123840.713364-6-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]