[{"id":29696,"web_url":"https://patchwork.libcamera.org/comment/29696/","msgid":"<171715634118.1000377.17543853574168472348@ping.linuxembedded.co.uk>","date":"2024-05-31T11:52:21","subject":"Re: [PATCH] test: ipa: rkisp1-utils: Fix capitalization of hex\n\tnumbers","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2024-05-31 12:42:16)\n> Fix capitalization of the hexdecimal numbers in the test for conversion\n> between floating point and fixed point numbers.\n> \n\nI wonder when we'll get this in a checkstyle rule :-)\n\nReviewed-by: Kieran Bingham \n\n--\nKieran\n\n\n> Signed-off-by: Paul Elder \n> ---\n> test/ipa/rkisp1/rkisp1-utils.cpp | 14 +++++++-------\n> 1 file changed, 7 insertions(+), 7 deletions(-)\n> \n> diff --git a/test/ipa/rkisp1/rkisp1-utils.cpp b/test/ipa/rkisp1/rkisp1-utils.cpp\n> index e9244ec44..9fff0cdce 100644\n> --- a/test/ipa/rkisp1/rkisp1-utils.cpp\n> +++ b/test/ipa/rkisp1/rkisp1-utils.cpp\n> @@ -53,13 +53,13 @@ protected:\n> * affect the result.\n> */\n> std::map testCases = {\n> - { 7.992, 0x3FF },\n> - { 7.992, 0xBFF },\n> - { 0.2, 0x01A },\n> - { -0.2, 0x7E6 },\n> - { -0.8, 0x79A },\n> - { -0.4, 0x7CD },\n> - { -1.4, 0x74D },\n> + { 7.992, 0x3ff },\n> + { 7.992, 0xbff },\n> + { 0.2, 0x01a },\n> + { -0.2, 0x7e6 },\n> + { -0.8, 0x79a },\n> + { -0.4, 0x7cd },\n> + { -1.4, 0x74d },\n> { -8, 0x400 },\n> { 0, 0 },\n> };\n> -- \n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9DFE6BD87C\n\tfor ;\n\tFri, 31 May 2024 11:52:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8BFCB634B6;\n\tFri, 31 May 2024 13:52:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 858D461A46\n\tfor ;\n\tFri, 31 May 2024 13:52:24 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72CEBE22;\n\tFri, 31 May 2024 13:52:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gLKUZyEm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717156339;\n\tbh=lqXHPDNo7dtStAyl2j7Q6/33+Tq5eG1DZxk7MwWf1q4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=gLKUZyEm3RAe2zkzajvrubpR18hdnpM1sA8d7kZHwLVXZdWQDCzTqbviPN1Paiioe\n\t/4LAcidSY954vfiGASw0XB0tBDaf44KpItACYuzQvnOauPtOYZsWHyg1p7b0XgXklf\n\tR6iQKlTj0Kyz5iK2lSFVC90HqoyAtPpYwFWmFdWQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240531114216.3418632-1-paul.elder@ideasonboard.com>","References":"<20240531114216.3418632-1-paul.elder@ideasonboard.com>","Subject":"Re: [PATCH] test: ipa: rkisp1-utils: Fix capitalization of hex\n\tnumbers","From":"Kieran Bingham ","Cc":"Paul Elder ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 31 May 2024 12:52:21 +0100","Message-ID":"<171715634118.1000377.17543853574168472348@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29697,"web_url":"https://patchwork.libcamera.org/comment/29697/","msgid":"<20240531121927.GA27757@pendragon.ideasonboard.com>","date":"2024-05-31T12:19:27","subject":"Re: [PATCH] test: ipa: rkisp1-utils: Fix capitalization of hex\n\tnumbers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, May 31, 2024 at 12:52:21PM +0100, Kieran Bingham wrote:\n> Quoting Paul Elder (2024-05-31 12:42:16)\n> > Fix capitalization of the hexdecimal numbers in the test for conversion\n> > between floating point and fixed point numbers.\n> \n> I wonder when we'll get this in a checkstyle rule :-)\n\nPatches are on the list :-)\n\n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> > Signed-off-by: Paul Elder \n> > ---\n> > test/ipa/rkisp1/rkisp1-utils.cpp | 14 +++++++-------\n> > 1 file changed, 7 insertions(+), 7 deletions(-)\n> > \n> > diff --git a/test/ipa/rkisp1/rkisp1-utils.cpp b/test/ipa/rkisp1/rkisp1-utils.cpp\n> > index e9244ec44..9fff0cdce 100644\n> > --- a/test/ipa/rkisp1/rkisp1-utils.cpp\n> > +++ b/test/ipa/rkisp1/rkisp1-utils.cpp\n> > @@ -53,13 +53,13 @@ protected:\n> > * affect the result.\n> > */\n> > std::map testCases = {\n> > - { 7.992, 0x3FF },\n> > - { 7.992, 0xBFF },\n> > - { 0.2, 0x01A },\n> > - { -0.2, 0x7E6 },\n> > - { -0.8, 0x79A },\n> > - { -0.4, 0x7CD },\n> > - { -1.4, 0x74D },\n> > + { 7.992, 0x3ff },\n> > + { 7.992, 0xbff },\n> > + { 0.2, 0x01a },\n> > + { -0.2, 0x7e6 },\n> > + { -0.8, 0x79a },\n> > + { -0.4, 0x7cd },\n> > + { -1.4, 0x74d },\n> > { -8, 0x400 },\n> > { 0, 0 },\n> > };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3BFCBD87C\n\tfor ;\n\tFri, 31 May 2024 12:19:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FDF3634BD;\n\tFri, 31 May 2024 14:19:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4BF54634B8\n\tfor ;\n\tFri, 31 May 2024 14:19:41 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 31AF322A;\n\tFri, 31 May 2024 14:19:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TZWtYZce\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717157976;\n\tbh=7ouVx9Fo4hJOkfnZ62cEqxuEwaiBEVQ2+V442aG5e0E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TZWtYZce7UHOwLrHY6Q9eRWp3YpIQxqWTafNC/c89ZJi6z7azN9zM1uFKQcVK5uyK\n\tX8+DXwkLukBqQmCg9Lh7nMFlJnuTafj1AbehT5MJdF/HV0RxSH5DspUD21tV2Tm8b8\n\tfobwjJy1k2f5FZMxIb/zf2Pbg3CBKow4Iayz/CXE=","Date":"Fri, 31 May 2024 15:19:27 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] test: ipa: rkisp1-utils: Fix capitalization of hex\n\tnumbers","Message-ID":"<20240531121927.GA27757@pendragon.ideasonboard.com>","References":"<20240531114216.3418632-1-paul.elder@ideasonboard.com>\n\t<171715634118.1000377.17543853574168472348@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<171715634118.1000377.17543853574168472348@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]