{"id":20153,"url":"https://patchwork.libcamera.org/api/patches/20153/?format=json","web_url":"https://patchwork.libcamera.org/patch/20153/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240530210957.2211897-2-mzamazal@redhat.com>","date":"2024-05-30T21:09:53","name":"[v5,1/5] libcamera: software_isp: Use a specific integer type for black level","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"914eab5a6e21c32e8cf665abcd704820b9094ddd","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20153/mbox/","series":[{"id":4342,"url":"https://patchwork.libcamera.org/api/series/4342/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4342","date":"2024-05-30T21:09:52","name":"Software ISP levels cleanup","version":5,"mbox":"https://patchwork.libcamera.org/series/4342/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20153/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20153/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 468B4BD87C\n\tfor ;\n\tThu, 30 May 2024 21:10:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF073634BA;\n\tThu, 30 May 2024 23:10:23 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1D40634B5\n\tfor ;\n\tThu, 30 May 2024 23:10:20 +0200 (CEST)","from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n\t[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-377-3MnYAzw8PrKiNgHgIMfblw-1; Thu, 30 May 2024 17:10:16 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id EDDD28058D1;\n\tThu, 30 May 2024 21:10:15 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.224.24])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0129940C6EB7;\n\tThu, 30 May 2024 21:10:13 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"AFdcwuLO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1717103420;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=WQa/iD8tOxjW06QizxUm8aX0OapgFoAkAtI5JQNluMg=;\n\tb=AFdcwuLOq2vFqce60tdzakWTRUuh7ZsTBZLCx6AC0blV+c8K19f3t6AyG3n0jYU/3RHl5q\n\tJNsuZYzvl0iL0sm7g+K3PcY4a2qGEHujNCvDnMBTR2S3jIHSXsOL4mzBXvhduXfk30gX+C\n\t6QbmDXopObZ5B7ZtkQ6FjDSUcbeFQMk=","X-MC-Unique":"3MnYAzw8PrKiNgHgIMfblw-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tKieran Bingham ,\n\tAndrei Konovalov ,\n\tLaurent Pinchart ","Subject":"[PATCH v5 1/5] libcamera: software_isp: Use a specific integer type\n\tfor black level","Date":"Thu, 30 May 2024 23:09:53 +0200","Message-ID":"<20240530210957.2211897-2-mzamazal@redhat.com>","In-Reply-To":"<20240530210957.2211897-1-mzamazal@redhat.com>","References":"<20240530210957.2211897-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.11.54.2","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The documented range of values corresponds to uint8_t, so let's use that\ntype.\n\nSigned-off-by: Milan Zamazal \nReviewed-by: Laurent Pinchart \nReviewed-by: Andrei Konovalov \n---\n src/ipa/simple/black_level.cpp | 2 +-\n src/ipa/simple/black_level.h | 5 +++--\n 2 files changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/src/ipa/simple/black_level.cpp b/src/ipa/simple/black_level.cpp\nindex 53b4c040..cc490eb5 100644\n--- a/src/ipa/simple/black_level.cpp\n+++ b/src/ipa/simple/black_level.cpp\n@@ -43,7 +43,7 @@ BlackLevel::BlackLevel()\n * \\return The black level, in the range from 0 (minimum) to 255 (maximum).\n * If the black level couldn't be determined yet, return 0.\n */\n-unsigned int BlackLevel::get() const\n+uint8_t BlackLevel::get() const\n {\n \treturn blackLevelSet_ ? blackLevel_ : 0;\n }\ndiff --git a/src/ipa/simple/black_level.h b/src/ipa/simple/black_level.h\nindex 25094217..5e032f9f 100644\n--- a/src/ipa/simple/black_level.h\n+++ b/src/ipa/simple/black_level.h\n@@ -8,6 +8,7 @@\n #pragma once\n \n #include \n+#include \n \n #include \"libcamera/internal/software_isp/swisp_stats.h\"\n \n@@ -17,11 +18,11 @@ class BlackLevel\n {\n public:\n \tBlackLevel();\n-\tunsigned int get() const;\n+\tuint8_t get() const;\n \tvoid update(SwIspStats::Histogram &yHistogram);\n \n private:\n-\tunsigned int blackLevel_;\n+\tuint8_t blackLevel_;\n \tbool blackLevelSet_;\n };\n \n","prefixes":["v5","1/5"]}