{"id":2015,"url":"https://patchwork.libcamera.org/api/patches/2015/?format=json","web_url":"https://patchwork.libcamera.org/patch/2015/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190924172503.30864-17-jacopo@jmondi.org>","date":"2019-09-24T17:24:58","name":"[libcamera-devel,16/21] ipa: Remove IPAInterface::init()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0bd8910af62e0db59b8e5c623e39f83c0bf10a8d","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2015/mbox/","series":[{"id":506,"url":"https://patchwork.libcamera.org/api/series/506/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=506","date":"2019-09-24T17:24:42","name":"Implement control serialization","version":1,"mbox":"https://patchwork.libcamera.org/series/506/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2015/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2015/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A10762378\n\tfor ;\n\tTue, 24 Sep 2019 19:23:38 +0200 (CEST)","from uno.homenet.telecomitalia.it\n\t(host89-248-dynamic.45-213-r.retail.telecomitalia.it [213.45.248.89])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 42B0560006\n\tfor ;\n\tTue, 24 Sep 2019 17:23:38 +0000 (UTC)"],"X-Originating-IP":"213.45.248.89","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 24 Sep 2019 19:24:58 +0200","Message-Id":"<20190924172503.30864-17-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20190924172503.30864-1-jacopo@jmondi.org>","References":"<20190924172503.30864-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 16/21] ipa: Remove IPAInterface::init()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 24 Sep 2019 17:23:39 -0000"},"content":"From: Niklas Söderlund \n\nThe function performs no useful task and will not be needed when we\nextend the IPA interface to process parameter and statistic buffers.\n\nReviewed-by: Jacopo Mondi \nSigned-off-by: Niklas Söderlund \n[jacopo: Remove init() method in ipa_proxy_linux.cpp]\nSigned-off-by: Jacopo Mondi \n---\n include/ipa/ipa_interface.h | 2 --\n src/ipa/ipa_dummy.cpp | 10 ----------\n src/libcamera/ipa_interface.cpp | 5 -----\n src/libcamera/pipeline/vimc.cpp | 2 --\n src/libcamera/proxy/ipa_proxy_linux.cpp | 9 ---------\n 5 files changed, 28 deletions(-)","diff":"diff --git a/include/ipa/ipa_interface.h b/include/ipa/ipa_interface.h\nindex 2c5eb1fd5243..9bbc4cf58ec6 100644\n--- a/include/ipa/ipa_interface.h\n+++ b/include/ipa/ipa_interface.h\n@@ -13,8 +13,6 @@ class IPAInterface\n {\n public:\n \tvirtual ~IPAInterface() {}\n-\n-\tvirtual int init() = 0;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_dummy.cpp\nindex 9d0cbdc8b1ad..c833e5fb0b2d 100644\n--- a/src/ipa/ipa_dummy.cpp\n+++ b/src/ipa/ipa_dummy.cpp\n@@ -5,8 +5,6 @@\n * ipa_dummy.cpp - Dummy Image Processing Algorithm module\n */\n \n-#include \n-\n #include \n #include \n \n@@ -14,16 +12,8 @@ namespace libcamera {\n \n class IPADummy : public IPAInterface\n {\n-public:\n-\tint init();\n };\n \n-int IPADummy::init()\n-{\n-\tstd::cout << \"initializing dummy IPA!\" << std::endl;\n-\treturn 0;\n-}\n-\n /*\n * External IPA module interface\n */\ndiff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\nindex d7d8ca8881ef..f70d91ded1ab 100644\n--- a/src/libcamera/ipa_interface.cpp\n+++ b/src/libcamera/ipa_interface.cpp\n@@ -19,9 +19,4 @@ namespace libcamera {\n * \\brief Interface for IPA implementation\n */\n \n-/**\n- * \\fn IPAInterface::init()\n- * \\brief Initialise the IPAInterface\n- */\n-\n } /* namespace libcamera */\ndiff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex 80a71f7cd5fd..499ce59181c5 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -364,8 +364,6 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n \tipa_ = IPAManager::instance()->createIPA(this, 0, 0);\n \tif (ipa_ == nullptr)\n \t\tLOG(VIMC, Warning) << \"no matching IPA found\";\n-\telse\n-\t\tipa_->init();\n \n \tstd::unique_ptr data = utils::make_unique(this);\n \ndiff --git a/src/libcamera/proxy/ipa_proxy_linux.cpp b/src/libcamera/proxy/ipa_proxy_linux.cpp\nindex 62fcb529e1c7..c9eaedff0224 100644\n--- a/src/libcamera/proxy/ipa_proxy_linux.cpp\n+++ b/src/libcamera/proxy/ipa_proxy_linux.cpp\n@@ -26,8 +26,6 @@ public:\n \tIPAProxyLinux(IPAModule *ipam);\n \t~IPAProxyLinux();\n \n-\tint init();\n-\n private:\n \tvoid readyRead(IPCUnixSocket *ipc);\n \n@@ -36,13 +34,6 @@ private:\n \tIPCUnixSocket *socket_;\n };\n \n-int IPAProxyLinux::init()\n-{\n-\tLOG(IPAProxy, Debug) << \"initializing IPA via dummy proxy!\";\n-\n-\treturn 0;\n-}\n-\n IPAProxyLinux::IPAProxyLinux(IPAModule *ipam)\n \t: proc_(nullptr), socket_(nullptr)\n {\n","prefixes":["libcamera-devel","16/21"]}