{"id":20142,"url":"https://patchwork.libcamera.org/api/patches/20142/?format=json","web_url":"https://patchwork.libcamera.org/patch/20142/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240529194251.863689-3-paul.elder@ideasonboard.com>","date":"2024-05-29T19:42:49","name":"[v3,2/4] utils: tuning: rkisp1: Add skeletal AGC to the rkisp1 tuning script","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a59e89371d7d295424e4f2bd1d4c2adaa947ebee","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20142/mbox/","series":[{"id":4339,"url":"https://patchwork.libcamera.org/api/series/4339/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4339","date":"2024-05-29T19:42:47","name":"utils: tuning: Add AGC and CCM","version":3,"mbox":"https://patchwork.libcamera.org/series/4339/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20142/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20142/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75BBFBDE6B\n\tfor ;\n\tWed, 29 May 2024 19:44:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 048C5634C8;\n\tWed, 29 May 2024 21:44:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 701DF634C2\n\tfor ;\n\tWed, 29 May 2024 21:44:05 +0200 (CEST)","from neptunite.hamster-moth.ts.net\n\t(h175-177-049-156.catv02.itscom.jp [175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0353B2D31;\n\tWed, 29 May 2024 21:43:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c8tOAwZW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717011841;\n\tbh=nVO5rPCbzvVbHR4CyGheeYI4KRk2ybF5DKInajZN+yQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=c8tOAwZWjs/EsrnGKUTHzoPrU5iz+cBunUEHDN9ZoSZ+xIyz0UtgltoZB4Q5NulCE\n\txqtlFwvRyZOAWG63Jgjy3nCw3uPBYERy25mBAtLP+CXjpTJCGfMCUlDB07qRSx/psZ\n\tDZvQbcin8dg6ZdVkOpN2mGOP3Oa20boS+PmckcdE=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder ,\n\tStefan Klug ,\n\tDaniel Scally ","Subject":"[PATCH v3 2/4] utils: tuning: rkisp1: Add skeletal AGC to the rkisp1\n\ttuning script","Date":"Thu, 30 May 2024 04:42:49 +0900","Message-Id":"<20240529194251.863689-3-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","In-Reply-To":"<20240529194251.863689-1-paul.elder@ideasonboard.com>","References":"<20240529194251.863689-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add the skeletal AGC module to the rkisp1 tuning script. For now it just\nspits out hardcoded values.\n\nSigned-off-by: Paul Elder \nReviewed-by: Stefan Klug \nReviewed-by: Daniel Scally \n\n---\nNo change in v3\n\nChanges in v2:\n- remove hw_rev parameter from the rkisp1 agc tuning module, as the\n tuning file should support both hardware revisions simultaneously\n---\n utils/tuning/rkisp1.py | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\nindex 517c791e6..d0ce15d5e 100755\n--- a/utils/tuning/rkisp1.py\n+++ b/utils/tuning/rkisp1.py\n@@ -11,6 +11,7 @@ import libtuning as lt\n from libtuning.parsers import YamlParser\n from libtuning.generators import YamlOutput\n from libtuning.modules.lsc import LSCRkISP1\n+from libtuning.modules.agc import AGCRkISP1\n \n tuner = lt.Tuner('RkISP1')\n tuner.add(LSCRkISP1(\n@@ -32,9 +33,10 @@ tuner.add(LSCRkISP1(\n # values. This can also be a custom function.\n smoothing_function=lt.smoothing.MedianBlur(3),\n ))\n+tuner.add(AGCRkISP1(debug=[lt.Debug.Plot]))\n tuner.set_input_parser(YamlParser())\n tuner.set_output_formatter(YamlOutput())\n-tuner.set_output_order([LSCRkISP1])\n+tuner.set_output_order([AGCRkISP1, LSCRkISP1])\n \n if __name__ == '__main__':\n sys.exit(tuner.run(sys.argv))\n","prefixes":["v3","2/4"]}