{"id":20123,"url":"https://patchwork.libcamera.org/api/patches/20123/?format=json","web_url":"https://patchwork.libcamera.org/patch/20123/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240529154341.10426-6-laurent.pinchart@ideasonboard.com>","date":"2024-05-29T15:43:40","name":"[v2,5/6] test: v4l2_videodevice: Increase timeout for vimc capture tests","commit_ref":"73f18f32c958d681126394fa7556828805221f69","pull_url":null,"state":"accepted","archived":false,"hash":"4f6f693f649de6ce5ffc15a9659d6fd15045c926","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20123/mbox/","series":[{"id":4333,"url":"https://patchwork.libcamera.org/api/series/4333/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4333","date":"2024-05-29T15:43:35","name":"vimc scaling improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/4333/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20123/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20123/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 509A9BDE6B\n\tfor ;\n\tWed, 29 May 2024 15:44:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF115634C6;\n\tWed, 29 May 2024 17:44:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0750634BA\n\tfor ;\n\tWed, 29 May 2024 17:43:59 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2569E149B\n\tfor ;\n\tWed, 29 May 2024 17:43:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i+z4xdIC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716997436;\n\tbh=bUPY7XPjTlm9uXOp8blQK9548NSEm5tq5BNvcpWljHQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=i+z4xdIC/wO2ZJJOfkK8G5XsctvbGgeUD9tCMGLhIov8ZN/LEHTb/1b7JuwaJ/BX+\n\tqBbFsTkvbXcgD34Ma9BcxCDIzkH+8wD4AOlwgCAGV7spXybIT7jpMHbbop0P9rvt57\n\tVsZWSSHJXaQVvR7xQRP2fZXo9UhHDS4XdgKf03s8=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 5/6] test: v4l2_videodevice: Increase timeout for vimc\n\tcapture tests","Date":"Wed, 29 May 2024 18:43:40 +0300","Message-ID":"<20240529154341.10426-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.1","In-Reply-To":"<20240529154341.10426-1-laurent.pinchart@ideasonboard.com>","References":"<20240529154341.10426-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"On slower machines, a 10s timeout to capture frames with vimc can be too\nshort and cause test failures. Make the timeout proportional to the\nnumber of frames expected to be captured, using a conservative low\nestimate of the frame rate at 2fps. This does not increase the test time\nif the vimc driver is fast enough to produce frames.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\nChanges since v1:\n\n- Fix the timeout duration mentioned in the commit message\n---\n test/v4l2_videodevice/capture_async.cpp | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)","diff":"diff --git a/test/v4l2_videodevice/capture_async.cpp b/test/v4l2_videodevice/capture_async.cpp\nindex 42e1e671790b..673664615ada 100644\n--- a/test/v4l2_videodevice/capture_async.cpp\n+++ b/test/v4l2_videodevice/capture_async.cpp\n@@ -61,10 +61,12 @@ protected:\n \t\tif (ret)\n \t\t\treturn TestFail;\n \n-\t\ttimeout.start(10000ms);\n+\t\tconst unsigned int nFrames = 30;\n+\n+\t\ttimeout.start(500ms * nFrames);\n \t\twhile (timeout.isRunning()) {\n \t\t\tdispatcher->processEvents();\n-\t\t\tif (frames > 30)\n+\t\t\tif (frames > nFrames)\n \t\t\t\tbreak;\n \t\t}\n \n@@ -73,8 +75,9 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\tif (frames < 30) {\n-\t\t\tstd::cout << \"Failed to capture 30 frames within timeout.\" << std::endl;\n+\t\tif (frames < nFrames) {\n+\t\t\tstd::cout << \"Failed to capture \" << nFrames\n+\t\t\t\t << \" frames within timeout.\" << std::endl;\n \t\t\treturn TestFail;\n \t\t}\n \n","prefixes":["v2","5/6"]}